Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-07-08 03:32:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Polish RequestRejectedHandler

Browse Source 
Issue gh-5007
This commit is contained in:
Rob Winch 2020-05-01 10:50:14 -05:00
parent b826c798f7
commit 0483b3e042
6 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/main/java/org/springframework/security/web/FilterChainProxy.java
View File

@ -183,7 +183,7 @@ public class FilterChainProxy extends GenericFilterBean {
request.setAttribute(FILTER_APPLIED, Boolean.TRUE); request.setAttribute(FILTER_APPLIED, Boolean.TRUE);
doFilterInternal(request, response, chain); doFilterInternal(request, response, chain);
} catch (RequestRejectedException e) { } catch (RequestRejectedException e) {
requestRejectedHandler.handle((HttpServletRequest) request, (HttpServletResponse) response, e); this.requestRejectedHandler.handle((HttpServletRequest) request, (HttpServletResponse) response, e);
} }
finally { finally {
SecurityContextHolder.clearContext(); SecurityContextHolder.clearContext();

4
web/src/main/java/org/springframework/security/web/firewall/DefaultRequestRejectedHandler.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2018 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -25,7 +25,7 @@ import javax.servlet.http.HttpServletResponse;
* Default implementation of {@link RequestRejectedHandler} that simply rethrows the exception. * Default implementation of {@link RequestRejectedHandler} that simply rethrows the exception.
* *
* @author Leonard Brünings * @author Leonard Brünings
* @since 5.2 * @since 5.4
*/ */
public class DefaultRequestRejectedHandler implements RequestRejectedHandler { public class DefaultRequestRejectedHandler implements RequestRejectedHandler {
@Override @Override

4
web/src/main/java/org/springframework/security/web/firewall/HttpStatusRequestRejectedHandler.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2018 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -27,7 +27,7 @@ import org.apache.commons.logging.LogFactory;
* A simple implementation of {@link RequestRejectedHandler} that sends an error with configurable status code. * A simple implementation of {@link RequestRejectedHandler} that sends an error with configurable status code.
* *
* @author Leonard Brünings * @author Leonard Brünings
* @since 5.2 * @since 5.4
*/ */
public class HttpStatusRequestRejectedHandler implements RequestRejectedHandler { public class HttpStatusRequestRejectedHandler implements RequestRejectedHandler {
private static final Log logger = LogFactory.getLog(HttpStatusRequestRejectedHandler.class); private static final Log logger = LogFactory.getLog(HttpStatusRequestRejectedHandler.class);

4
web/src/main/java/org/springframework/security/web/firewall/RequestRejectedHandler.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2018 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -26,7 +26,7 @@ import javax.servlet.http.HttpServletResponse;
* <code>RequestRejectedException</code>. * <code>RequestRejectedException</code>.
* *
* @author Leonard Brünings * @author Leonard Brünings
* @since 5.2 * @since 5.4
*/ */
public interface RequestRejectedHandler { public interface RequestRejectedHandler {
// ~ Methods // ~ Methods

4
web/src/test/java/org/springframework/security/web/firewall/DefaultRequestRejectedHandlerTest.java → web/src/test/java/org/springframework/security/web/firewall/DefaultRequestRejectedHandlerTests.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2016 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -25,7 +25,7 @@ import org.hamcrest.CoreMatchers;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
public class DefaultRequestRejectedHandlerTest { public class DefaultRequestRejectedHandlerTests {
@Test @Test
public void defaultRequestRejectedHandlerRethrowsTheException() throws Exception { public void defaultRequestRejectedHandlerRethrowsTheException() throws Exception {

4
web/src/test/java/org/springframework/security/web/firewall/HttpStatusRequestRejectedHandlerTest.java → web/src/test/java/org/springframework/security/web/firewall/HttpStatusRequestRejectedHandlerTests.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2016 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -24,7 +24,7 @@ import javax.servlet.http.HttpServletResponse;
import org.junit.Test; import org.junit.Test;
public class HttpStatusRequestRejectedHandlerTest { public class HttpStatusRequestRejectedHandlerTests {
@Test @Test
public void httpStatusRequestRejectedHandlerUsesStatus400byDefault() throws Exception { public void httpStatusRequestRejectedHandlerUsesStatus400byDefault() throws Exception {