Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-08 21:22:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-1705: Make sure a single OpenIDAuthenticationFilter bean is created by the namespace. Likewise for UsernamePasswordAuthenticationFilter.

Browse Source
This commit is contained in:
Luke Taylor 2011-03-31 21:04:32 +01:00
parent 6a87a5f1a1
commit 04d42211b1
2 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java
View File

@ -81,10 +81,8 @@ final class AuthenticationConfigBuilder {
private String rememberMeServicesId; private String rememberMeServicesId;
private BeanReference rememberMeProviderRef; private BeanReference rememberMeProviderRef;
private BeanDefinition basicFilter; private BeanDefinition basicFilter;
private BeanReference basicEntryPoint; private RuntimeBeanReference basicEntryPoint;
private RootBeanDefinition formFilter;
private BeanDefinition formEntryPoint; private BeanDefinition formEntryPoint;
private RootBeanDefinition openIDFilter;
private BeanDefinition openIDEntryPoint; private BeanDefinition openIDEntryPoint;
private BeanReference openIDProviderRef; private BeanReference openIDProviderRef;
private String openIDProviderId; private String openIDProviderId;
@ -141,6 +139,7 @@ final class AuthenticationConfigBuilder {
void createFormLoginFilter(BeanReference sessionStrategy, BeanReference authManager) { void createFormLoginFilter(BeanReference sessionStrategy, BeanReference authManager) {
Element formLoginElt = DomUtils.getChildElementByTagName(httpElt, Elements.FORM_LOGIN); Element formLoginElt = DomUtils.getChildElementByTagName(httpElt, Elements.FORM_LOGIN);
RootBeanDefinition formFilter = null;
if (formLoginElt != null || autoConfig) { if (formLoginElt != null || autoConfig) {
FormLoginBeanDefinitionParser parser = new FormLoginBeanDefinitionParser("/j_spring_security_check", FormLoginBeanDefinitionParser parser = new FormLoginBeanDefinitionParser("/j_spring_security_check",
@ -165,6 +164,7 @@ final class AuthenticationConfigBuilder {
void createOpenIDLoginFilter(BeanReference sessionStrategy, BeanReference authManager) { void createOpenIDLoginFilter(BeanReference sessionStrategy, BeanReference authManager) {
Element openIDLoginElt = DomUtils.getChildElementByTagName(httpElt, Elements.OPENID_LOGIN); Element openIDLoginElt = DomUtils.getChildElementByTagName(httpElt, Elements.OPENID_LOGIN);
RootBeanDefinition openIDFilter = null;
if (openIDLoginElt != null) { if (openIDLoginElt != null) {
FormLoginBeanDefinitionParser parser = new FormLoginBeanDefinitionParser("/j_spring_openid_security_check", FormLoginBeanDefinitionParser parser = new FormLoginBeanDefinitionParser("/j_spring_openid_security_check",
@ -318,7 +318,7 @@ final class AuthenticationConfigBuilder {
void createLoginPageFilterIfNeeded() { void createLoginPageFilterIfNeeded() {
boolean needLoginPage = formFilter != null || openIDFilter != null; boolean needLoginPage = formFilterId != null || openIDFilterId != null;
String formLoginPage = getLoginFormUrl(formEntryPoint); String formLoginPage = getLoginFormUrl(formEntryPoint);
String openIDLoginPage = getLoginFormUrl(openIDEntryPoint); String openIDLoginPage = getLoginFormUrl(openIDEntryPoint);
@ -329,11 +329,11 @@ final class AuthenticationConfigBuilder {
BeanDefinitionBuilder loginPageFilter = BeanDefinitionBuilder loginPageFilter =
BeanDefinitionBuilder.rootBeanDefinition(DefaultLoginPageGeneratingFilter.class); BeanDefinitionBuilder.rootBeanDefinition(DefaultLoginPageGeneratingFilter.class);
if (formFilter != null) { if (formFilterId != null) {
loginPageFilter.addConstructorArgReference(formFilterId); loginPageFilter.addConstructorArgReference(formFilterId);
} }
if (openIDFilter != null) { if (openIDFilterId != null) {
loginPageFilter.addConstructorArgReference(openIDFilterId); loginPageFilter.addConstructorArgReference(openIDFilterId);
} }
@ -497,12 +497,12 @@ final class AuthenticationConfigBuilder {
"but not both.", pc.extractSource(openIDLoginElt)); "but not both.", pc.extractSource(openIDLoginElt));
} }
if (formFilter != null && openIDLoginPage == null) { if (formFilterId != null && openIDLoginPage == null) {
return formEntryPoint; return formEntryPoint;
} }
// Otherwise use OpenID if enabled // Otherwise use OpenID if enabled
if (openIDFilter != null) { if (openIDFilterId != null) {
return openIDEntryPoint; return openIDEntryPoint;
} }
@ -566,12 +566,12 @@ final class AuthenticationConfigBuilder {
filters.add(new OrderDecorator(x509Filter, X509_FILTER)); filters.add(new OrderDecorator(x509Filter, X509_FILTER));
} }
if (formFilter != null) { if (formFilterId != null) {
filters.add(new OrderDecorator(formFilter, FORM_LOGIN_FILTER)); filters.add(new OrderDecorator(new RuntimeBeanReference(formFilterId), FORM_LOGIN_FILTER));
} }
if (openIDFilter != null) { if (openIDFilterId != null) {
filters.add(new OrderDecorator(openIDFilter, OPENID_FILTER)); filters.add(new OrderDecorator(new RuntimeBeanReference(openIDFilterId), OPENID_FILTER));
} }
if (loginPageGenerationFilter != null) { if (loginPageGenerationFilter != null) {

13
samples/openid/openid.gradle
View File

@ -6,8 +6,13 @@ apply plugin: 'jetty'
dependencies { dependencies {
providedCompile 'javax.servlet:servlet-api:2.5@jar' providedCompile 'javax.servlet:servlet-api:2.5@jar'
runtime project(':spring-security-web'), runtime project(':spring-security-config'),
project(':spring-security-config'), project(':spring-security-taglibs'),
project(':spring-security-openid'), // 'xerces:xercesImpl:2.9.1',
'log4j:log4j:1.2.15@jar' // 'net.sourceforge.nekohtml:nekohtml:1.9.7',
"javax.servlet:jstl:$jstlVersion",
"org.slf4j:jcl-over-slf4j:$slf4jVersion",
"ch.qos.logback:logback-classic:$logbackVersion"
} }
[jettyRun, jettyRunWar]*.contextPath = "/openid"