Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-05-31 01:02:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Polish HttpSessionOAuth2AuthorizationRequestRepositoryTests

Browse Source 
Fixes: gh-5147
This commit is contained in:
Rob Winch 2018-03-20 16:34:04 -05:00
parent 59cef7d339
commit 04e2e86e6e
1 changed files with 47 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/web/HttpSessionOAuth2AuthorizationRequestRepositoryTests.java
View File

@ -15,26 +15,23 @@
*/ */
package org.springframework.security.oauth2.client.web; package org.springframework.security.oauth2.client.web;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.powermock.core.classloader.annotations.PrepareForTest; import org.mockito.junit.MockitoJUnitRunner;
import org.powermock.modules.junit4.PowerMockRunner;
import org.springframework.mock.web.MockHttpServletRequest; import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse; import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.security.oauth2.core.endpoint.OAuth2AuthorizationRequest; import org.springframework.security.oauth2.core.endpoint.OAuth2AuthorizationRequest;
import org.springframework.security.oauth2.core.endpoint.OAuth2ParameterNames; import org.springframework.security.oauth2.core.endpoint.OAuth2ParameterNames;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
/** /**
* Tests for {@link HttpSessionOAuth2AuthorizationRequestRepository}. * Tests for {@link HttpSessionOAuth2AuthorizationRequestRepository}.
* *
* @author Joe Grandja * @author Joe Grandja
*/ */
@PrepareForTest(OAuth2AuthorizationRequest.class) @RunWith(MockitoJUnitRunner.class)
@RunWith(PowerMockRunner.class)
public class HttpSessionOAuth2AuthorizationRequestRepositoryTests { public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
private HttpSessionOAuth2AuthorizationRequestRepository authorizationRequestRepository = private HttpSessionOAuth2AuthorizationRequestRepository authorizationRequestRepository =
new HttpSessionOAuth2AuthorizationRequestRepository(); new HttpSessionOAuth2AuthorizationRequestRepository();
@ -59,11 +56,10 @@ public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletRequest request = new MockHttpServletRequest();
MockHttpServletResponse response = new MockHttpServletResponse(); MockHttpServletResponse response = new MockHttpServletResponse();
OAuth2AuthorizationRequest authorizationRequest = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
when(authorizationRequest.getState()).thenReturn("state-1234");
this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest, request, response); this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest, request, response);
request.addParameter(OAuth2ParameterNames.STATE, "state-1234"); request.addParameter(OAuth2ParameterNames.STATE, authorizationRequest.getState());
OAuth2AuthorizationRequest loadedAuthorizationRequest = OAuth2AuthorizationRequest loadedAuthorizationRequest =
this.authorizationRequestRepository.loadAuthorizationRequest(request); this.authorizationRequestRepository.loadAuthorizationRequest(request);
@ -77,18 +73,15 @@ public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
MockHttpServletResponse response = new MockHttpServletResponse(); MockHttpServletResponse response = new MockHttpServletResponse();
String state1 = "state-1122"; String state1 = "state-1122";
OAuth2AuthorizationRequest authorizationRequest1 = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest1 = createAuthorizationRequest().state(state1).build();
when(authorizationRequest1.getState()).thenReturn(state1);
this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest1, request, response); this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest1, request, response);
String state2 = "state-3344"; String state2 = "state-3344";
OAuth2AuthorizationRequest authorizationRequest2 = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest2 = createAuthorizationRequest().state(state2).build();
when(authorizationRequest2.getState()).thenReturn(state2);
this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest2, request, response); this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest2, request, response);
String state3 = "state-5566"; String state3 = "state-5566";
OAuth2AuthorizationRequest authorizationRequest3 = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest3 = createAuthorizationRequest().state(state3).build();
when(authorizationRequest3.getState()).thenReturn(state3);
this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest3, request, response); this.authorizationRequestRepository.saveAuthorizationRequest(authorizationRequest3, request, response);
request.addParameter(OAuth2ParameterNames.STATE, state1); request.addParameter(OAuth2ParameterNames.STATE, state1);
@ -109,46 +102,55 @@ public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
assertThat(loadedAuthorizationRequest3).isEqualTo(authorizationRequest3); assertThat(loadedAuthorizationRequest3).isEqualTo(authorizationRequest3);
} }
@Test(expected = IllegalArgumentException.class) @Test
public void loadAuthorizationRequestWhenSavedAndStateParameterNullThenThrowIllegalArgumentException() { public void loadAuthorizationRequestWhenSavedAndStateParameterNullThenThrowIllegalArgumentException() {
MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletRequest request = new MockHttpServletRequest();
OAuth2AuthorizationRequest authorizationRequest = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
when(authorizationRequest.getState()).thenReturn("state-1234");
this.authorizationRequestRepository.saveAuthorizationRequest( this.authorizationRequestRepository.saveAuthorizationRequest(
authorizationRequest, request, new MockHttpServletResponse()); authorizationRequest, request, new MockHttpServletResponse());
this.authorizationRequestRepository.loadAuthorizationRequest(request); assertThatThrownBy(() -> this.authorizationRequestRepository.loadAuthorizationRequest(request))
.isInstanceOf(IllegalArgumentException.class);
} }
@Test(expected = IllegalArgumentException.class) @Test
public void saveAuthorizationRequestWhenHttpServletRequestIsNullThenThrowIllegalArgumentException() { public void saveAuthorizationRequestWhenHttpServletRequestIsNullThenThrowIllegalArgumentException() {
this.authorizationRequestRepository.saveAuthorizationRequest( OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
mock(OAuth2AuthorizationRequest.class), null, new MockHttpServletResponse());
assertThatThrownBy(() -> this.authorizationRequestRepository.saveAuthorizationRequest(
authorizationRequest, null, new MockHttpServletResponse()))
.isInstanceOf(IllegalArgumentException.class);
} }
@Test(expected = IllegalArgumentException.class) @Test
public void saveAuthorizationRequestWhenHttpServletResponseIsNullThenThrowIllegalArgumentException() { public void saveAuthorizationRequestWhenHttpServletResponseIsNullThenThrowIllegalArgumentException() {
this.authorizationRequestRepository.saveAuthorizationRequest( OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
mock(OAuth2AuthorizationRequest.class), new MockHttpServletRequest(), null);
assertThatThrownBy(() -> this.authorizationRequestRepository.saveAuthorizationRequest(
authorizationRequest, new MockHttpServletRequest(), null))
.isInstanceOf(IllegalArgumentException.class);
} }
@Test(expected = IllegalArgumentException.class) @Test
public void saveAuthorizationRequestWhenStateNullThenThrowIllegalArgumentException() { public void saveAuthorizationRequestWhenStateNullThenThrowIllegalArgumentException() {
this.authorizationRequestRepository.saveAuthorizationRequest( OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest()
mock(OAuth2AuthorizationRequest.class), new MockHttpServletRequest(), new MockHttpServletResponse()); .state(null)
.build();
assertThatThrownBy(() -> this.authorizationRequestRepository.saveAuthorizationRequest(
authorizationRequest, new MockHttpServletRequest(), new MockHttpServletResponse()))
.isInstanceOf(IllegalArgumentException.class);
} }
@Test @Test
public void saveAuthorizationRequestWhenNotNullThenSaved() { public void saveAuthorizationRequestWhenNotNullThenSaved() {
MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletRequest request = new MockHttpServletRequest();
OAuth2AuthorizationRequest authorizationRequest = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
when(authorizationRequest.getState()).thenReturn("state-1234");
this.authorizationRequestRepository.saveAuthorizationRequest( this.authorizationRequestRepository.saveAuthorizationRequest(
authorizationRequest, request, new MockHttpServletResponse()); authorizationRequest, request, new MockHttpServletResponse());
request.addParameter(OAuth2ParameterNames.STATE, "state-1234"); request.addParameter(OAuth2ParameterNames.STATE, authorizationRequest.getState());
OAuth2AuthorizationRequest loadedAuthorizationRequest = OAuth2AuthorizationRequest loadedAuthorizationRequest =
this.authorizationRequestRepository.loadAuthorizationRequest(request); this.authorizationRequestRepository.loadAuthorizationRequest(request);
@ -160,13 +162,13 @@ public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletRequest request = new MockHttpServletRequest();
MockHttpServletResponse response = new MockHttpServletResponse(); MockHttpServletResponse response = new MockHttpServletResponse();
OAuth2AuthorizationRequest authorizationRequest = mock(OAuth2AuthorizationRequest.class);
when(authorizationRequest.getState()).thenReturn("state-1234"); OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
this.authorizationRequestRepository.saveAuthorizationRequest( // Save this.authorizationRequestRepository.saveAuthorizationRequest( // Save
authorizationRequest, request, response); authorizationRequest, request, response);
request.addParameter(OAuth2ParameterNames.STATE, "state-1234"); request.addParameter(OAuth2ParameterNames.STATE, authorizationRequest.getState());
this.authorizationRequestRepository.saveAuthorizationRequest( // Null value removes this.authorizationRequestRepository.saveAuthorizationRequest( // Null value removes
null, request, response); null, request, response);
@ -186,13 +188,12 @@ public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletRequest request = new MockHttpServletRequest();
MockHttpServletResponse response = new MockHttpServletResponse(); MockHttpServletResponse response = new MockHttpServletResponse();
OAuth2AuthorizationRequest authorizationRequest = mock(OAuth2AuthorizationRequest.class); OAuth2AuthorizationRequest authorizationRequest = createAuthorizationRequest().build();
when(authorizationRequest.getState()).thenReturn("state-1234");
this.authorizationRequestRepository.saveAuthorizationRequest( this.authorizationRequestRepository.saveAuthorizationRequest(
authorizationRequest, request, response); authorizationRequest, request, response);
request.addParameter(OAuth2ParameterNames.STATE, "state-1234"); request.addParameter(OAuth2ParameterNames.STATE, authorizationRequest.getState());
OAuth2AuthorizationRequest removedAuthorizationRequest = OAuth2AuthorizationRequest removedAuthorizationRequest =
this.authorizationRequestRepository.removeAuthorizationRequest(request); this.authorizationRequestRepository.removeAuthorizationRequest(request);
OAuth2AuthorizationRequest loadedAuthorizationRequest = OAuth2AuthorizationRequest loadedAuthorizationRequest =
@ -212,4 +213,11 @@ public class HttpSessionOAuth2AuthorizationRequestRepositoryTests {
assertThat(removedAuthorizationRequest).isNull(); assertThat(removedAuthorizationRequest).isNull();
} }
private OAuth2AuthorizationRequest.Builder createAuthorizationRequest() {
return OAuth2AuthorizationRequest.authorizationCode()
.authorizationUri("https://example.com/oauth2/authorize")
.clientId("client-id-1234")
.state("state-1234");
}
} }