Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-05-31 01:02:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

LdapUserDetails extends CredentialsContainer

Browse Source 
LdapUserDetails extends CredentialsContainer in order to clear password when erase-credentials is true.

Fixes gh-4029
This commit is contained in:
Juan Ignacio Barisich 2016-08-18 14:58:55 -03:00 committed by Joe Grandja
parent f8bfe19a98
commit 1171e25bc7
3 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetails.java
View File

@ -16,6 +16,7 @@
package org.springframework.security.ldap.userdetails;
import org.springframework.security.core.CredentialsContainer;
import org.springframework.security.core.userdetails.UserDetails;
/**
@ -23,7 +24,7 @@ import org.springframework.security.core.userdetails.UserDetails;
*
* @author Luke Taylor
*/
public interface LdapUserDetails extends UserDetails {
public interface LdapUserDetails extends UserDetails, CredentialsContainer {
// ~ Methods
// ========================================================================================================

5
ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsImpl.java
View File

@ -107,6 +107,11 @@ public class LdapUserDetailsImpl implements LdapUserDetails, PasswordPolicyData
return enabled;
}
@Override
public void eraseCredentials() {
password = null;
}
public int getTimeBeforeExpiration() {
return timeBeforeExpiration;
}

43
ldap/src/test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsImplTests.java Normal file
View File

@ -0,0 +1,43 @@
/*
* Copyright 2012-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.security.ldap.userdetails;
import org.junit.Test;
import org.springframework.security.core.CredentialsContainer;
import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link LdapUserDetailsImpl}
*
* @author Joe Grandja
*/
public class LdapUserDetailsImplTests {
@Test
public void credentialsAreCleared() {
LdapUserDetailsImpl.Essence mutableLdapUserDetails = new LdapUserDetailsImpl.Essence();
mutableLdapUserDetails.setDn("uid=username1,ou=people,dc=example,dc=com");
mutableLdapUserDetails.setUsername("username1");
mutableLdapUserDetails.setPassword("password");
LdapUserDetails ldapUserDetails = mutableLdapUserDetails.createUserDetails();
assertThat(ldapUserDetails).isInstanceOf(CredentialsContainer.class);
ldapUserDetails.eraseCredentials();
assertThat(ldapUserDetails.getPassword()).isNull();
}
}