Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-07-09 11:53:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-311: Must observe symmetry requirement of Object.equals(Object) contract.

Browse Source
This commit is contained in:
Ben Alex 2006-09-15 03:09:05 +00:00
parent cf91104b69
commit 1292420476
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/main/java/org/acegisecurity/SecurityConfig.java
View File

@ -35,10 +35,6 @@ public class SecurityConfig implements ConfigAttribute {
//~ Methods ======================================================================================================== //~ Methods ========================================================================================================
public boolean equals(Object obj) { public boolean equals(Object obj) {
if (obj instanceof String) {
return obj.equals(this.attrib);
}
if (obj instanceof ConfigAttribute) { if (obj instanceof ConfigAttribute) {
ConfigAttribute attr = (ConfigAttribute) obj; ConfigAttribute attr = (ConfigAttribute) obj;

3
core/src/test/java/org/acegisecurity/SecurityConfigTests.java
View File

@ -66,8 +66,9 @@ public class SecurityConfigTests extends TestCase {
SecurityConfig security2 = new SecurityConfig("TEST"); SecurityConfig security2 = new SecurityConfig("TEST");
assertEquals(security1, security2); assertEquals(security1, security2);
// SEC-311: Must observe symmetry requirement of Object.equals(Object) contract
String securityString1 = "TEST"; String securityString1 = "TEST";
assertEquals(security1, securityString1); assertNotSame(security1, securityString1);
String securityString2 = "NOT_EQUAL"; String securityString2 = "NOT_EQUAL";
assertTrue(!security1.equals(securityString2)); assertTrue(!security1.equals(securityString2));