diff --git a/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java b/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java index 795642e13b..1ce9842379 100644 --- a/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java +++ b/web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java @@ -57,7 +57,7 @@ public class DefaultSavedRequest implements SavedRequest { private final ArrayList cookies = new ArrayList(); private final ArrayList locales = new ArrayList(); private final Map> headers = new TreeMap>(String.CASE_INSENSITIVE_ORDER); - private final Map parameters = new TreeMap(String.CASE_INSENSITIVE_ORDER); + private final Map parameters = new TreeMap(); private final String contextPath; private final String method; private final String pathInfo; diff --git a/web/src/test/java/org/springframework/security/web/savedrequest/DefaultSavedRequestTests.java b/web/src/test/java/org/springframework/security/web/savedrequest/DefaultSavedRequestTests.java index 2c1913df16..da14e7767e 100644 --- a/web/src/test/java/org/springframework/security/web/savedrequest/DefaultSavedRequestTests.java +++ b/web/src/test/java/org/springframework/security/web/savedrequest/DefaultSavedRequestTests.java @@ -30,12 +30,15 @@ public class DefaultSavedRequestTests { assertTrue(saved.getHeaderValues("if-none-match").isEmpty()); } - // TODO: Why are parameters case insensitive. I think this is a mistake + // SEC-3082 @Test - public void parametersAreCaseInsensitive() throws Exception { + public void parametersAreCaseSensitive() throws Exception { MockHttpServletRequest request = new MockHttpServletRequest(); - request.addParameter("ThisIsATest", "Hi mom"); - DefaultSavedRequest saved = new DefaultSavedRequest(request, new MockPortResolver(8080, 8443)); + request.addParameter("AnotHerTest", "Hi dad"); + request.addParameter("thisisatest", "Hi mom"); + DefaultSavedRequest saved = new DefaultSavedRequest(request, + new MockPortResolver(8080, 8443)); assertEquals("Hi mom", saved.getParameterValues("thisisatest")[0]); + assertNull(saved.getParameterValues("anothertest")); } }