Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix JRun rejection of null in httpSession.setAttribute() as per http://livedocs.macromedia.com/jrun/4/javadocs/jrun/servlet/session/JRunSession.html. 

Discussed at http://forum.springframework.org/viewtopic.php?t=1417.
This commit is contained in:
Ben Alex 2004-10-30 02:56:01 +00:00
parent 73349bf8f8
commit 21f29bbbb3
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.txt
View File

@ -8,6 +8,7 @@ Changes in version 0.7 (2004-xx-xx)
* Added AuthenticationProcessingFilter.setDetails for use by subclasses * Added AuthenticationProcessingFilter.setDetails for use by subclasses
* Refactored MethodDefinitionSource to work with Method, not MethodInvocation * Refactored MethodDefinitionSource to work with Method, not MethodInvocation
* Refactored AbstractSecurityInterceptor to better support other AOP libraries * Refactored AbstractSecurityInterceptor to better support other AOP libraries
* Fixed AbstractProcessingFitler to use removeAttribute (JRun compatibility)
* Moved MethodSecurityInterceptor to ...intercept.method.aopalliance package * Moved MethodSecurityInterceptor to ...intercept.method.aopalliance package
* Documentation improvements * Documentation improvements

6
core/src/main/java/org/acegisecurity/ui/AbstractProcessingFilter.java
View File

@ -330,8 +330,7 @@ public abstract class AbstractProcessingFilter implements Filter,
httpRequest.getSession().setAttribute(ACEGI_SECURITY_LAST_EXCEPTION_KEY, httpRequest.getSession().setAttribute(ACEGI_SECURITY_LAST_EXCEPTION_KEY,
failed); failed);
httpRequest.getSession().setAttribute(HttpSessionIntegrationFilter.ACEGI_SECURITY_AUTHENTICATION_KEY, httpRequest.getSession().removeAttribute(HttpSessionIntegrationFilter.ACEGI_SECURITY_AUTHENTICATION_KEY);
null);
httpResponse.sendRedirect(httpResponse.encodeRedirectURL(httpRequest httpResponse.sendRedirect(httpResponse.encodeRedirectURL(httpRequest
.getContextPath() + failureUrl)); .getContextPath() + failureUrl));
@ -347,8 +346,7 @@ public abstract class AbstractProcessingFilter implements Filter,
authResult); authResult);
String targetUrl = (String) httpRequest.getSession().getAttribute(ACEGI_SECURITY_TARGET_URL_KEY); String targetUrl = (String) httpRequest.getSession().getAttribute(ACEGI_SECURITY_TARGET_URL_KEY);
httpRequest.getSession().setAttribute(ACEGI_SECURITY_TARGET_URL_KEY, httpRequest.getSession().removeAttribute(ACEGI_SECURITY_TARGET_URL_KEY);
null);
if (targetUrl == null) { if (targetUrl == null) {
targetUrl = httpRequest.getContextPath() + defaultTargetUrl; targetUrl = httpRequest.getContextPath() + defaultTargetUrl;