From 22f8cd0c44749601adeca82ececfc02765296d0f Mon Sep 17 00:00:00 2001
From: Ben Alex <ben.alex@springsource.com>
Date: Wed, 1 Dec 2004 02:55:01 +0000
Subject: [PATCH] Improve null handling.

---
 .../providers/dao/DaoAuthenticationProvider.java       | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/core/src/main/java/org/acegisecurity/providers/dao/DaoAuthenticationProvider.java b/core/src/main/java/org/acegisecurity/providers/dao/DaoAuthenticationProvider.java
index 929b1cf7ce..cd2c0b85b5 100644
--- a/core/src/main/java/org/acegisecurity/providers/dao/DaoAuthenticationProvider.java
+++ b/core/src/main/java/org/acegisecurity/providers/dao/DaoAuthenticationProvider.java
@@ -203,7 +203,11 @@ public class DaoAuthenticationProvider implements AuthenticationProvider,
     public Authentication authenticate(Authentication authentication)
         throws AuthenticationException {
         // Determine username
-        String username = authentication.getPrincipal().toString();
+        String username = "NONE_PROVIDED";
+
+        if (authentication.getPrincipal() != null) {
+            username = authentication.getPrincipal().toString();
+        }
 
         if (authentication.getPrincipal() instanceof UserDetails) {
             username = ((UserDetails) authentication.getPrincipal())
@@ -220,10 +224,6 @@ public class DaoAuthenticationProvider implements AuthenticationProvider,
                 user = getUserFromBackend(username);
             } catch (BadCredentialsException ex) {
                 if (this.context != null) {
-                    if ((username == null) || "".equals(username)) {
-                        username = "NONE_PROVIDED";
-                    }
-
                     context.publishEvent(new AuthenticationFailureUsernameNotFoundEvent(
                             authentication,
                             new User(username, "*****", false,