Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-23 04:22:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add debug messages for auth exceptions in ProviderManager

Browse Source 
Issue gh-16484

Signed-off-by: tejas-teju <tejas8196@gmail.com>
This commit is contained in:
tejas-teju 2025-02-12 05:32:20 +05:30 committed by Josh Cummings
parent c4b223266c
commit 291162a195
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
core/src/main/java/org/springframework/security/authentication/ProviderManager.java
View File

@ -185,13 +185,25 @@ public class ProviderManager implements AuthenticationManager, MessageSourceAwar
break; break;
} }
} }
catch (AccountStatusException | InternalAuthenticationServiceException ex) { catch (AccountStatusException ex) {
prepareException(ex, authentication); prepareException(ex, authentication);
logger.debug(LogMessage.format("Authentication failed for user '%s' since account status is %s",
authentication.getName(), ex.getMessage()));
// SEC-546: Avoid polling additional providers if auth failure is due to
// invalid account status
throw ex;
}
catch (InternalAuthenticationServiceException ex) {
prepareException(ex, authentication);
logger.debug(LogMessage.format(
"Authentication failed due to an internal authentication service error: %s", ex.getMessage()));
// SEC-546: Avoid polling additional providers if auth failure is due to // SEC-546: Avoid polling additional providers if auth failure is due to
// invalid account status // invalid account status
throw ex; throw ex;
} }
catch (AuthenticationException ex) { catch (AuthenticationException ex) {
logger.debug(LogMessage.format("Authentication failed with provider %s since %s",
provider.getClass().getSimpleName(), ex.getMessage()));
lastException = ex; lastException = ex;
} }
} }
@ -241,6 +253,13 @@ public class ProviderManager implements AuthenticationManager, MessageSourceAwar
if (parentException == null) { if (parentException == null) {
prepareException(lastException, authentication); prepareException(lastException, authentication);
} }
// Ensure this message is not logged when authentication is attempted by
// the parent provider
if (this.parent != null) {
logger.debug("Denying authentication since all attempted providers failed");
}
throw lastException; throw lastException;
} }