Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SEC-561: Removed setting of respose buffer size prior to redirect.

This commit is contained in:
Luke Taylor 2007-09-19 15:17:29 +00:00
parent 809c962d3b
commit 2ef2bfc514
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
core/src/main/java/org/acegisecurity/ui/AbstractProcessingFilter.java
View File

@ -193,15 +193,6 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
*/ */
private boolean continueChainBeforeSuccessfulAuthentication = false; private boolean continueChainBeforeSuccessfulAuthentication = false;
/**
* Specifies the buffer size to use in the event of a directory. A buffer
* size is used to ensure the response is not written back to the client
* immediately. This provides a way for the <code>HttpSession</code> to be
* updated before the browser redirect will be sent. Defaults to an 8 Kb
* buffer.
*/
private int bufferSize = 8 * 1024;
/** /**
* If true, causes any redirection URLs to be calculated minus the protocol * If true, causes any redirection URLs to be calculated minus the protocol
* and context path (defaults to false). * and context path (defaults to false).
@ -357,8 +348,7 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
} }
public static String obtainFullRequestUrl(HttpServletRequest request) { public static String obtainFullRequestUrl(HttpServletRequest request) {
SavedRequest savedRequest = (SavedRequest) request.getSession().getAttribute( SavedRequest savedRequest = (SavedRequest) request.getSession().getAttribute(ACEGI_SAVED_REQUEST_KEY);
AbstractProcessingFilter.ACEGI_SAVED_REQUEST_KEY);
return (savedRequest == null) ? null : savedRequest.getFullRequestUrl(); return (savedRequest == null) ? null : savedRequest.getFullRequestUrl();
} }
@ -438,9 +428,6 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
finalUrl = url; finalUrl = url;
} }
Assert.isTrue(!response.isCommitted(),
"Response already committed; the authentication mechanism must be able to modify buffer size");
response.setBufferSize(bufferSize);
response.sendRedirect(response.encodeRedirectURL(finalUrl)); response.sendRedirect(response.encodeRedirectURL(finalUrl));
} }
@ -630,10 +617,6 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
return authenticationDetailsSource; return authenticationDetailsSource;
} }
public void setBufferSize(int bufferSize) {
this.bufferSize = bufferSize;
}
public void setUseRelativeContext(boolean useRelativeContext) { public void setUseRelativeContext(boolean useRelativeContext) {
this.useRelativeContext = useRelativeContext; this.useRelativeContext = useRelativeContext;
} }