Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-23 20:42:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve AuthorizationManager configuration error messages

Browse Source 
Closes gh-16193
This commit is contained in:
Dmitry Spikhalsky 2024-11-30 16:29:31 -05:00 committed by Josh Cummings
parent 39cd8d9faf
commit 32e1d4c990
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java
View File

@ -76,12 +76,12 @@ class AuthorizationFilterParser implements BeanDefinitionParser {
public BeanDefinition parse(Element element, ParserContext parserContext) { public BeanDefinition parse(Element element, ParserContext parserContext) {
if (!isUseExpressions(element)) { if (!isUseExpressions(element)) {
parserContext.getReaderContext() parserContext.getReaderContext()
.error("AuthorizationManager must be used with `use-expressions=\"true\"", element); .error("AuthorizationManager must be used with `use-expressions=\"true\"; Add `use-authorization-manager=\"false\"` or enable use of expressions in `<http>` block", element);
return null; return null;
} }
if (StringUtils.hasText(element.getAttribute(ATT_ACCESS_DECISION_MANAGER_REF))) { if (StringUtils.hasText(element.getAttribute(ATT_ACCESS_DECISION_MANAGER_REF))) {
parserContext.getReaderContext() parserContext.getReaderContext()
.error("AuthorizationManager cannot be used in conjunction with `access-decision-manager-ref`", .error("AuthorizationManager cannot be used in conjunction with `access-decision-manager-ref`; either remove the reference to AccessDecisionManager or add `use-authorization-manager=\"false\"` to `<http>` block",
element); element);
return null; return null;
} }