From 33ecb443ea195775b830e8fd8d96c31f4771c86e Mon Sep 17 00:00:00 2001 From: 2-say Date: Fri, 17 Jan 2025 04:25:24 +0900 Subject: [PATCH] Suggest replacing size() == 0 with isEmpty() for collection check Consider using isEmpty() instead of size() == 0 to improve code readability and follow modern Java practices. Signed-off-by: 2-say --- .../org/springframework/security/core/ComparableVersion.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/springframework/security/core/ComparableVersion.java b/core/src/main/java/org/springframework/security/core/ComparableVersion.java index 347644734c..f635e4933c 100644 --- a/core/src/main/java/org/springframework/security/core/ComparableVersion.java +++ b/core/src/main/java/org/springframework/security/core/ComparableVersion.java @@ -414,7 +414,7 @@ class ComparableVersion implements Comparable { @Override public boolean isNull() { - return (size() == 0); + return isEmpty(); } void normalize() { @@ -434,7 +434,7 @@ class ComparableVersion implements Comparable { @Override public int compareTo(Item item) { if (item == null) { - if (size() == 0) { + if (isEmpty()) { return 0; // 1-0 = 1- (normalize) = 1 } Item first = get(0);