From 379b7ab33701209a697bff8e6a4a44beceee0ab0 Mon Sep 17 00:00:00 2001 From: Luke Taylor Date: Tue, 29 Jan 2008 16:04:49 +0000 Subject: [PATCH] SEC-543: Moved logging out of synchronized block --- .../security/concurrent/SessionRegistryImpl.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/org/springframework/security/concurrent/SessionRegistryImpl.java b/core/src/main/java/org/springframework/security/concurrent/SessionRegistryImpl.java index b6dfe65592..419ee1b6bb 100644 --- a/core/src/main/java/org/springframework/security/concurrent/SessionRegistryImpl.java +++ b/core/src/main/java/org/springframework/security/concurrent/SessionRegistryImpl.java @@ -161,11 +161,11 @@ public class SessionRegistryImpl implements SessionRegistry, ApplicationListener return; } + if (logger.isDebugEnabled()) { + logger.debug("Removing session " + sessionId + " from principal's set of registered sessions"); + } + synchronized (sessionsUsedByPrincipal) { - if (logger.isDebugEnabled()) { - logger.debug("Removing session " + sessionId + " from principal's set of registered sessions"); - } - sessionsUsedByPrincipal.remove(sessionId); if (sessionsUsedByPrincipal.size() == 0) {