From 3f38035057158ca5cdf46a4bd5d3a8be1d35f6f0 Mon Sep 17 00:00:00 2001
From: Luke Taylor <luke.taylor@springsource.com>
Date: Sun, 14 Dec 2008 22:53:31 +0000
Subject: [PATCH] SEC-1058: Renamed "forwardToDestination" to "useForward" for
 simplicity and consistency with the namespace.

---
 .../ui/SimpleUrlAuthenticationFailureHandler.java         | 8 ++------
 .../security/ui/AbstractProcessingFilterTests.java        | 2 +-
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/core/src/main/java/org/springframework/security/ui/SimpleUrlAuthenticationFailureHandler.java b/core/src/main/java/org/springframework/security/ui/SimpleUrlAuthenticationFailureHandler.java
index b6a50889ea..c847129987 100644
--- a/core/src/main/java/org/springframework/security/ui/SimpleUrlAuthenticationFailureHandler.java
+++ b/core/src/main/java/org/springframework/security/ui/SimpleUrlAuthenticationFailureHandler.java
@@ -27,10 +27,6 @@ import org.springframework.util.Assert;
 public class SimpleUrlAuthenticationFailureHandler implements AuthenticationFailureHandler {
     private String defaultFailureUrl;
     private boolean forwardToDestination = false;
-    /**
-     * If true, causes any redirection URLs to be calculated minus the protocol
-     * and context path (defaults to false).
-     */
     private boolean useRelativeContext = false;
 
     public void onAuthenticationFailure(HttpServletRequest request, HttpServletResponse response,
@@ -56,7 +52,7 @@ public class SimpleUrlAuthenticationFailureHandler implements AuthenticationFail
         this.defaultFailureUrl = defaultFailureUrl;
     }
 
-    protected boolean isForwardToDestination() {
+    protected boolean isUseForward() {
         return forwardToDestination;
     }
 
@@ -64,7 +60,7 @@ public class SimpleUrlAuthenticationFailureHandler implements AuthenticationFail
      * If set to <tt>true</tt>, performs a forward to the failure destination URL instead of a redirect. Defaults to
      * <tt>false</tt>.
      */
-    public void setForwardToDestination(boolean forwardToDestination) {
+    public void setUseForward(boolean forwardToDestination) {
         this.forwardToDestination = forwardToDestination;
     }
 
diff --git a/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java b/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java
index d03e89b76b..ca5dccd808 100644
--- a/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java
+++ b/core/src/test/java/org/springframework/security/ui/AbstractProcessingFilterTests.java
@@ -511,7 +511,7 @@ public class AbstractProcessingFilterTests extends TestCase {
         successHandler.setDefaultTargetUrl("http://monkeymachine.co.uk/");
         filter.setSuccessHandler(successHandler);
         filter.setFailureHandler(failureHandler);
-        failureHandler.setForwardToDestination(true);
+        failureHandler.setUseForward(true);
         failureHandler.setDefaultFailureUrl("/error");
 
         executeFilterInContainerSimulator(config, filter, request, response, chain);