From 4b98d357fff40b874b6e2d2a83e6f045b9ee755b Mon Sep 17 00:00:00 2001
From: Ray Krueger <raykrueger@users.sourceforge.net>
Date: Fri, 22 Jul 2005 04:35:31 +0000
Subject: [PATCH] SecureContextLoginModuleTest has been renamed to ...Tests as
 per Acegi project.

SecureContextLoginModule now throws a LoginException if there is no authentication present, if the ignoreMissingAuthentication option is true, the login() method will simply return false.
---
 .../jaas/SecureContextLoginModule.java        | 25 ++++++++++++++++---
 ...ava => SecureContextLoginModuleTests.java} | 20 ++++++++++++++-
 2 files changed, 41 insertions(+), 4 deletions(-)
 rename core/src/test/java/org/acegisecurity/providers/jaas/{SecureContextLoginModuleTest.java => SecureContextLoginModuleTests.java} (84%)

diff --git a/core/src/main/java/org/acegisecurity/providers/jaas/SecureContextLoginModule.java b/core/src/main/java/org/acegisecurity/providers/jaas/SecureContextLoginModule.java
index 92d016de76..73374669d6 100644
--- a/core/src/main/java/org/acegisecurity/providers/jaas/SecureContextLoginModule.java
+++ b/core/src/main/java/org/acegisecurity/providers/jaas/SecureContextLoginModule.java
@@ -38,7 +38,13 @@ import javax.security.auth.spi.LoginModule;
  * The {@link JaasAuthenticationProvider} allows Acegi to authenticate against
  * Jaas. <br>
  * The SecureContextLoginModule allows a Jaas based application to
- * authenticate against Acegi.
+ * authenticate against Acegi.  If there is no Authentication in the {@link
+ * SecurityContextHolder} the login() method will throw a LoginException by
+ * default. This functionality can be changed with the
+ * <tt>ignoreMissingAuthentication</tt> option by setting it to "true".
+ * Setting  ignoreMissingAuthentication=true will tell the
+ * SecureContextLoginModule to simply return false and be ignored if the
+ * authentication is null.
  *
  * @author Brian Moseley
  * @author Ray Krueger
@@ -52,6 +58,7 @@ public class SecureContextLoginModule implements LoginModule {
 
     private Authentication authen;
     private Subject subject;
+    private boolean ignoreMissingAuthentication = false;
 
     //~ Methods ================================================================
 
@@ -109,6 +116,11 @@ public class SecureContextLoginModule implements LoginModule {
     public void initialize(Subject subject, CallbackHandler callbackHandler,
         Map sharedState, Map options) {
         this.subject = subject;
+
+        if (options != null) {
+            ignoreMissingAuthentication = "true".equals(options.get(
+                        "ignoreMissingAuthentication"));
+        }
     }
 
     /**
@@ -125,8 +137,15 @@ public class SecureContextLoginModule implements LoginModule {
         authen = SecurityContextHolder.getContext().getAuthentication();
 
         if (authen == null) {
-            throw new LoginException("Authentication not found in security"
-                + " context");
+            String msg = "Login cannot complete, authentication not found in security context";
+
+            if (ignoreMissingAuthentication) {
+                log.warn(msg);
+
+                return false;
+            } else {
+                throw new LoginException(msg);
+            }
         }
 
         return true;
diff --git a/core/src/test/java/org/acegisecurity/providers/jaas/SecureContextLoginModuleTest.java b/core/src/test/java/org/acegisecurity/providers/jaas/SecureContextLoginModuleTests.java
similarity index 84%
rename from core/src/test/java/org/acegisecurity/providers/jaas/SecureContextLoginModuleTest.java
rename to core/src/test/java/org/acegisecurity/providers/jaas/SecureContextLoginModuleTests.java
index dc77126487..ac491092c8 100644
--- a/core/src/test/java/org/acegisecurity/providers/jaas/SecureContextLoginModuleTest.java
+++ b/core/src/test/java/org/acegisecurity/providers/jaas/SecureContextLoginModuleTests.java
@@ -22,6 +22,8 @@ import net.sf.acegisecurity.context.SecurityContextImpl;
 import net.sf.acegisecurity.providers.UsernamePasswordAuthenticationToken;
 
 import java.util.HashSet;
+import java.util.Map;
+import java.util.HashMap;
 
 import javax.security.auth.Subject;
 import javax.security.auth.login.LoginException;
@@ -32,7 +34,7 @@ import javax.security.auth.login.LoginException;
  *
  * @author Ray Krueger
  */
-public class SecureContextLoginModuleTest extends TestCase {
+public class SecureContextLoginModuleTests extends TestCase {
     //~ Instance fields ========================================================
 
     private SecureContextLoginModule module = null;
@@ -82,6 +84,22 @@ public class SecureContextLoginModuleTest extends TestCase {
 
     public void testNullAuthenticationInSecureContext()
         throws Exception {
+        try {
+            SecurityContextHolder.getContext().setAuthentication(null);
+            module.login();
+            fail("LoginException expected, the authentication is null in the SecureContext");
+        } catch (Exception e) {
+        }
+    }
+
+    public void testNullAuthenticationInSecureContextIgnored()
+        throws Exception {
+        module = new SecureContextLoginModule();
+
+        Map options = new HashMap();
+        options.put("ignoreMissingAuthentication", "true");
+
+        module.initialize(subject, null, null, options);
         SecurityContextHolder.getContext().setAuthentication(null);
         assertFalse("Should return false and ask to be ignored", module.login());
     }