From 53300be8d7355f8a2e88134952965a3de707b2ae Mon Sep 17 00:00:00 2001 From: Robert Winch <362503+rwinch@users.noreply.github.com> Date: Mon, 23 Feb 2026 15:15:29 -0600 Subject: [PATCH] Fix checkstyle Issue gh-18530 --- .../http/AuthorizationFilterParser.java | 3 +-- ...nvocationSecurityMetadataSourceParser.java | 3 +-- .../config/http/InterceptUrlConfigTests.java | 19 +++++++++---------- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java b/config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java index 2edf6e8f7f..de676a0791 100644 --- a/config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java +++ b/config/src/main/java/org/springframework/security/config/http/AuthorizationFilterParser.java @@ -125,8 +125,7 @@ class AuthorizationFilterParser implements BeanDefinitionParser { for (Element interceptMessage : interceptMessages) { String accessExpression = interceptMessage.getAttribute(ATT_ACCESS); if (!StringUtils.hasText(accessExpression)) { - parserContext.getReaderContext() - .error("access attribute cannot be empty or null", interceptMessage); + parserContext.getReaderContext().error("access attribute cannot be empty or null", interceptMessage); continue; } BeanDefinitionBuilder authorizationManager = BeanDefinitionBuilder diff --git a/config/src/main/java/org/springframework/security/config/http/FilterInvocationSecurityMetadataSourceParser.java b/config/src/main/java/org/springframework/security/config/http/FilterInvocationSecurityMetadataSourceParser.java index 442343d5ce..4716b7f535 100644 --- a/config/src/main/java/org/springframework/security/config/http/FilterInvocationSecurityMetadataSourceParser.java +++ b/config/src/main/java/org/springframework/security/config/http/FilterInvocationSecurityMetadataSourceParser.java @@ -144,8 +144,7 @@ public class FilterInvocationSecurityMetadataSourceParser implements BeanDefinit String access = urlElt.getAttribute(ATT_ACCESS); String path = urlElt.getAttribute(ATT_PATTERN); if (!StringUtils.hasText(access)) { - parserContext.getReaderContext() - .error("access attribute cannot be empty or null", urlElt); + parserContext.getReaderContext().error("access attribute cannot be empty or null", urlElt); continue; } String matcherRef = urlElt.getAttribute(HttpSecurityBeanDefinitionParser.ATT_REQUEST_MATCHER_REF); diff --git a/config/src/test/java/org/springframework/security/config/http/InterceptUrlConfigTests.java b/config/src/test/java/org/springframework/security/config/http/InterceptUrlConfigTests.java index 22c30bc185..38ac6cf434 100644 --- a/config/src/test/java/org/springframework/security/config/http/InterceptUrlConfigTests.java +++ b/config/src/test/java/org/springframework/security/config/http/InterceptUrlConfigTests.java @@ -343,8 +343,8 @@ public class InterceptUrlConfigTests { @Test public void configWhenInterceptUrlMissingAccessThenException() { assertThatExceptionOfType(BeanDefinitionParsingException.class) - .isThrownBy(() -> this.spring.configLocations(this.xml("MissingAccess")).autowire()) - .withMessageContaining("access attribute cannot be empty or null"); + .isThrownBy(() -> this.spring.configLocations(this.xml("MissingAccess")).autowire()) + .withMessageContaining("access attribute cannot be empty or null"); } /** @@ -353,8 +353,8 @@ public class InterceptUrlConfigTests { @Test public void configWhenInterceptUrlEmptyAccessThenException() { assertThatExceptionOfType(BeanDefinitionParsingException.class) - .isThrownBy(() -> this.spring.configLocations(this.xml("EmptyAccess")).autowire()) - .withMessageContaining("access attribute cannot be empty or null"); + .isThrownBy(() -> this.spring.configLocations(this.xml("EmptyAccess")).autowire()) + .withMessageContaining("access attribute cannot be empty or null"); } /** @@ -362,8 +362,7 @@ public class InterceptUrlConfigTests { */ @Test public void configWhenInterceptUrlValidAccessThenLoads() { - assertThatNoException() - .isThrownBy(() -> this.spring.configLocations(this.xml("ValidAccess")).autowire()); + assertThatNoException().isThrownBy(() -> this.spring.configLocations(this.xml("ValidAccess")).autowire()); } /** @@ -372,8 +371,8 @@ public class InterceptUrlConfigTests { @Test public void configWhenUseAuthorizationManagerFalseAndMissingAccessThenException() { assertThatExceptionOfType(BeanDefinitionParsingException.class) - .isThrownBy(() -> this.spring.configLocations(this.xml("MissingAccessLegacy")).autowire()) - .withMessageContaining("access attribute cannot be empty or null"); + .isThrownBy(() -> this.spring.configLocations(this.xml("MissingAccessLegacy")).autowire()) + .withMessageContaining("access attribute cannot be empty or null"); } /** @@ -382,8 +381,8 @@ public class InterceptUrlConfigTests { @Test public void configWhenUseAuthorizationManagerFalseAndEmptyAccessThenException() { assertThatExceptionOfType(BeanDefinitionParsingException.class) - .isThrownBy(() -> this.spring.configLocations(this.xml("EmptyAccessLegacy")).autowire()) - .withMessageContaining("access attribute cannot be empty or null"); + .isThrownBy(() -> this.spring.configLocations(this.xml("EmptyAccessLegacy")).autowire()) + .withMessageContaining("access attribute cannot be empty or null"); } private static RequestPostProcessor adminCredentials() {