Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Test OpenID Discovery with Trailing Slash 

Fixes gh-6234
This commit is contained in:
Josh Cummings 2018-12-05 10:54:30 -07:00
parent f755580a91
commit 566bc6a6e1
No known key found for this signature in database
GPG Key ID: 49EF60DD7FF83443
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTest.java
View File

@ -137,6 +137,12 @@ public class ClientRegistrationsTest {
assertThat(provider.getUserInfoEndpoint().getUri()).isEqualTo("https://example.com/oauth2/v3/userinfo"); assertThat(provider.getUserInfoEndpoint().getUri()).isEqualTo("https://example.com/oauth2/v3/userinfo");
} }
@Test
public void issuerWhenContainsTrailingSlashThenSuccess() throws Exception {
assertThat(registration("")).isNotNull();
assertThat(this.issuer.endsWith("/")).isTrue();
}
/** /**
* https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata * https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata
* *

9
oauth2/oauth2-jose/src/test/java/org/springframework/security/oauth2/jwt/JwtDecodersTests.java
View File

@ -24,6 +24,7 @@ import org.junit.Test;
import org.springframework.http.HttpHeaders; import org.springframework.http.HttpHeaders;
import org.springframework.http.MediaType; import org.springframework.http.MediaType;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatCode; import static org.assertj.core.api.Assertions.assertThatCode;
/** /**
@ -91,6 +92,14 @@ public class JwtDecodersTests {
.hasMessageContaining("This iss claim is not equal to the configured issuer"); .hasMessageContaining("This iss claim is not equal to the configured issuer");
} }
@Test
public void issuerWhenContainsTrailingSlashThenSuccess() {
prepareOpenIdConfigurationResponse();
this.server.enqueue(new MockResponse().setBody(JWK_SET));
assertThat(JwtDecoders.fromOidcIssuerLocation(this.issuer)).isNotNull();
assertThat(this.issuer.endsWith("/")).isTrue();
}
@Test @Test
public void issuerWhenResponseIsNonCompliantThenThrowsRuntimeException() { public void issuerWhenResponseIsNonCompliantThenThrowsRuntimeException() {
prepareOpenIdConfigurationResponse("{ \"missing_required_keys\" : \"and_values\" }"); prepareOpenIdConfigurationResponse("{ \"missing_required_keys\" : \"and_values\" }");