diff --git a/core/pom.xml b/core/pom.xml index a07264d4dd..7133a8ffd6 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -14,15 +14,11 @@ org.springframework org.springframework.expression - - org.antlr - antlr - - + asm asm-all - + org.springframework org.springframework.core @@ -31,6 +27,10 @@ org.springframework org.springframework.context + + org.springframework + org.springframework.transaction + org.springframework org.springframework.aop diff --git a/core/src/main/java/org/springframework/security/expression/method/AbstractExpressionBasedMethodConfigAttribute.java b/core/src/main/java/org/springframework/security/expression/method/AbstractExpressionBasedMethodConfigAttribute.java index e960fc2755..7f47cd4b6c 100644 --- a/core/src/main/java/org/springframework/security/expression/method/AbstractExpressionBasedMethodConfigAttribute.java +++ b/core/src/main/java/org/springframework/security/expression/method/AbstractExpressionBasedMethodConfigAttribute.java @@ -2,7 +2,7 @@ package org.springframework.security.expression.method; import org.springframework.expression.Expression; import org.springframework.expression.ParseException; -import org.springframework.expression.spel.SpelExpressionParser; +import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser; import org.springframework.security.ConfigAttribute; import org.springframework.util.Assert; @@ -26,7 +26,7 @@ abstract class AbstractExpressionBasedMethodConfigAttribute implements ConfigAtt */ AbstractExpressionBasedMethodConfigAttribute(String filterExpression, String authorizeExpression) throws ParseException { Assert.isTrue(filterExpression != null || authorizeExpression != null, "Filter and authorization Expressions cannot both be null"); - SpelExpressionParser parser = new SpelExpressionParser(); + SpelAntlrExpressionParser parser = new SpelAntlrExpressionParser(); this.filterExpression = filterExpression == null ? null : parser.parseExpression(filterExpression); this.authorizeExpression = authorizeExpression == null ? null : parser.parseExpression(authorizeExpression); } diff --git a/core/src/main/java/org/springframework/security/expression/method/ExpressionAnnotationMethodDefinitionSource.java b/core/src/main/java/org/springframework/security/expression/method/ExpressionAnnotationMethodDefinitionSource.java index 7bc5b1bf7a..ef0bee8d10 100644 --- a/core/src/main/java/org/springframework/security/expression/method/ExpressionAnnotationMethodDefinitionSource.java +++ b/core/src/main/java/org/springframework/security/expression/method/ExpressionAnnotationMethodDefinitionSource.java @@ -10,7 +10,7 @@ import org.springframework.core.annotation.AnnotationUtils; import org.springframework.expression.Expression; import org.springframework.expression.ExpressionParser; import org.springframework.expression.ParseException; -import org.springframework.expression.spel.SpelExpressionParser; +import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser; import org.springframework.security.ConfigAttribute; import org.springframework.security.config.SecurityConfigurationException; import org.springframework.security.expression.SecurityExpressionHandler; @@ -42,7 +42,7 @@ public class ExpressionAnnotationMethodDefinitionSource extends AbstractMethodDe private ExpressionParser parser; public ExpressionAnnotationMethodDefinitionSource() { - parser = new SpelExpressionParser(); + parser = new SpelAntlrExpressionParser(); } /** diff --git a/core/src/main/java/org/springframework/security/expression/support/DefaultSecurityExpressionHandler.java b/core/src/main/java/org/springframework/security/expression/support/DefaultSecurityExpressionHandler.java index fa71fcdf09..76ef6ca82a 100644 --- a/core/src/main/java/org/springframework/security/expression/support/DefaultSecurityExpressionHandler.java +++ b/core/src/main/java/org/springframework/security/expression/support/DefaultSecurityExpressionHandler.java @@ -13,8 +13,8 @@ import org.springframework.core.ParameterNameDiscoverer; import org.springframework.expression.EvaluationContext; import org.springframework.expression.Expression; import org.springframework.expression.ExpressionParser; -import org.springframework.expression.spel.SpelExpressionParser; -import org.springframework.expression.spel.standard.StandardEvaluationContext; +import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser; +import org.springframework.expression.spel.support.StandardEvaluationContext; import org.springframework.security.Authentication; import org.springframework.security.AuthenticationTrustResolver; import org.springframework.security.AuthenticationTrustResolverImpl; @@ -39,7 +39,7 @@ public class DefaultSecurityExpressionHandler implements SecurityExpressionHandl private ParameterNameDiscoverer parameterNameDiscoverer = new LocalVariableTableParameterNameDiscoverer(); private PermissionEvaluator permissionEvaluator = new DenyAllPermissionEvaluator(); private AuthenticationTrustResolver trustResolver = new AuthenticationTrustResolverImpl(); - private ExpressionParser expressionParser = new SpelExpressionParser(); + private ExpressionParser expressionParser = new SpelAntlrExpressionParser(); public DefaultSecurityExpressionHandler() { } @@ -69,7 +69,7 @@ public class DefaultSecurityExpressionHandler implements SecurityExpressionHandl @SuppressWarnings("unchecked") public Object filter(Object filterTarget, Expression filterExpression, EvaluationContext ctx) { - MethodSecurityExpressionRoot rootObject = (MethodSecurityExpressionRoot) ctx.getRootContextObject(); + MethodSecurityExpressionRoot rootObject = (MethodSecurityExpressionRoot) ctx.getRootObject(); List retainList; if (logger.isDebugEnabled()) { @@ -150,7 +150,7 @@ public class DefaultSecurityExpressionHandler implements SecurityExpressionHandl } public void setReturnObject(Object returnObject, EvaluationContext ctx) { - ((MethodSecurityExpressionRoot)ctx.getRootContextObject()).setReturnObject(returnObject); + ((MethodSecurityExpressionRoot)ctx.getRootObject()).setReturnObject(returnObject); } } diff --git a/core/src/main/java/org/springframework/security/expression/support/MethodSecurityEvaluationContext.java b/core/src/main/java/org/springframework/security/expression/support/MethodSecurityEvaluationContext.java index 3d2e7e4686..0aef42ebac 100644 --- a/core/src/main/java/org/springframework/security/expression/support/MethodSecurityEvaluationContext.java +++ b/core/src/main/java/org/springframework/security/expression/support/MethodSecurityEvaluationContext.java @@ -5,7 +5,7 @@ import java.lang.reflect.Method; import org.aopalliance.intercept.MethodInvocation; import org.springframework.core.LocalVariableTableParameterNameDiscoverer; import org.springframework.core.ParameterNameDiscoverer; -import org.springframework.expression.spel.standard.StandardEvaluationContext; +import org.springframework.expression.spel.support.StandardEvaluationContext; import org.springframework.security.Authentication; import org.springframework.util.ClassUtils; diff --git a/core/src/test/java/org/springframework/security/expression/support/MethodSecurityExpressionRootTests.java b/core/src/test/java/org/springframework/security/expression/support/MethodSecurityExpressionRootTests.java index c6ac30ef45..48cf99243a 100644 --- a/core/src/test/java/org/springframework/security/expression/support/MethodSecurityExpressionRootTests.java +++ b/core/src/test/java/org/springframework/security/expression/support/MethodSecurityExpressionRootTests.java @@ -7,8 +7,8 @@ import org.jmock.Mockery; import org.junit.Before; import org.junit.Test; import org.springframework.expression.Expression; -import org.springframework.expression.spel.SpelExpressionParser; -import org.springframework.expression.spel.standard.StandardEvaluationContext; +import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser; +import org.springframework.expression.spel.support.StandardEvaluationContext; import org.springframework.security.Authentication; import org.springframework.security.AuthenticationTrustResolver; import org.springframework.security.expression.ExpressionUtils; @@ -21,7 +21,7 @@ import org.springframework.security.expression.PermissionEvaluator; * @version $Id$ */ public class MethodSecurityExpressionRootTests { - SpelExpressionParser parser = new SpelExpressionParser(); + SpelAntlrExpressionParser parser = new SpelAntlrExpressionParser(); MethodSecurityExpressionRoot root; StandardEvaluationContext ctx; Mockery jmock = new Mockery(); diff --git a/itest/web/pom.xml b/itest/web/pom.xml index 5653486c5f..c7b9c54a15 100644 --- a/itest/web/pom.xml +++ b/itest/web/pom.xml @@ -35,7 +35,7 @@ jetty-naming ${jetty.version} test - + org.mortbay.jetty jetty-plus @@ -44,14 +44,16 @@ org.mortbay.jetty - jsp-2.1 + jsp-2.1-jetty ${jetty.version} test + diff --git a/pom.xml b/pom.xml index 1c0d4e377a..6104dffb07 100644 --- a/pom.xml +++ b/pom.xml @@ -9,7 +9,7 @@ core - portlet + ntlm openid samples @@ -633,10 +633,12 @@ org.apache.commons com.springsource.org.apache.commons.logging + true @@ -731,7 +733,7 @@ org.springframework.ldap spring-ldap-core - 1.3.0.RC1 + 1.3.0.RELEASE org.springframework @@ -757,16 +759,19 @@ com.springsource.org.aspectj.weaver 1.6.2.RELEASE + + + org.antlr antlr 3.0.1 true runtime +--> - + asm asm-all 2.2.3 @@ -841,9 +846,9 @@ - 3.0.0.M1 + 3.0.0.M2 1.1.2 - 6.1.14 + 6.1.15 ${basedir}/src/docbkx ${basedir}/target/site/guide diff --git a/samples/ldap/pom.xml b/samples/ldap/pom.xml index 61bd0491ce..c43e98a8a0 100644 --- a/samples/ldap/pom.xml +++ b/samples/ldap/pom.xml @@ -55,6 +55,7 @@ org.springframework.ldap spring-ldap-core + runtime