Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-07-13 22:03:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replaced casting to check validity of provider list with call to Assert.isInstanceof.

Browse Source
This commit is contained in:
Luke Taylor 2008-03-17 13:50:37 +00:00
parent d008ecde56
commit 60de6314d4
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/main/java/org/springframework/security/acl/AclProviderManager.java
View File

@ -125,16 +125,8 @@ public class AclProviderManager implements AclManager, InitializingBean {
Iterator iter = newList.iterator();
while (iter.hasNext()) {
Object currentObject = null;
try {
currentObject = iter.next();
AclProvider attemptToCast = (AclProvider) currentObject;
} catch (ClassCastException cce) {
throw new IllegalArgumentException("AclProvider " + currentObject.getClass().getName()
+ " must implement AclProvider");
}
Object currentObject = iter.next();
Assert.isInstanceOf(AclProvider.class, currentObject, "Invalid Acl Provider. ");
}
this.providers = newList;

4
core/src/test/java/org/springframework/security/acl/AclProviderManagerTests.java
View File

@ -49,10 +49,6 @@ public class AclProviderManagerTests extends TestCase {
//~ Methods ========================================================================================================
public static void main(String[] args) {
junit.textui.TestRunner.run(AclProviderManagerTests.class);
}
private AclProviderManager makeProviderManager() {
MockProvider provider1 = new MockProvider();
List providers = new Vector();