From 6695784a3fe7ed9edc137fc0e095f344dbb45592 Mon Sep 17 00:00:00 2001 From: Josh Cummings Date: Fri, 31 May 2024 12:48:07 -0600 Subject: [PATCH] Polish Logging Issue gh-14801 --- .../service/metadata/OpenSamlMetadataResolver.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/metadata/OpenSamlMetadataResolver.java b/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/metadata/OpenSamlMetadataResolver.java index 75fc9c1b4f..147c402106 100644 --- a/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/metadata/OpenSamlMetadataResolver.java +++ b/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/metadata/OpenSamlMetadataResolver.java @@ -26,6 +26,8 @@ import java.util.function.Consumer; import javax.xml.namespace.QName; import net.shibboleth.utilities.java.support.xml.SerializeSupport; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.opensaml.core.xml.XMLObjectBuilder; import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport; import org.opensaml.saml.common.xml.SAMLConstants; @@ -65,6 +67,8 @@ public final class OpenSamlMetadataResolver implements Saml2MetadataResolver { OpenSamlInitializationService.initialize(); } + private final Log logger = LogFactory.getLog(this.getClass()); + private final EntityDescriptorMarshaller entityDescriptorMarshaller; private final EntitiesDescriptorMarshaller entitiesDescriptorMarshaller; @@ -116,6 +120,9 @@ public final class OpenSamlMetadataResolver implements Saml2MetadataResolver { if (this.signMetadata) { return OpenSamlSigningUtils.sign(entityDescriptor, registration); } + else { + this.logger.trace("Did not sign metadata since `signMetadata` is `false`"); + } return entityDescriptor; }