Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-07-01 08:12:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-790: DefaultLoginPageGeneratingFilter should be a better HTTP citizen

Browse Source 
http://jira.springframework.org/browse/SEC-790. Applied submitted patch.
This commit is contained in:
Luke Taylor 2008-04-23 00:41:52 +00:00
parent 8ea7487ec3
commit 7e63fe7357
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/main/java/org/springframework/security/ui/webapp/DefaultLoginPageGeneratingFilter.java
View File

@ -23,6 +23,7 @@ import org.springframework.security.ui.rememberme.AbstractRememberMeServices;
* *
* @author Luke Taylor * @author Luke Taylor
* @version $Id$ * @version $Id$
* @since 2.0
*/ */
public class DefaultLoginPageGeneratingFilter extends SpringSecurityFilter { public class DefaultLoginPageGeneratingFilter extends SpringSecurityFilter {
public static final String DEFAULT_LOGIN_PAGE_URL = "/spring_security_login"; public static final String DEFAULT_LOGIN_PAGE_URL = "/spring_security_login";
@ -72,10 +73,13 @@ public class DefaultLoginPageGeneratingFilter extends SpringSecurityFilter {
} }
} }
protected void doFilterHttp(HttpServletRequest request, HttpServletResponse response, FilterChain chain) throws IOException, ServletException { protected void doFilterHttp(HttpServletRequest request, HttpServletResponse response, FilterChain chain) throws IOException, ServletException {
if (isLoginUrlRequest(request)) { if (isLoginUrlRequest(request)) {
response.getOutputStream().print(generateLoginPageHtml(request)); String loginPageHtml = generateLoginPageHtml(request);
response.setCharacterEncoding("UTF-8");
response.setContentType("text/html");
response.setContentLength(loginPageHtml.length());
response.getOutputStream().print(loginPageHtml);
return; return;
} }