Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-07-16 07:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for SEC-202. Intialize manager password to default "manager_password_not_set".

Browse Source
This commit is contained in:
Luke Taylor 2006-02-28 17:47:55 +00:00
parent 555903d139
commit 7e7920ce00
2 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/main/java/org/acegisecurity/providers/ldap/DefaultInitialDirContextFactory.java
View File

@ -100,7 +100,7 @@ public class DefaultInitialDirContextFactory implements InitialDirContextFactory
/** /**
* The manager user's password. * The manager user's password.
*/ */
private String managerPassword = null; private String managerPassword = "manager_password_not_set";
/** Type of authentication within LDAP; default is simple. */ /** Type of authentication within LDAP; default is simple. */
private String authenticationType = "simple"; private String authenticationType = "simple";
@ -164,6 +164,7 @@ public class DefaultInitialDirContextFactory implements InitialDirContextFactory
Hashtable env = getEnvironment(); Hashtable env = getEnvironment();
env.put(Context.SECURITY_AUTHENTICATION, AUTH_TYPE_NONE); env.put(Context.SECURITY_AUTHENTICATION, AUTH_TYPE_NONE);
return connect(env); return connect(env);
} }

24
core/src/test/java/org/acegisecurity/providers/ldap/DefaultInitialDirContextFactoryTests.java
View File

@ -78,14 +78,34 @@ public class DefaultInitialDirContextFactoryTests extends AbstractLdapServerTest
ctx.close(); ctx.close();
} }
public void testBindAsManagerFailsIfNoPasswordSet() throws Exception {
idf.setManagerDn(MANAGER_USER);
DirContext ctx = null;
try {
ctx = idf.newInitialDirContext();
fail("Binding with no manager password should fail.");
// Can't rely on this property being there with embedded server
// assertEquals("true",ctx.getEnvironment().get("com.sun.jndi.ldap.connect.pool"));
} catch(BadCredentialsException expected) {
}
LdapUtils.closeContext(ctx);
}
public void testInvalidPasswordCausesBadCredentialsException() throws Exception { public void testInvalidPasswordCausesBadCredentialsException() throws Exception {
idf.setManagerDn(MANAGER_USER); idf.setManagerDn(MANAGER_USER);
idf.setManagerPassword("wrongpassword"); idf.setManagerPassword("wrongpassword");
DirContext ctx = null;
try { try {
DirContext ctx = idf.newInitialDirContext(); ctx = idf.newInitialDirContext();
fail("Authentication with wrong credentials should fail."); fail("Binding with wrong credentials should fail.");
} catch(BadCredentialsException expected) { } catch(BadCredentialsException expected) {
} }
LdapUtils.closeContext(ctx);
} }
public void testConnectionAsSpecificUserSucceeds() throws Exception { public void testConnectionAsSpecificUserSucceeds() throws Exception {