Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2026-02-08 22:44:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate single-arg PasswordComparisonAuthenticator ctor

Browse Source 
Add new constructor accepting PasswordEncoder to eventually
remove deprecated LdapShaPasswordEncoder usage.

Closes gh-18430

Signed-off-by: LeeJiWon <dlwldnjs1009@gmail.com>
This commit is contained in:
LeeJiWon 2026-01-24 14:54:49 +09:00 committed by Rob Winch
parent 9fa0a34b4c
commit 89467605ca
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ldap/src/main/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticator.java
View File

@ -52,14 +52,27 @@ public final class PasswordComparisonAuthenticator extends AbstractLdapAuthentic
private static final Log logger = LogFactory.getLog(PasswordComparisonAuthenticator.class);
private PasswordEncoder passwordEncoder = new LdapShaPasswordEncoder(KeyGenerators.shared(0));
private PasswordEncoder passwordEncoder;
private String passwordAttributeName = "userPassword";
private boolean usePasswordAttrCompare = false;
/**
* @deprecated Use
* {@link #PasswordComparisonAuthenticator(BaseLdapPathContextSource, PasswordEncoder)}
* instead
*/
@Deprecated(since = "7.1")
@SuppressWarnings("deprecation")
public PasswordComparisonAuthenticator(BaseLdapPathContextSource contextSource) {
this(contextSource, new LdapShaPasswordEncoder(KeyGenerators.shared(0)));
}
public PasswordComparisonAuthenticator(BaseLdapPathContextSource contextSource, PasswordEncoder passwordEncoder) {
super(contextSource);
Assert.notNull(passwordEncoder, "passwordEncoder must not be null");
this.passwordEncoder = passwordEncoder;
}
@Override

1
ldap/src/test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorMockTests.java
View File

@ -35,6 +35,7 @@ import static org.mockito.Mockito.mock;
/**
* @author Luke Taylor
*/
@SuppressWarnings("deprecation")
public class PasswordComparisonAuthenticatorMockTests {
@Test