Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactoring to remove warnings in LDAP module.

This commit is contained in:
Luke Taylor 2009-04-27 11:05:58 +00:00
parent c96da98e14
commit 929b6bb1a0
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ldap/src/main/java/org/springframework/security/ldap/authentication/LdapAuthenticationProvider.java
View File

@ -50,7 +50,7 @@ import org.apache.commons.logging.LogFactory;
* against an LDAP server. * against an LDAP server.
* <p> * <p>
* There are many ways in which an LDAP directory can be configured so this class delegates most of * There are many ways in which an LDAP directory can be configured so this class delegates most of
* its responsibilites to two separate strategy interfaces, {@link LdapAuthenticator} * its responsibilities to two separate strategy interfaces, {@link LdapAuthenticator}
* and {@link LdapAuthoritiesPopulator}. * and {@link LdapAuthoritiesPopulator}.
* *
* <h3>LdapAuthenticator</h3> * <h3>LdapAuthenticator</h3>
@ -237,13 +237,17 @@ public class LdapAuthenticationProvider implements AuthenticationProvider, Messa
final UsernamePasswordAuthenticationToken userToken = (UsernamePasswordAuthenticationToken)authentication; final UsernamePasswordAuthenticationToken userToken = (UsernamePasswordAuthenticationToken)authentication;
String username = userToken.getName(); String username = userToken.getName();
String password = (String) authentication.getCredentials();
if (logger.isDebugEnabled()) {
logger.debug("Processing authentication request for user: " + username);
}
if (!StringUtils.hasLength(username)) { if (!StringUtils.hasLength(username)) {
throw new BadCredentialsException(messages.getMessage("LdapAuthenticationProvider.emptyUsername", throw new BadCredentialsException(messages.getMessage("LdapAuthenticationProvider.emptyUsername",
"Empty Username")); "Empty Username"));
} }
String password = (String) authentication.getCredentials();
Assert.notNull(password, "Null password was supplied in authentication token"); Assert.notNull(password, "Null password was supplied in authentication token");
try { try {

1
ldap/src/test/java/org/springframework/security/ldap/AbstractLdapIntegrationTests.java
View File

@ -56,6 +56,7 @@ public abstract class AbstractLdapIntegrationTests {
protected AbstractLdapIntegrationTests() { protected AbstractLdapIntegrationTests() {
} }
@SuppressWarnings("unchecked")
@BeforeClass @BeforeClass
public static void startServer() throws Exception { public static void startServer() throws Exception {
shutdownRunningServers(); shutdownRunningServers();