Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-27 06:12:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

StringSplitUtils.split() ignored delimiter argument.

Browse Source
This commit is contained in:
Ben Alex 2005-03-21 05:14:48 +00:00
parent 6f31ecb04b
commit a2b9da7e22
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/java/org/acegisecurity/util/StringSplitUtils.java
View File

@ -57,7 +57,7 @@ public class StringSplitUtils {
"Delimiter can only be one character in length"); "Delimiter can only be one character in length");
} }
int offset = toSplit.indexOf('='); int offset = toSplit.indexOf(delimiter);
if (offset < 0) { if (offset < 0) {
return null; return null;

8
core/src/test/java/org/acegisecurity/util/StringSplitUtilsTests.java
View File

@ -137,4 +137,12 @@ public class StringSplitUtilsTests extends TestCase {
assertTrue(true); assertTrue(true);
} }
} }
public void testSplitWorksWithDifferentDelimiters() {
assertEquals(2, StringSplitUtils.split("18/marissa", "/").length);
assertNull(StringSplitUtils.split("18/marissa", "!"));
// only guarantees to split at FIRST delimiter, not EACH delimiter
assertEquals(2, StringSplitUtils.split("18|marissa|foo|bar", "|").length);
}
} }

1
doc/xdocs/changes.xml
View File

@ -35,6 +35,7 @@
<action dev="fbos" type="fix">Corrected Authz parsing of whitespace in GrantedAuthoritys</action> <action dev="fbos" type="fix">Corrected Authz parsing of whitespace in GrantedAuthoritys</action>
<action dev="benalex" type="fix">TokenBasedRememberMeServices now respects expired users, expired credentials and disabled users</action> <action dev="benalex" type="fix">TokenBasedRememberMeServices now respects expired users, expired credentials and disabled users</action>
<action dev="benalex" type="fix">HttpSessionContextIntegrationFilter now handles HttpSession invalidation without redirection</action> <action dev="benalex" type="fix">HttpSessionContextIntegrationFilter now handles HttpSession invalidation without redirection</action>
<action dev="benalex" type="fix">StringSplitUtils.split() ignored delimiter argument</action>
</release> </release>
<release version="0.8.0" date="2005-03-03"> <release version="0.8.0" date="2005-03-03">
<action dev="benalex" type="add">Added Digest Authentication support (RFC 2617 and RFC 2069)</action> <action dev="benalex" type="add">Added Digest Authentication support (RFC 2617 and RFC 2069)</action>