From a58f3282d9bb8dadb13565e07a8ef96e90ecc6e2 Mon Sep 17 00:00:00 2001 From: Rob Winch <362503+rwinch@users.noreply.github.com> Date: Fri, 29 Aug 2025 15:46:08 -0500 Subject: [PATCH] Fix config/src/test/kotlin nullability for web Issue gh-17535 --- .../config/annotation/web/OneTimeTokenLoginDslTests.kt | 5 +---- .../config/web/server/ServerOAuth2ResourceServerDslTests.kt | 4 ++-- .../config/web/server/ServerOneTimeTokenLoginDslTests.kt | 4 ++-- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/config/src/test/kotlin/org/springframework/security/config/annotation/web/OneTimeTokenLoginDslTests.kt b/config/src/test/kotlin/org/springframework/security/config/annotation/web/OneTimeTokenLoginDslTests.kt index bbbb9d4e56..4cbe7c0d54 100644 --- a/config/src/test/kotlin/org/springframework/security/config/annotation/web/OneTimeTokenLoginDslTests.kt +++ b/config/src/test/kotlin/org/springframework/security/config/annotation/web/OneTimeTokenLoginDslTests.kt @@ -22,7 +22,6 @@ import io.mockk.mockk import io.mockk.verify import jakarta.servlet.http.HttpServletRequest import jakarta.servlet.http.HttpServletResponse -import org.assertj.core.api.Assertions.assertThat import org.junit.jupiter.api.Test import org.junit.jupiter.api.extension.ExtendWith import org.springframework.beans.factory.annotation.Autowired @@ -44,7 +43,6 @@ import org.springframework.security.test.web.servlet.request.SecurityMockMvcRequ import org.springframework.security.test.web.servlet.response.SecurityMockMvcResultMatchers import org.springframework.security.web.SecurityFilterChain import org.springframework.security.web.authentication.SimpleUrlAuthenticationSuccessHandler -import org.springframework.security.web.authentication.ott.DefaultGenerateOneTimeTokenRequestResolver import org.springframework.security.web.authentication.ott.GenerateOneTimeTokenRequestResolver import org.springframework.security.web.authentication.ott.OneTimeTokenGenerationSuccessHandler import org.springframework.security.web.authentication.ott.RedirectOneTimeTokenGenerationSuccessHandler @@ -53,7 +51,6 @@ import org.springframework.test.web.servlet.request.MockMvcRequestBuilders import org.springframework.test.web.servlet.result.MockMvcResultMatchers import java.time.Duration import java.time.Instant -import java.time.ZoneOffset /** * Tests for [OneTimeTokenLoginDsl] @@ -267,7 +264,7 @@ class OneTimeTokenLoginDslTests { ) } - constructor(redirectUrl: String?) { + constructor(redirectUrl: String) { this.delegate = RedirectOneTimeTokenGenerationSuccessHandler( redirectUrl diff --git a/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOAuth2ResourceServerDslTests.kt b/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOAuth2ResourceServerDslTests.kt index 43ffbbda20..3067d18012 100644 --- a/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOAuth2ResourceServerDslTests.kt +++ b/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOAuth2ResourceServerDslTests.kt @@ -175,8 +175,8 @@ class ServerOAuth2ResourceServerDslTests { open class MockServerAuthenticationFailureHandler: ServerAuthenticationFailureHandler { override fun onAuthenticationFailure( - webFilterExchange: WebFilterExchange?, - exception: AuthenticationException? + webFilterExchange: WebFilterExchange, + exception: AuthenticationException ): Mono { return Mono.empty() } diff --git a/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOneTimeTokenLoginDslTests.kt b/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOneTimeTokenLoginDslTests.kt index e8dd8af349..5e0f568e75 100644 --- a/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOneTimeTokenLoginDslTests.kt +++ b/config/src/test/kotlin/org/springframework/security/config/web/server/ServerOneTimeTokenLoginDslTests.kt @@ -280,11 +280,11 @@ class ServerOneTimeTokenLoginDslTests { this.delegate = ServerRedirectOneTimeTokenGenerationSuccessHandler("/login/ott") } - constructor(redirectUrl: String?) { + constructor(redirectUrl: String) { this.delegate = ServerRedirectOneTimeTokenGenerationSuccessHandler(redirectUrl) } - override fun handle(exchange: ServerWebExchange?, oneTimeToken: OneTimeToken?): Mono { + override fun handle(exchange: ServerWebExchange, oneTimeToken: OneTimeToken): Mono { lastToken = oneTimeToken return delegate!!.handle(exchange, oneTimeToken) }