From abd51f7b6384837714e9ccde2b10d8567351b2ff Mon Sep 17 00:00:00 2001 From: twosom Date: Sat, 18 Feb 2023 02:10:33 +0900 Subject: [PATCH] Polished DefaultLoginPageGeneratingFilterTests Validation Closes gh-12694 --- .../DefaultLoginPageGeneratingFilterTests.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java b/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java index 97fbfda406..8e26b37048 100644 --- a/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/authentication/DefaultLoginPageGeneratingFilterTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -143,12 +143,14 @@ public class DefaultLoginPageGeneratingFilterTests { DefaultLoginPageGeneratingFilter filter = new DefaultLoginPageGeneratingFilter( new UsernamePasswordAuthenticationFilter()); MockHttpServletRequest request = new MockHttpServletRequest("GET", "/login"); - request.addParameter("login_error", "true"); + MockHttpServletResponse response = new MockHttpServletResponse(); + request.setQueryString("error"); MessageSourceAccessor messages = SpringSecurityMessageSource.getAccessor(); String message = messages.getMessage("AbstractUserDetailsAuthenticationProvider.badCredentials", "Bad credentials", Locale.KOREA); request.getSession().setAttribute(WebAttributes.AUTHENTICATION_EXCEPTION, new BadCredentialsException(message)); - filter.doFilter(request, new MockHttpServletResponse(), this.chain); + filter.doFilter(request, response, this.chain); + assertThat(response.getContentAsString()).contains(message); } // gh-5394