From af00be8a3d06ba38d4da694e6da003cbf295a7b3 Mon Sep 17 00:00:00 2001 From: Baljit Singh Date: Thu, 13 Jul 2023 10:21:05 -0400 Subject: [PATCH] fix Javadocs for Jwt issuer resolvers --- .../JwtIssuerAuthenticationManagerResolver.java | 16 ++++++++-------- ...uerReactiveAuthenticationManagerResolver.java | 10 +++++----- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java index b1216e3681..81511b7ad8 100644 --- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java +++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java @@ -47,10 +47,10 @@ import org.springframework.util.Assert; * "https://openid.net/specs/openid-connect-core-1_0.html#IssuerIdentifier">Issuer in * a signed JWT (JWS). * - * To use, this class must be able to determine whether or not the `iss` claim is trusted. - * Recall that anyone can stand up an authorization server and issue valid tokens to a - * resource server. The simplest way to achieve this is to supply a list of trusted - * issuers in the constructor. + * To use, this class must be able to determine whether the `iss` claim is trusted. Recall + * that anyone can stand up an authorization server and issue valid tokens to a resource + * server. The simplest way to achieve this is to supply a list of trusted issuers in the + * constructor. * * This class derives the Issuer from the `iss` claim found in the * {@link HttpServletRequest}'s @@ -67,7 +67,7 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat /** * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided * parameters - * @param trustedIssuers a list of trusted issuers + * @param trustedIssuers an array of trusted issuers */ public JwtIssuerAuthenticationManagerResolver(String... trustedIssuers) { this(Arrays.asList(trustedIssuers)); @@ -76,7 +76,7 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat /** * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided * parameters - * @param trustedIssuers a list of trusted issuers + * @param trustedIssuers a collection of trusted issuers */ public JwtIssuerAuthenticationManagerResolver(Collection trustedIssuers) { Assert.notEmpty(trustedIssuers, "trustedIssuers cannot be empty"); @@ -90,8 +90,8 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat * parameters * * Note that the {@link AuthenticationManagerResolver} provided in this constructor - * will need to verify that the issuer is trusted. This should be done via an - * allowlist. + * will need to verify that the issuer is trusted. This should be done via an allowed + * list of issuers. * * One way to achieve this is with a {@link Map} where the keys are the known issuers: *
diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerReactiveAuthenticationManagerResolver.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerReactiveAuthenticationManagerResolver.java
index 333639cd9b..1bc75bee7d 100644
--- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerReactiveAuthenticationManagerResolver.java
+++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerReactiveAuthenticationManagerResolver.java
@@ -46,10 +46,10 @@ import org.springframework.web.server.ServerWebExchange;
  * "https://openid.net/specs/openid-connect-core-1_0.html#IssuerIdentifier">Issuer in
  * a signed JWT (JWS).
  *
- * To use, this class must be able to determine whether or not the `iss` claim is trusted.
- * Recall that anyone can stand up an authorization server and issue valid tokens to a
- * resource server. The simplest way to achieve this is to supply a list of trusted
- * issuers in the constructor.
+ * To use, this class must be able to determine whether the `iss` claim is trusted. Recall
+ * that anyone can stand up an authorization server and issue valid tokens to a resource
+ * server. The simplest way to achieve this is to supply a list of trusted issuers in the
+ * constructor.
  *
  * This class derives the Issuer from the `iss` claim found in the
  * {@link ServerWebExchange}'s
@@ -68,7 +68,7 @@ public final class JwtIssuerReactiveAuthenticationManagerResolver
 	/**
 	 * Construct a {@link JwtIssuerReactiveAuthenticationManagerResolver} using the
 	 * provided parameters
-	 * @param trustedIssuers a list of trusted issuers
+	 * @param trustedIssuers an array of trusted issuers
 	 */
 	public JwtIssuerReactiveAuthenticationManagerResolver(String... trustedIssuers) {
 		this(Arrays.asList(trustedIssuers));