Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-29 15:22:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-890: Corrected use of dataSource property name in RememberMeBDP.

Browse Source
This commit is contained in:
Luke Taylor 2008-06-18 10:35:30 +00:00
parent 7d79ae5424
commit af5f193ec1
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/java/org/springframework/security/config/RememberMeBeanDefinitionParser.java
View File

@ -84,7 +84,7 @@ public class RememberMeBeanDefinitionParser implements BeanDefinitionParser {
tokenRepo = new RuntimeBeanReference(tokenRepository); tokenRepo = new RuntimeBeanReference(tokenRepository);
} else { } else {
tokenRepo = new RootBeanDefinition(JdbcTokenRepositoryImpl.class); tokenRepo = new RootBeanDefinition(JdbcTokenRepositoryImpl.class);
((BeanDefinition)tokenRepo).getPropertyValues().addPropertyValue(ATT_DATA_SOURCE, ((BeanDefinition)tokenRepo).getPropertyValues().addPropertyValue("dataSource",
new RuntimeBeanReference(dataSource)); new RuntimeBeanReference(dataSource));
} }
services.getPropertyValues().addPropertyValue("tokenRepository", tokenRepo); services.getPropertyValues().addPropertyValue("tokenRepository", tokenRepo);

15
core/src/test/java/org/springframework/security/config/HttpSecurityBeanDefinitionParserTests.java
View File

@ -349,6 +349,21 @@ public class HttpSecurityBeanDefinitionParserTests {
assertTrue(rememberMeServices instanceof PersistentTokenBasedRememberMeServices); assertTrue(rememberMeServices instanceof PersistentTokenBasedRememberMeServices);
} }
@Test
public void rememberMeServiceWorksWithDataSourceRef() {
setContext(
"<http auto-config='true'>" +
" <remember-me data-source-ref='ds'/>" +
"</http>" +
"<b:bean id='ds' class='org.springframework.security.TestDataSource'> " +
" <b:constructor-arg value='tokendb'/>" +
"</b:bean>" + AUTH_PROVIDER_XML);
Object rememberMeServices = appContext.getBean(BeanIds.REMEMBER_ME_SERVICES);
assertTrue(rememberMeServices instanceof PersistentTokenBasedRememberMeServices);
}
@Test @Test
public void rememberMeServiceWorksWithExternalServicesImpl() throws Exception { public void rememberMeServiceWorksWithExternalServicesImpl() throws Exception {
setContext( setContext(