Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-26 22:02:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-957: logger.debug without guard causing massive performance hit

Browse Source 
http://jira.springframework.org/browse/SEC-957. Added debug logging guard as requested.
This commit is contained in:
Luke Taylor 2008-08-18 18:20:48 +00:00
parent 09cf90258f
commit bb457e1d07
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/main/java/org/springframework/security/providers/x509/X509AuthenticationProvider.java
View File

@ -45,7 +45,7 @@ import java.security.cert.X509Certificate;
* *
* @author Luke Taylor * @author Luke Taylor
* @deprecated superceded by the preauth provider. Use the X.509 authentication support in org.springframework.security.ui.preauth.x509 instead * @deprecated superceded by the preauth provider. Use the X.509 authentication support in org.springframework.security.ui.preauth.x509 instead
* or namespace support via the <x509 /> element. * or namespace support via the <x509 /> element.
* @version $Id$ * @version $Id$
*/ */
public class X509AuthenticationProvider implements AuthenticationProvider, InitializingBean, MessageSourceAware { public class X509AuthenticationProvider implements AuthenticationProvider, InitializingBean, MessageSourceAware {
@ -61,7 +61,7 @@ public class X509AuthenticationProvider implements AuthenticationProvider, Initi
//~ Methods ======================================================================================================== //~ Methods ========================================================================================================
public void afterPropertiesSet() throws Exception { public void afterPropertiesSet() throws Exception {
Assert.notNull(userCache, "An x509UserCache must be set"); Assert.notNull(userCache, "An x509UserCache must be set");
Assert.notNull(x509AuthoritiesPopulator, "An X509AuthoritiesPopulator must be set"); Assert.notNull(x509AuthoritiesPopulator, "An X509AuthoritiesPopulator must be set");
Assert.notNull(this.messages, "A message source must be set"); Assert.notNull(this.messages, "A message source must be set");
@ -101,7 +101,9 @@ public class X509AuthenticationProvider implements AuthenticationProvider, Initi
UserDetails user = userCache.getUserFromCache(clientCertificate); UserDetails user = userCache.getUserFromCache(clientCertificate);
if (user == null) { if (user == null) {
logger.debug("Authenticating with certificate " + clientCertificate); if (logger.isDebugEnabled()) {
logger.debug("Authenticating with certificate " + clientCertificate);
}
user = x509AuthoritiesPopulator.getUserDetails(clientCertificate); user = x509AuthoritiesPopulator.getUserDetails(clientCertificate);
userCache.putUserInCache(clientCertificate, user); userCache.putUserInCache(clientCertificate, user);
} }