Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-24 21:12:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch '5.8.x'

Browse Source
This commit is contained in:
Steve Riesenberg 2022-09-22 16:45:48 -05:00
commit ccac34b07c
No known key found for this signature in database
GPG Key ID: 5F311AB48A55D521
3 changed files with 46 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/main/java/org/springframework/security/web/context/NullSecurityContextRepository.java
View File

@ -53,9 +53,9 @@ public final class NullSecurityContextRepository implements SecurityContextRepos
* *
* @since 5.8 * @since 5.8
*/ */
public void setSecurityContextHolderStrategy(SecurityContextHolderStrategy strategy) { public void setSecurityContextHolderStrategy(SecurityContextHolderStrategy securityContextHolderStrategy) {
Assert.notNull(this.securityContextHolderStrategy, "securityContextHolderStrategy cannot be null"); Assert.notNull(securityContextHolderStrategy, "securityContextHolderStrategy cannot be null");
this.securityContextHolderStrategy = strategy; this.securityContextHolderStrategy = securityContextHolderStrategy;
} }
} }

17
web/src/main/java/org/springframework/security/web/context/RequestAttributeSecurityContextRepository.java
View File

@ -23,6 +23,8 @@ import jakarta.servlet.http.HttpServletResponse;
import org.springframework.security.core.context.SecurityContext; import org.springframework.security.core.context.SecurityContext;
import org.springframework.security.core.context.SecurityContextHolder; import org.springframework.security.core.context.SecurityContextHolder;
import org.springframework.security.core.context.SecurityContextHolderStrategy;
import org.springframework.util.Assert;
/** /**
* Stores the {@link SecurityContext} on a * Stores the {@link SecurityContext} on a
@ -48,6 +50,9 @@ public final class RequestAttributeSecurityContextRepository implements Security
private final String requestAttributeName; private final String requestAttributeName;
private SecurityContextHolderStrategy securityContextHolderStrategy = SecurityContextHolder
.getContextHolderStrategy();
/** /**
* Creates a new instance using {@link #DEFAULT_REQUEST_ATTR_NAME}. * Creates a new instance using {@link #DEFAULT_REQUEST_ATTR_NAME}.
*/ */
@ -81,7 +86,7 @@ public final class RequestAttributeSecurityContextRepository implements Security
private SecurityContext getContextOrEmpty(HttpServletRequest request) { private SecurityContext getContextOrEmpty(HttpServletRequest request) {
SecurityContext context = getContext(request); SecurityContext context = getContext(request);
return (context != null) ? context : SecurityContextHolder.createEmptyContext(); return (context != null) ? context : this.securityContextHolderStrategy.createEmptyContext();
} }
private SecurityContext getContext(HttpServletRequest request) { private SecurityContext getContext(HttpServletRequest request) {
@ -93,4 +98,14 @@ public final class RequestAttributeSecurityContextRepository implements Security
request.setAttribute(this.requestAttributeName, context); request.setAttribute(this.requestAttributeName, context);
} }
/**
* Sets the {@link SecurityContextHolderStrategy} to use. The default action is to use
* the {@link SecurityContextHolderStrategy} stored in {@link SecurityContextHolder}.
* @since 5.8
*/
public void setSecurityContextHolderStrategy(SecurityContextHolderStrategy securityContextHolderStrategy) {
Assert.notNull(securityContextHolderStrategy, "securityContextHolderStrategy cannot be null");
this.securityContextHolderStrategy = securityContextHolderStrategy;
}
} }

27
web/src/test/java/org/springframework/security/web/context/RequestAttributeSecurityContextRepositoryTests.java
View File

@ -25,9 +25,15 @@ import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.security.authentication.TestAuthentication; import org.springframework.security.authentication.TestAuthentication;
import org.springframework.security.core.context.SecurityContext; import org.springframework.security.core.context.SecurityContext;
import org.springframework.security.core.context.SecurityContextHolder; import org.springframework.security.core.context.SecurityContextHolder;
import org.springframework.security.core.context.SecurityContextHolderStrategy;
import org.springframework.security.core.context.SecurityContextImpl; import org.springframework.security.core.context.SecurityContextImpl;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
/** /**
* @author Rob Winch * @author Rob Winch
@ -42,6 +48,15 @@ class RequestAttributeSecurityContextRepositoryTests {
private SecurityContext expectedSecurityContext = new SecurityContextImpl(TestAuthentication.authenticatedUser()); private SecurityContext expectedSecurityContext = new SecurityContextImpl(TestAuthentication.authenticatedUser());
@Test
void setSecurityContextHolderStrategyWhenNullThenThrowsIllegalArgumentException() {
// @formatter:off
assertThatIllegalArgumentException()
.isThrownBy(() -> this.repository.setSecurityContextHolderStrategy(null))
.withMessage("securityContextHolderStrategy cannot be null");
// @formatter:on
}
@Test @Test
void saveContextAndLoadContextThenFound() { void saveContextAndLoadContextThenFound() {
this.repository.saveContext(this.expectedSecurityContext, this.request, this.response); this.repository.saveContext(this.expectedSecurityContext, this.request, this.response);
@ -82,4 +97,16 @@ class RequestAttributeSecurityContextRepositoryTests {
assertThat(context).isEqualTo(SecurityContextHolder.createEmptyContext()); assertThat(context).isEqualTo(SecurityContextHolder.createEmptyContext());
} }
@Test
void loadContextWhenCustomSecurityContextHolderStrategySetThenUsed() {
SecurityContextHolderStrategy securityContextHolderStrategy = mock(SecurityContextHolderStrategy.class);
given(securityContextHolderStrategy.createEmptyContext()).willReturn(new SecurityContextImpl());
this.repository.setSecurityContextHolderStrategy(securityContextHolderStrategy);
Supplier<SecurityContext> deferredContext = this.repository.loadContext(this.request);
assertThat(deferredContext.get()).isNotNull();
verify(securityContextHolderStrategy).createEmptyContext();
verifyNoMoreInteractions(securityContextHolderStrategy);
}
} }