From dada7898141b0c3a91402ddbae7fc04db8f611e3 Mon Sep 17 00:00:00 2001
From: Scott Battaglia <scott_battaglia@rutgers.edu>
Date: Tue, 1 Dec 2009 15:19:56 +0000
Subject: [PATCH] NOJIRA

removed unnecessary cast and use StringBuilder rather than non-final String and concatenation.
---
 .../authentication/event/LoggerListener.java  | 32 +++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/core/src/main/java/org/springframework/security/authentication/event/LoggerListener.java b/core/src/main/java/org/springframework/security/authentication/event/LoggerListener.java
index dc3b956406..477660d427 100644
--- a/core/src/main/java/org/springframework/security/authentication/event/LoggerListener.java
+++ b/core/src/main/java/org/springframework/security/authentication/event/LoggerListener.java
@@ -40,25 +40,25 @@ public class LoggerListener implements ApplicationListener<AbstractAuthenticatio
     //~ Methods ========================================================================================================
 
     public void onApplicationEvent(AbstractAuthenticationEvent event) {
-        if (event instanceof AbstractAuthenticationEvent) {
-            AbstractAuthenticationEvent authEvent = (AbstractAuthenticationEvent) event;
+        if (!logInteractiveAuthenticationSuccessEvents && event instanceof InteractiveAuthenticationSuccessEvent) {
+            return;
+        }
 
-            if (!logInteractiveAuthenticationSuccessEvents && authEvent instanceof InteractiveAuthenticationSuccessEvent) {
-                return;
+        if (logger.isWarnEnabled()) {
+            final StringBuilder builder = new StringBuilder();
+            builder.append("Authentication event ");
+            builder.append(ClassUtils.getShortName(event.getClass()));
+            builder.append(": ");
+            builder.append(event.getAuthentication().getName());
+            builder.append("; details: ");
+            builder.append(event.getAuthentication().getDetails());
+
+            if (event instanceof AbstractAuthenticationFailureEvent) {
+                builder.append("; exception: ");
+                builder.append(((AbstractAuthenticationFailureEvent) event).getException().getMessage());
             }
 
-            if (logger.isWarnEnabled()) {
-                String message = "Authentication event " + ClassUtils.getShortName(authEvent.getClass()) + ": "
-                    + authEvent.getAuthentication().getName() + "; details: "
-                    + authEvent.getAuthentication().getDetails();
-
-                if (event instanceof AbstractAuthenticationFailureEvent) {
-                    message = message + "; exception: "
-                        + ((AbstractAuthenticationFailureEvent) event).getException().getMessage();
-                }
-
-                logger.warn(message);
-            }
+            logger.warn(builder.toString());
         }
     }