Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish ForwardAuthenticationFailureHandler 

* Whitespace cleanup
* Add @since

Issue gh-3727
This commit is contained in:
Rob Winch 2016-03-09 10:12:45 -06:00
parent 7341da9320
commit e61bc7e93b
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/main/java/org/springframework/security/web/authentication/ForwardAuthenticationFailureHandler.java
View File

@ -31,7 +31,7 @@ import java.io.IOException;
* </p> * </p>
* *
* @author Shazin Sadakath * @author Shazin Sadakath
* * @since 4.1
*/ */
public class ForwardAuthenticationFailureHandler implements AuthenticationFailureHandler { public class ForwardAuthenticationFailureHandler implements AuthenticationFailureHandler {
@ -41,12 +41,11 @@ public class ForwardAuthenticationFailureHandler implements AuthenticationFailur
* @param forwardUrl * @param forwardUrl
*/ */
public ForwardAuthenticationFailureHandler(String forwardUrl) { public ForwardAuthenticationFailureHandler(String forwardUrl) {
Assert.isTrue(UrlUtils.isValidRedirectUrl(forwardUrl), "'" Assert.isTrue(UrlUtils.isValidRedirectUrl(forwardUrl), "'"
+ forwardUrl + "' is not a valid forward URL"); + forwardUrl + "' is not a valid forward URL");
this.forwardUrl = forwardUrl; this.forwardUrl = forwardUrl;
} }
@Override
public void onAuthenticationFailure(HttpServletRequest request, HttpServletResponse response, AuthenticationException exception) throws IOException, ServletException { public void onAuthenticationFailure(HttpServletRequest request, HttpServletResponse response, AuthenticationException exception) throws IOException, ServletException {
request.setAttribute(WebAttributes.AUTHENTICATION_EXCEPTION, exception); request.setAttribute(WebAttributes.AUTHENTICATION_EXCEPTION, exception);
request.getRequestDispatcher(forwardUrl).forward(request, response); request.getRequestDispatcher(forwardUrl).forward(request, response);

4
web/src/test/java/org/springframework/security/web/authentication/ForwardAuthenticationFailureHandlerTests.java
View File

@ -30,7 +30,7 @@ import static org.mockito.Mockito.mock;
* </p> * </p>
* *
* @author Shazin Sadakath * @author Shazin Sadakath
* * @since4.1
*/ */
public class ForwardAuthenticationFailureHandlerTests { public class ForwardAuthenticationFailureHandlerTests {
@ -55,6 +55,6 @@ public class ForwardAuthenticationFailureHandlerTests {
fafh.onAuthenticationFailure(request, response, e); fafh.onAuthenticationFailure(request, response, e);
assertThat(response.getForwardedUrl()).isEqualTo("/forwardUrl"); assertThat(response.getForwardedUrl()).isEqualTo("/forwardUrl");
assertThat(request.getAttribute(WebAttributes.AUTHENTICATION_EXCEPTION)).isEqualTo(e); assertThat(request.getAttribute(WebAttributes.AUTHENTICATION_EXCEPTION)).isEqualTo(e);
} }
} }