From ec77c630ece826fe2f55f3ab130b17313a16c680 Mon Sep 17 00:00:00 2001 From: Rafael Dominguez <5624449+raphaelDL@users.noreply.github.com> Date: Fri, 30 Nov 2018 09:09:43 -0600 Subject: [PATCH] Restored Jacoco default task dependence This commit ensures that the jacoco plugin is applied when calling check and test tasks. Also remoed the clean task that prevented sonarqube using coverage data Fixes: gh-6199 --- Jenkinsfile | 2 +- build.gradle | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/Jenkinsfile b/Jenkinsfile index c262b36d53..8b5d7f8a94 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -30,7 +30,7 @@ try { checkout scm withCredentials([string(credentialsId: 'spring-sonar.login', variable: 'SONAR_LOGIN')]) { try { - sh "./gradlew clean jacocoTestReport sonarqube -Dsonar.jacoco.reportPaths='**/build/jacoco/*.exec' -PexcludeProjects='**/samples/**' -Dsonar.host.url=$SPRING_SONAR_HOST_URL -Dsonar.login=$SONAR_LOGIN --refresh-dependencies --no-daemon --stacktrace" + sh "./gradlew sonarqube -PexcludeProjects='**/samples/**' -Dsonar.host.url=$SPRING_SONAR_HOST_URL -Dsonar.login=$SONAR_LOGIN --refresh-dependencies --no-daemon --stacktrace" } catch(Exception e) { currentBuild.result = 'FAILED: sonar' throw e diff --git a/build.gradle b/build.gradle index 53de5b415a..232b28a3b2 100644 --- a/build.gradle +++ b/build.gradle @@ -18,23 +18,8 @@ ext.milestoneBuild = !(snapshotBuild || releaseBuild) dependencyManagementExport.projects = subprojects.findAll { !it.name.contains('-boot') } -// Disable JaCoCo when not explicitly requested to enable caching of test -// See https://discuss.gradle.org/t/do-not-cache-if-condition-matched-jacoco-agent-configured-with-append-true-satisfied/23504 -gradle.taskGraph.whenReady { graph -> - def enabled = graph.allTasks.any { it instanceof JacocoReport } - subprojects { project -> - project.plugins.withType(JacocoPlugin) { - project.tasks.withType(Test) { - jacoco.enabled = enabled - } - } - } -} - - subprojects { plugins.withType(JavaPlugin) { project.sourceCompatibility='1.8' } } -