From ed6ff670d102736eea0ac360921c9015151ac630 Mon Sep 17 00:00:00 2001 From: Josh Cummings Date: Mon, 30 Oct 2023 17:24:20 -0600 Subject: [PATCH] Add Test Issue gh-13660 --- .../security/web/ObservationFilterChainDecorator.java | 2 +- .../security/web/ObservationFilterChainDecoratorTests.java | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java b/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java index 083849f863..ed24f19f91 100644 --- a/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java +++ b/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java @@ -141,7 +141,7 @@ public final class ObservationFilterChainDecorator implements FilterChainProxy.F static final class ObservationFilter implements Filter { - private static final Map OBSERVATION_NAMES = new HashMap<>(); + static final Map OBSERVATION_NAMES = new HashMap<>(); static { OBSERVATION_NAMES.put("DisableEncodeUrlFilter", "session.urlencoding"); diff --git a/web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java b/web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java index c0086ec19b..e95a1bb3eb 100644 --- a/web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java +++ b/web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java @@ -150,6 +150,13 @@ public class ObservationFilterChainDecoratorTests { .isEqualTo(expectedFilterNameTag); } + // gh-13660 + @Test + void observationNamesDoNotContainDashes() { + ObservationFilterChainDecorator.ObservationFilter.OBSERVATION_NAMES.values() + .forEach((name) -> assertThat(name).doesNotContain("-")); + } + static Stream decorateFiltersWhenCompletesThenHasSpringSecurityReachedFilterNameTag() { Filter filterWithName = new BasicAuthenticationFilter();