Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Throw exception if URL does not include context path when context relative 

Issue: gh-8399
This commit is contained in:
Astushi Yoshikawa 2020-04-16 20:12:03 +09:00 committed by Eleftheria Stein-Kousathana
parent dc514b369e
commit f08ca4e688
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/main/java/org/springframework/security/web/DefaultRedirectStrategy.java
View File

@ -74,7 +74,7 @@ public class DefaultRedirectStrategy implements RedirectStrategy {
}
if (!url.contains(contextPath)) {
return "";
throw new IllegalArgumentException("The fully qualified URL does not include context path.");
}
// Calculate the relative URL from the fully qualified URL, minus the last

6
web/src/test/java/org/springframework/security/web/DefaultRedirectStrategyTests.java
View File

@ -57,8 +57,8 @@ public class DefaultRedirectStrategyTests {
assertThat(response.getRedirectedUrl()).isEqualTo("remainder");
}
@Test
public void contextRelativeShouldRedirectToRootIfURLDoesNotContainContextPath()
@Test(expected = IllegalArgumentException.class)
public void contextRelativeShouldThrowExceptionIfURLDoesNotContainContextPath()
throws Exception {
DefaultRedirectStrategy rds = new DefaultRedirectStrategy();
rds.setContextRelative(true);
@ -68,7 +68,5 @@ public class DefaultRedirectStrategyTests {
rds.sendRedirect(request, response,
"https://redirectme.somewhere.else");
assertThat(response.getRedirectedUrl()).isEqualTo("");
}
}