Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-30 15:52:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove default constructor as class is now only responsible for group searches which need the args version.

Browse Source
This commit is contained in:
Luke Taylor 2006-05-16 23:38:48 +00:00
parent 30d878b22e
commit f546e2bbad
2 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/main/java/org/acegisecurity/providers/ldap/populator/DefaultLdapAuthoritiesPopulator.java
View File

@ -139,15 +139,6 @@ public class DefaultLdapAuthoritiesPopulator implements LdapAuthoritiesPopulator
//~ Constructors =========================================================== //~ Constructors ===========================================================
/**
* Constructor for non-group search scenarios. Typically in this case
* the <tt>userRoleAttributes</tt> property will be set to obtain roles directly
* from the user's directory entry attributes. The <tt>defaultRole</tt> property
* may also be set and will be assigned to all users.
*/
public DefaultLdapAuthoritiesPopulator() {
}
/** /**
* Constructor for group search scenarios. <tt>userRoleAttributes</tt> may still be * Constructor for group search scenarios. <tt>userRoleAttributes</tt> may still be
* set as a property. * set as a property.

8
core/src/test/java/org/acegisecurity/providers/ldap/populator/DefaultLdapAuthoritiesPopulatorTests.java
View File

@ -44,11 +44,11 @@ public class DefaultLdapAuthoritiesPopulatorTests extends AbstractLdapServerTest
// } // }
public void testDefaultRoleIsAssignedWhenSet() { public void testDefaultRoleIsAssignedWhenSet() {
DefaultLdapAuthoritiesPopulator populator = new DefaultLdapAuthoritiesPopulator(); DefaultLdapAuthoritiesPopulator populator = new DefaultLdapAuthoritiesPopulator(getInitialCtxFactory(), "ou=groups");
populator.setDefaultRole("ROLE_USER"); populator.setDefaultRole("ROLE_USER");
LdapUserDetailsImpl.Essence user = new LdapUserDetailsImpl.Essence(); LdapUserDetailsImpl.Essence user = new LdapUserDetailsImpl.Essence();
user.setDn("Ignored"); user.setDn("cn=notfound");
user.setUsername("Ignored"); user.setUsername("notfound");
user.setAttributes(new BasicAttributes()); user.setAttributes(new BasicAttributes());
GrantedAuthority[] authorities = GrantedAuthority[] authorities =
@ -57,7 +57,7 @@ public class DefaultLdapAuthoritiesPopulatorTests extends AbstractLdapServerTest
assertEquals("ROLE_USER", authorities[0].getAuthority()); assertEquals("ROLE_USER", authorities[0].getAuthority());
} }
public void testGroupSearch() throws Exception { public void testGroupSearchReturnsExpectedRoles() {
DefaultLdapAuthoritiesPopulator populator = DefaultLdapAuthoritiesPopulator populator =
new DefaultLdapAuthoritiesPopulator(getInitialCtxFactory(), "ou=groups"); new DefaultLdapAuthoritiesPopulator(getInitialCtxFactory(), "ou=groups");
populator.setRolePrefix("ROLE_"); populator.setRolePrefix("ROLE_");