Cwikius-Spring
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,092 Commits 29 Branches 320 Tags 104 MiB
Commit Graph

9092 Commits

Author SHA1 Message Date
Josh Cummings 9b2ece9dba
Remove SAML 2.0 Framework Tests 
Closes gh-8989
 2020-08-28 16:17:39 -06:00
Josh Cummings 0a4766f21e
Restructure SAML 2.0 Documentation 
- Add images
- Standardize terminology
- Add detail about working with OpenSAML
- Reorganize sections

Closes gh-8763
 2020-08-28 12:42:44 -06:00
Eleftheria Stein a9fe2cb377 Add servlet OAuth2 login Kotlin samples 
Issue gh-8172
 2020-08-28 18:15:59 +02:00
Eleftheria Stein 44399a5256 Add servlet OAuth2 resource server Kotlin samples 
Issue gh-8172
 2020-08-28 12:21:24 +02:00
Eleftheria Stein 902fca65a4 Add authenticationManagerResolver to Kotlin DSL 
Closes gh-8981
 2020-08-28 11:48:55 +02:00
Eleftheria Stein 7a5d9ce287 Fix typos in reference docs 2020-08-25 10:57:41 +02:00
Rob Winch 2abf59b695 Merge Formatting Changes 
Issue gh-8945
 2020-08-24 17:33:23 -05:00
Rob Winch 36ae1fe3f9 Polish oauth2-resource-server format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch d5ae4337e3 Polish oauth2-jose format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch a729d24d47 Polish oauth2-core format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch dc47a7575e Polish oauth-client format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch 38aae7f015 Polish messaging format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch 95bc670dd5 Polish itest format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch a662a5593e Polish crypto format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch 4fd67b48e0 Polish core format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch 254f2e2aec Polish config format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch e3dd8d2530 Polish acl format 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Rob Winch 28817e62ef Fix imports of AuthenticationPayloadExchangeConverter 
Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 319d3364aa Migrate to assertThatExceptionOfType 
Consistently use `assertThatExceptionOfType(...).isThrownBy(...)`
rather than `assertThatCode` or `assertThatThrownBy`. This aligns with
Spring Boot and Spring Cloud. It also allows the convenience
`assertThatIllegalArgument` and `assertThatIllegalState` methods to
be used.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb ef8f113619 Use assertThat instead of Java assert 
Fix `DefaultSavedRequestMixinTests` so that `assertThat` is used rather
than Java's `assert` keyword.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 1e840cc854 Move @Mock annotations 
Update a couple of tests to use the more traditional `@Mock` annotation
placement.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 2f8e835b11 Use assertThatObject to save casting 
Update tests that use `assertThat((Object) ...)` to use the convenience
`assertThatObject(...)` method instead.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 0a3eeb9c80 Remove incorrect AssertJ imports 
Fix a few tests that were accidentally importing incorrect AssertJ
classes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb a5aa6b3d7f Remove blank lines from all tests 
Remove all blank lines from test code so that test methods are
visually grouped together. This generally helps to make the test
classes easer to scan, however, the "given" / "when" / "then"
blocks used by some tests are now not as easy to discern.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 5bdd757108 Polish spring-security-web main code 
Manually polish `spring-security-web` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb ef951bae90 Polish spring-security-test main code 
Manually polish `spring-security-test` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 2ca6256b89 Polish spring-security-taglibs main code 
Manually polish `spring-security-taglibs` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 1f03608b73 Polish spring-security-saml2 main code 
Manually polish `spring-security-saml2` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb e8094b8cf2 Polish spring-security-rsocket main code 
Manually polish `spring-security-rsocket` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 16819be437 Polish spring-security-remoting main code 
Manually polish `spring-security-remoting` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 5924ed885b Polish spring-security-openid main code 
Manually polish `spring-security-openid` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb ba19a9e4b6 Polish spring-security-oauth2-resource-server main code 
Manually polish `spring-security-oauth-resource-server`
following the formatting and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 20aa8bef25 Polish spring-security-oauth2-jose main code 
Manually polish `spring-security-oauth-jose` following the
formatting and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb a577871bca Polish spring-security-oauth2-core main code 
Manually polish `spring-security-oauth-core` following the
formatting and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 7a715f9086 Polish spring-security-oauth2-client main code 
Manually polish `spring-security-oauth-cleint` following the
formatting and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb ad1dbf425f Polish spring-security-messaging main code 
Manually polish `spring-security-messaging` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 554ef627fb Polish spring-security-ldap main code 
Manually polish `spring-security-ldap` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 48957b42fe Polish spring-security-data main code 
Manually polish `spring-security-data` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb da22e97147 Polish spring-security-crypto main code 
Manually polish `spring-security-crypto` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 771ef0dadc Polish spring-security-core main code 
Manually polish `spring-security-core` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:09 -05:00
Phillip Webb 7bf6008efe Polish spring-security-config main code 
Manually polish `spring-security-config` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb 4e5aa6c9d3 Polish spring-security-cas main code 
Manually polish `spring-security-cas` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb fdc66d45d5 Polish spring-security-acl main code 
Manually polish `spring-security-acl` following the formatting
and checkstyle fixes.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb ee661f7b71 Fix whitespace issues in format-off code 
Fix a few whitespace issues in format-off code that would
otherwise fail checkstyle.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb 834dcf5bcf Use consistent ternary expression style 
Update all ternary expressions so that the condition is always in
parentheses and "not equals" is used in the test. This helps to bring
consistency across the codebase which makes ternary expression easier
to scan.

For example: `a = (a != null) ? a : b`

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb 8d3f039f76 Reduce method visibility when possible 
Reduce method visibility for package private classes when possible.

In the case of abstract classes that will eventually be made public,
the class has been made public and a package-private constructor has
been added.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb ec6a4cb3f0 Use consistent equals/hashCode/toString order 
Ensure that `equals` `hashCode` and `toString` methods always appear in
the same order. This aligns with the style used in Spring Framework.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb 612fb22a7f Remove unnecessary lambda blocks 
Remove lambda blocks that aren't needed and replace instead with a
simple expression.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb 52f20b5281 Use parenthesis with single-arg lambdas 
Use regular expression search/replace to ensure all single-arg
lambdas have parenthesis. This aligns with the style used in Spring
Boot and ensure that single-arg and multi-arg lambdas are consistent.

Issue gh-8945
 2020-08-24 17:33:08 -05:00
Phillip Webb 01d90c9881 Hide utility class constructors 
Update all utility classes so that they have a private constructor. This
prevents users from accidentally creating an instance, when they should
just use the static methods directly.

Issue gh-8945
 2020-08-24 17:33:08 -05:00