16 Commits

Author	SHA1	Message	Date
Phillip Webb	218480fb7c	Reduce the number of nested if statements ... Refactor `HeadersBeanDefinitionParser` and `AclImpl` to reduce the number of nested if statements. A few extracted methods are now used to hopefully improve readability. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	0b4b22f28f	Remove "need braces" checkstyle suppression ... Remove the "need braces" checkstyle suppression which does not cause any violations. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	81fe9fc640	Make all exception classes immutable ... Update all exception classes so that they are fully immutable and cannot be changed once they have been thrown. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	a0b9442265	Use consistent modifier order ... Update code to use a consistent modifier order that aligns with that used in the "Java Language specification". Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	4075595a3f	Ignore existing InterfaceIsType violations ... Add suppressions for existing `InterfaceIsType` violations. Ideally theses should be classes, but we can't easily change them without breaking binary back compatibility. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	a2f2e9ac8d	Move inner-types so that they are always last ... Move all inner-types so that they are consistently the last item defined. This aligns with the style used by Spring Framework and the consistency generally makes it easier to scan the source. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	418c3d6808	Avoid inner assignments ... Replace code of the form `a = b =c` with distinct statements. Although this results in more lines of code, they are usually easier to understand. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	8866fa6fb0	Always use 'this.' when accessing fields ... Apply an Eclipse cleanup rules to ensure that fields are always accessed using `this.`. This aligns with the style used by Spring Framework and helps users quickly see the difference between a local and member variable. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	6894ff5d12	Make classes final where possible ... Update classes that have private constructors so that they are also declared final. In a few cases, inner-classes used private constructors but were subclassed. These have now been changed to have package-private constructors. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	b5d499e2eb	Remove empty block ... Refactor a few classes so that empty blocks are not longer used. For example, rather than: if(x) { } else { i++; } use: if(!x) { i++; } Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	37fa94fafc	Organize imports ... Use "organize imports" from Eclipse to cleanup import statements so that they appear in a consistent and well defined order. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	5f64f53c3f	Use consistent "@" tag order in Javadoc ... Ensure that Javadoc "@" tags appear in a consistent and well defined order. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	7f0653fa34	Remove array style checkstyle suppression ... Remove the array style rules suppression since it doesn't cause any checkstyle violations. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	863c0873dd	Suppress third-party code from checkstyle ... Suppress `BCrypt` and `ComparableVersion` from checkstyle since these source files were developed by a third-party. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	8142e4046f	Use compact annotation style ... Always use compact annotations when possible. For example, replace `@Target(value = ElementType.TYPE)` with `@Target(ElementType.TYPE)`. Issue gh-8945	2020-08-24 17:33:07 -05:00
Phillip Webb	aea0fea5d9	Add Spring Checkstyle with all checks disabled ... Introduce checkstyle rules from spring-javaformat, but keep them disabled so that fixes can be introduced one commit at a time. Issue gh-8945	2020-08-24 17:33:07 -05:00