1d72a05c32
Add SecurityContextHolderStrategy to OAuth2
...
Issue gh-11060
2022-06-27 13:05:12 -06:00
539a11d0a4
Encode postLogoutRedirectUri query params
...
Closes gh-11379
2022-06-16 16:13:42 -06:00
f035c30edb
Encode postLogoutRedirectUri query params
...
Closes gh-11379
2022-06-16 16:12:13 -06:00
01513ab17e
Add placeholders to reactive post_logout_redirect_uri
...
Now also supports baseScheme, baseHost, basePort, and basePath
Issue gh-11229
2022-06-16 16:10:26 -06:00
6f69d85fcb
Reactive OAuth 2.0 logout handler resolves registrationId
...
Closes gh-11378
2022-06-16 16:09:57 -06:00
3f30de388a
Encode postLogoutRedirectUri query params
...
Closes gh-11379
2022-06-16 16:09:56 -06:00
e4505ed6c8
Add placeholders to post_logout_redirect_uri
...
Now supports baseScheme, baseHost, basePort, and basePath in addition
to extant baseUrl.
Closes gh-11229
2022-06-16 16:09:56 -06:00
a8ab432aea
Add placeholders to reactive post_logout_redirect_uri
...
Now also supports baseScheme, baseHost, basePort, and basePath
Issue gh-11229
2022-06-16 15:58:44 -06:00
ebb5746f6e
Reactive OAuth 2.0 logout handler resolves registrationId
...
Closes gh-11378
2022-06-16 15:58:44 -06:00
18f7cf5406
Encode postLogoutRedirectUri query params
...
Closes gh-11379
2022-06-16 15:58:43 -06:00
cb0ab49adc
Add placeholders to post_logout_redirect_uri
...
Now supports baseScheme, baseHost, basePort, and basePath in addition
to extant baseUrl.
Closes gh-11229
2022-06-16 15:58:35 -06:00
d18291676f
Update copyright year
...
Issue gh-11372
2022-06-15 13:14:07 -05:00
c7df39a3e6
Fix tests using root cause for exception messages
...
Closes gh-11372
2022-06-14 17:12:15 -05:00
000b87f9aa
Revert "Use Spring Framework version 6.0.0-M3"
...
This reverts commit b803e845e7
2022-05-11 08:36:14 -03:00
806e05855c
Replace removed context-related operators
...
Closes gh-11194
2022-05-10 14:58:02 -03:00
b803e845e7
Use Spring Framework version 6.0.0-M3
...
Closes gh-11193
2022-05-10 14:49:02 -03:00
50f8df6f07
Use HttpStatusCode
...
Closes gh-11091
2022-04-11 09:19:56 -03:00
e1f649690b
Adapt to changes in R2DBC
2022-04-11 09:19:47 -03:00
8aa7029d07
Fix checkstyle errors
...
Issue gh-10989
2022-03-18 22:53:29 -05:00
f0168c6c27
Add support for customizing claims in JWT Client Assertion
...
Closes gh-9855
2022-03-17 09:53:16 -05:00
428216b322
Add support for customizing claims in JWT Client Assertion
...
Closes gh-9855
2022-03-17 09:50:25 -05:00
50a3bcf728
Remove unused code
2022-03-17 05:08:39 -04:00
50d315d833
Remove unused code
2022-03-17 04:23:44 -04:00
54b033078b
Allow configuring PKCE for confidential clients
...
Closes gh-6548
2022-03-16 13:36:10 -04:00
a2ffc88294
Allow configuring PKCE for confidential clients
...
Closes gh-6548
2022-03-16 13:33:12 -04:00
92a385ed05
OAuth 2.0 logout handler resolves uri placeholders
...
- OidcClientInitiatedLogoutSuccessHandler can automatically resolve placeholders like baseUrl and registrationId inside the postLogoutRedirectUri
Closes gh-7900
2022-03-15 14:05:26 -06:00
73003d59d6
OAuth 2.0 logout handler resolves uri placeholders
...
- OidcClientInitiatedLogoutSuccessHandler can automatically resolve placeholders like baseUrl and registrationId inside the postLogoutRedirectUri
Issue gh-7900
2022-03-15 12:54:39 -06:00
68e2586f06
Move UnmodifiableMapDeserializer
...
Issue gh-10905
2022-03-01 14:17:17 -07:00
931fb6a328
Move UnmodifiableMapDeserializer
...
Issue gh-10905
2022-03-01 14:03:41 -07:00
525f40490c
Allow Jwt assertion to be resolved
...
Closes gh-9812
2022-01-10 10:59:14 -05:00
214cfe807e
Allow Jwt assertion to be resolved
...
Closes gh-9812
2022-01-10 10:42:10 -05:00
25feedb870
Fix removal of framework deprecated code
...
Issue https://github.com/spring-projects/spring-framework/issues/27686
2021-11-19 13:06:13 -03:00
17e28fa7aa
Update clockSkew javadoc according to implementation
...
Closes gh-10174
2021-11-19 13:48:32 +01:00
aa1ef46d84
Update clockSkew javadoc according to implementation
...
Closes gh-10174
2021-11-19 13:33:05 +01:00
862122a267
Update clockSkew javadoc according to implementation
...
Closes gh-10174
2021-11-19 08:13:12 +01:00
00fafd878c
Allow custom OAuth2ErrorHttpMessageConverter with OAuth2ErrorResponseErrorHandler
...
Closes gh-10425
2021-11-16 15:27:48 -06:00
498636e26b
Allow custom OAuth2ErrorHttpMessageConverter with OAuth2ErrorResponseErrorHandler
...
Closes gh-10425
2021-11-16 14:52:08 -06:00
076c01daef
Add missing @since 5.6
2021-11-09 14:07:05 -06:00
ea352e1c59
Add missing @since 5.6
2021-11-09 14:02:35 -06:00
db60df2f9c
Update to Spring Framework 6.0
...
Issue gh-10360
2021-11-01 09:02:42 -03:00
560962649e
Remove BlockHound dependency
...
The dependency is not needed anymore and there is a issue when using OpenJDK 13 or higher https://github.com/reactor/BlockHound/issues/33
Issue gh-10343
2021-11-01 09:02:42 -03:00
e4a76b0ec9
Checkstyle Fixes
...
- Javadoc tag ordering
- Private constructors before inner classes
Issue gh-10394
2021-10-22 10:19:34 -05:00
f836897190
Checkstyle Fixes
...
- Javadoc tag ordering
- Private constructors before inner classes
Issue gh-10394
2021-10-18 21:03:35 -05:00
3b564b2026
Add parameters converter support to AbstractWebClientReactiveOAuth2AccessTokenResponseClient
...
This adds support for configuring NimbusJwtClientAuthenticationParametersConverter to any AbstractWebClientReactiveOAuth2AccessTokenResponseClient as an additional parameters converter, which in turns adds reactive support for jwt client authentication.
Closes gh-10146
2021-10-06 13:09:33 -05:00
9b24f66f1c
Implement reactive support for JWT as an Authorization Grant
...
Closes gh-10147
2021-10-05 16:09:24 -05:00
97c949d929
oauth2Login() AuthenticationProvider's preserve root cause exception when rethrown
...
Closes gh-10228
2021-09-24 10:41:31 -04:00
5830fda2fa
Introduce JwtEncoder
...
Closes gh-9208
2021-09-24 05:13:40 -04:00
860690491a
Add setBodyExtractor
...
Closes gh-10260
2021-09-22 15:32:19 -06:00
9b4ddd7e0a
Make AuthorizationGrantTypeConverter support custom grant type
...
Closes gh-10155
2021-08-19 13:13:20 -04:00
6d6dc113d8
Add converter for authentication result in OAuth2LoginAuthenticationFilter
...
Closes gh-10033
2021-08-10 16:50:19 -05:00
fc553bf19a
Add gh-10130 to tests
2021-08-09 15:33:54 -05:00
acca3dba69
Polish gh-10131
2021-08-09 11:07:12 -05:00
044157061f
Enable customizing headers in token requests
...
Adds the possibility to customize the headers of the access token request in AbstractWebClientReactiveOAuth2AccessTokenResponseClient, similarly to what is done in the AbstractOAuth2AuthorizationGrantRequestEntityConverter.
Closes gh-10130
2021-08-09 10:50:37 -05:00
e1b6a7ba29
Revert "URL encode client credentials"
...
This reverts commit c0200512a7
2021-07-20 14:06:46 -05:00
f55247e28a
Revert "URL encode client credentials"
...
This reverts commit 6cafa48369
2021-07-20 14:05:55 -05:00
dc81e1c86b
Revert "URL encode client credentials"
...
This reverts commit 5243b1b8a8
2021-07-20 13:29:29 -05:00
dfebd6d9d4
Revert "URL encode client credentials"
...
This reverts commit e6c268add0
2021-07-20 12:59:44 -05:00
b6ff4d3674
Fix mockito UnnecessaryStubbingException
2021-07-09 14:35:10 -05:00
3e93b024d6
openrewrite Junit Migration
2021-07-09 14:32:52 -05:00
1cd4ffeeb7
fix typo preventing full exception to be displayed in log
...
closes gh-9901
2021-06-17 08:40:55 -06:00
5fd81eeaf1
fix typo preventing full exception to be displayed in log
...
closes gh-9901
2021-06-17 08:38:24 -06:00
d4c3cea0e6
Update Copyright
...
Issue gh-9901
2021-06-17 08:34:31 -06:00
1d606ccedb
fix typo preventing full exception to be displayed in log
...
closes gh-9901
2021-06-17 08:33:32 -06:00
a332e2a728
Support additional client authentication methods
...
Closes gh-9780
2021-06-16 16:03:13 -05:00
9daf058a6e
Handle missing authorization endpoint uri
...
Closes gh-9795
2021-06-16 16:00:53 -05:00
839cc5e851
Remove validation for unsupported grant types
...
Closes gh-9828
2021-06-16 15:55:45 -05:00
807ce30948
Support additional client authentication methods
...
Closes gh-9780
2021-06-16 15:48:03 -05:00
0cba0874f3
Handle missing authorization endpoint uri
...
Closes gh-9795
2021-06-16 15:38:53 -05:00
9b05afdee8
Remove validation for unsupported grant types
...
Closes gh-9828
2021-06-16 14:54:33 -05:00
6fbd038111
Jwt client authentication converter detects new key
...
Closes gh-9814
2021-06-16 12:58:01 -04:00
eb6ed283e0
Jwt client authentication converter detects new key
...
Closes gh-9814
2021-06-16 12:55:12 -04:00
67a18f564a
Store one request by default in WebSessionOAuth2ServerAuthorizationRequestRepository
...
Related to gh-9649
Closes gh-9857
2021-06-15 12:14:37 -05:00
b6ae11295f
Commit missing compile fix from cherry-pick conflict
2021-06-15 12:10:06 -05:00
ee9c8e2fd0
Store one request by default in WebSessionOAuth2ServerAuthorizationRequestRepository
...
Related to gh-9649
Closes gh-9857
2021-06-15 12:06:22 -05:00
a108868529
Store one request by default in WebSessionOAuth2ServerAuthorizationRequestRepository
...
Related to gh-9649
Closes gh-9857
Closes gh-9912
2021-06-15 11:44:34 -05:00
700bda68b7
Store one request by default in WebSessionOAuth2ServerAuthorizationRequestRepository
...
Related to gh-9649
Closes gh-9857
2021-06-15 11:32:35 -05:00
aed993f3e5
Store one request by default in WebSessionOAuth2ServerAuthorizationRequestRepository
...
Related to gh-9649
Closes gh-9857
2021-06-15 11:03:30 -05:00
c0200512a7
URL encode client credentials
...
Closes gh-9610
2021-06-08 08:27:20 -05:00
36805c7192
Revert "Use strict equality for timestamp comparison in JDBC tests"
...
This reverts commit 09a0670cb6
2021-06-08 10:13:53 +03:00
09a0670cb6
Use strict equality for timestamp comparison in JDBC tests
...
This is possible because of the update to HSQLDB 2.6.0
This reverts commit eb7b27695d
2021-06-08 09:31:55 +03:00
6cafa48369
URL encode client credentials
...
Closes gh-9610
2021-06-03 09:39:00 -05:00
5243b1b8a8
URL encode client credentials
...
Closes gh-9610
2021-06-03 09:29:25 -05:00
e6c268add0
URL encode client credentials
...
Closes gh-9610
2021-06-03 09:12:18 -05:00
ac9b137cad
URL encode client credentials
...
Closes gh-9610
2021-06-01 12:57:06 -05:00
6d816fbf85
Polish postLogoutRedirectUri encoding
...
Issue gh-9511
2021-05-26 14:38:20 -06:00
e52b104636
Encode postLogoutRedirectUri query params
...
Now encodes already encoded queryparameters in postLogoutRedirectUrl
correctly
Closes gh-9511
2021-05-26 14:36:05 -06:00
24c3c52254
Polish postLogoutRedirectUri encoding
...
Issue gh-9511
2021-05-26 13:58:28 -06:00
499701e67a
Encode postLogoutRedirectUri query params
...
Now encodes already encoded queryparameters in postLogoutRedirectUrl
correctly
Closes gh-9511
2021-05-26 13:58:23 -06:00
f48a006034
Polish postLogoutRedirectUri encoding
...
Issue gh-9511
2021-05-26 13:51:26 -06:00
b7a0959ede
Encode postLogoutRedirectUri query params
...
Now encodes already encoded queryparameters in postLogoutRedirectUrl
correctly
Closes gh-9511
2021-05-26 13:51:15 -06:00
65ecaa0c28
Polish postLogoutRedirectUri encoding
...
Issue gh-9511
2021-05-26 12:31:41 -06:00
b671a96073
Encode postLogoutRedirectUri query params
...
Now encodes already encoded queryparameters in postLogoutRedirectUrl
correctly
Closes gh-9511
2021-05-26 12:10:03 -06:00
d3a3c36ad3
Handle custom status codes in error handler
...
Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.
Closes gh-9741
2021-05-25 16:14:35 -05:00
22272321f2
Handle custom status codes in error handler
...
Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.
Closes gh-9741
2021-05-25 15:37:37 -05:00
589eccc547
Handle custom status codes in error handler
...
Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.
Closes gh-9741
2021-05-25 15:08:05 -05:00
de4b3a4310
Handle custom status codes in error handler
...
Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.
Closes gh-9741
2021-05-25 13:41:04 -05:00
36dcbe24d0
Handle custom status codes in error handler
...
Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.
Closes gh-9741
2021-05-25 13:31:34 -05:00
5b24bd1288
Adjust ClientRegistrationsTests
...
Closes gh-9748
2021-05-14 10:30:46 -06:00
c9a8419e22
Additional HttpSessionOAuth2AuthorizationRequestRepository tests
...
Issue gh-5145
2021-05-13 20:12:15 -04:00
ecb4a5749a
HttpSessionOAuth2AuthorizationRequestRepository: store one request by default
...
Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.
Closes gh-5145
Intentionally regresses gh-5110
2021-05-13 20:12:00 -04:00
a4216d0ea5
Additional HttpSessionOAuth2AuthorizationRequestRepository tests
...
Issue gh-5145
2021-05-13 19:52:00 -04:00
b8eee2002f
HttpSessionOAuth2AuthorizationRequestRepository: store one request by default
...
Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.
Closes gh-5145
Intentionally regresses gh-5110
2021-05-13 19:50:47 -04:00
f3436f25fb
Additional HttpSessionOAuth2AuthorizationRequestRepository tests
...
Issue gh-5145
2021-05-13 14:01:04 -04:00
e447a35cf2
HttpSessionOAuth2AuthorizationRequestRepository: store one request by default
...
Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.
Closes gh-5145
Intentionally regresses gh-5110
2021-05-13 14:00:53 -04:00
5f6de026a8
Update javadoc AuthorizationCodeOAuth2AuthorizedClientProvider
...
Closes gh-9708
2021-05-13 13:02:08 -04:00
64b7af473d
Additional HttpSessionOAuth2AuthorizationRequestRepository tests
...
Issue gh-5145
2021-05-12 14:59:25 -05:00
35f5ebdbcf
HttpSessionOAuth2AuthorizationRequestRepository: store one request by default
...
Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.
Closes gh-5145
Intentionally regresses gh-5110
2021-05-12 14:59:25 -05:00
761e3a9dd8
JwtBearerOAuth2AuthorizedClientProvider checks for access token expiry
...
Fixes gh-9700
2021-04-30 10:12:38 -04:00
eff4cdc924
Polish gh-9505
2021-04-09 06:22:29 -04:00
7694aa27cf
Add jwt-bearer authorization grant
...
Closes gh-6053
2021-04-09 06:22:29 -04:00
9c97970e26
Add Jwt Client Authentication support
...
Closes gh-8175
2021-04-08 15:44:33 -04:00
b8e47882aa
Fix test to use non-expired token
...
Closes gh-9506
2021-03-17 17:38:08 +01:00
5e5ff27109
Configure Jackson for nanosecond precision
...
Closes gh-9461
2021-02-17 11:53:36 -07:00
a0a9718b8b
Use Instant with micro-second precision
...
Closes gh-9449
2021-02-17 11:31:23 -07:00
98399c920a
Make user info response status check error only
...
Closes gh-9336
2021-01-25 11:10:03 -05:00
0f7360e8fa
Make user info response status check error only
...
Closes gh-9336
2021-01-25 10:46:07 -05:00
f6b678f137
Make user info response status check error only
...
Closes gh-9336
2021-01-25 10:23:49 -05:00
d85a7cfc4a
Make user info response status check error only
...
Closes gh-9336
2021-01-25 10:02:58 -05:00
580b988e7f
Fix NullPointerException
...
- Caused by a malformed WWW-Authenticate value
Closes gh-9364
2021-01-21 16:22:29 -07:00
56db058fd0
Fix NullPointerException
...
- Caused by a malformed WWW-Authenticate value
2021-01-21 16:18:23 -07:00
58e3235093
Deprecate ClientAuthenticationMethod BASIC and POST
...
Closes gh-9220
2020-11-25 15:13:28 -05:00
c069692ab9
Extract OAuth2Token from AbstractOAuth2Token
...
Closes gh-5502
2020-11-02 20:35:08 -05:00
6724e3e514
Provide a R2dbc implementation of ReactiveOuath2AuthorizedClientService
...
Implement R2dbcReactiveOuath2AuthorizedClientService which persists the
Oauth2AuthorizedClient in a sql database
R2dbcReactiveOuath2AuthorizedClientService is using the spring-r2dbc
module to persist/load Oauth2AuthorizedClient to/from a sql database
Add optional depedency to the spring-r2dbc module
Add test compile dependencies to r2dbc-h2 and r2dbc-test
Closes gh-7890
2020-10-29 15:44:12 -04:00
42a787d1f6
Add Postgres sql for JDBC implementation of OAuth2AuthorizedClientService
...
Postgres doesn't have a BLOB type, but it does have an equivalent BYTEA
type.
This approach and naming convention follows the convention established
in Spring Session JDBC which has sql for each RDBMS with files names in
the pattern *-{dbname}.sql, for example:
schema-db2.sql
schema-derby.sql
schema-h2.sql
schema-mysql.sql
schema-postgresql.sql
See https://github.com/spring-projects/spring-session/tree/2.3.1.RELEASE/spring-session-jdbc/src/main/resources/org/springframework/session/jdbc
Issue gh-9070
2020-10-22 09:56:20 -04:00
05dc326389
Use LobHandler in JdbcOAuth2AuthorizedClientService
...
LobHandler provides an abstraction for handling large binary fields and large text
fields in specific databases, no matter if represented as simple types or
Large OBjects.
Its use provides compatibility with many databases eliminating the need
for custom OAuth2AuthorizedClientParametersMapper and
OAuth2AuthorizedClientRowMapper implementations.
Closes gh-9070
2020-10-22 09:56:20 -04:00
c502312719
Replace expected @Test attributes with AssertJ
...
Replace JUnit expected @Test attributes with AssertJ calls.
2020-09-22 16:13:51 -06:00
20baa7d409
Replace ExpectedException @Rules with AssertJ
...
Replace JUnit ExpectedException @Rules with AssertJ calls.
2020-09-22 16:13:51 -06:00
6e6d382357
Adapt to WebClient's new exception wrapping
...
See https://github.com/spring-projects/spring-framework/issues/23842
Closes gh-9031
2020-09-17 12:21:51 -04:00
2abf59b695
Merge Formatting Changes
...
Issue gh-8945
2020-08-24 17:33:23 -05:00
dc47a7575e
Polish oauth-client format
...
Issue gh-8945
2020-08-24 17:33:09 -05:00
319d3364aa
Migrate to assertThatExceptionOfType
...
Consistently use `assertThatExceptionOfType(...).isThrownBy(...)`
rather than `assertThatCode` or `assertThatThrownBy`. This aligns with
Spring Boot and Spring Cloud. It also allows the convenience
`assertThatIllegalArgument` and `assertThatIllegalState` methods to
be used.
Issue gh-8945
2020-08-24 17:33:09 -05:00
2f8e835b11
Use assertThatObject to save casting
...
Update tests that use `assertThat((Object) ...)` to use the convenience
`assertThatObject(...)` method instead.
Issue gh-8945
2020-08-24 17:33:09 -05:00
a5aa6b3d7f
Remove blank lines from all tests
...
Remove all blank lines from test code so that test methods are
visually grouped together. This generally helps to make the test
classes easer to scan, however, the "given" / "when" / "then"
blocks used by some tests are now not as easy to discern.
Issue gh-8945
2020-08-24 17:33:09 -05:00
7a715f9086
Polish spring-security-oauth2-client main code
...
Manually polish `spring-security-oauth-cleint` following the
formatting and checkstyle fixes.
Issue gh-8945
2020-08-24 17:33:09 -05:00
834dcf5bcf
Use consistent ternary expression style
...
Update all ternary expressions so that the condition is always in
parentheses and "not equals" is used in the test. This helps to bring
consistency across the codebase which makes ternary expression easier
to scan.
For example: `a = (a != null) ? a : b`
Issue gh-8945
2020-08-24 17:33:08 -05:00
8d3f039f76
Reduce method visibility when possible
...
Reduce method visibility for package private classes when possible.
In the case of abstract classes that will eventually be made public,
the class has been made public and a package-private constructor has
been added.
Issue gh-8945
2020-08-24 17:33:08 -05:00
612fb22a7f
Remove unnecessary lambda blocks
...
Remove lambda blocks that aren't needed and replace instead with a
simple expression.
Issue gh-8945
2020-08-24 17:33:08 -05:00
52f20b5281
Use parenthesis with single-arg lambdas
...
Use regular expression search/replace to ensure all single-arg
lambdas have parenthesis. This aligns with the style used in Spring
Boot and ensure that single-arg and multi-arg lambdas are consistent.
Issue gh-8945
2020-08-24 17:33:08 -05:00
01d90c9881
Hide utility class constructors
...
Update all utility classes so that they have a private constructor. This
prevents users from accidentally creating an instance, when they should
just use the static methods directly.
Issue gh-8945
2020-08-24 17:33:08 -05:00
ff94944313
Add whitespace after copyright header
...
Add an additional lines after the copyright header and before the
`package` declaration. This aligns with the style used by Spring
Framework.
Issue gh-8945
2020-08-24 17:33:08 -05:00
8d80166aaf
Update exception variable names
...
Consistently use `ex` for caught exception and `cause` for Exception
constructor arguments.
Issue gh-8945
2020-08-24 17:33:08 -05:00
e9130489a6
Remove restricted static imports
...
Replace static imports with class referenced methods. With the exception
of a few well known static imports, checkstyle restricts the static
imports that a class can use. For example, `asList(...)` would be
replaced with `Arrays.asList(...)`.
Issue gh-8945
2020-08-24 17:33:08 -05:00
db55ef4b3b
Migrate to BDD Mockito
...
Migrate Mockito imports to use the BDD variant. This aligns better with
the "given" / "when" / "then" style used in most tests since the "given"
block now uses Mockito `given(...)` calls.
The commit also updates a few tests that were accidentally using
Power Mockito when regular Mockito could be used.
Issue gh-8945
2020-08-24 17:33:08 -05:00
18f3d13363
Fix parenthesis padding issues
...
Fix a few parenthesis padding issues caused by the formatter.
Issue gh-8945
2020-08-24 17:33:08 -05:00
a0b9442265
Use consistent modifier order
...
Update code to use a consistent modifier order that aligns with that
used in the "Java Language specification".
Issue gh-8945
2020-08-24 17:33:07 -05:00
a2f2e9ac8d
Move inner-types so that they are always last
...
Move all inner-types so that they are consistently the last item
defined. This aligns with the style used by Spring Framework and
the consistency generally makes it easier to scan the source.
Issue gh-8945
2020-08-24 17:33:07 -05:00
418c3d6808
Avoid inner assignments
...
Replace code of the form `a = b =c` with distinct statements. Although
this results in more lines of code, they are usually easier to
understand.
Issue gh-8945
2020-08-24 17:33:07 -05:00
9e08b51ed3
Apply code cleanup rules to projects
...
Apply automated cleanup rules to add `@Override` and `@Deprecated`
annotations and to fix class references used with static methods.
Issue gh-8945
2020-08-24 17:33:07 -05:00
8866fa6fb0
Always use 'this.' when accessing fields
...
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.
Issue gh-8945
2020-08-24 17:33:07 -05:00
6894ff5d12
Make classes final where possible
...
Update classes that have private constructors so that they are also
declared final. In a few cases, inner-classes used private constructors
but were subclassed. These have now been changed to have package-private
constructors.
Issue gh-8945
2020-08-24 17:33:07 -05:00
Josh Cummings
Michael
Steve Riesenberg
Marcus Da Coregio
Joe Grandja
Simone Giannino
Dávid Kováč
Khaled Hamlaoui
Rob Winch
bishoy basily
Rujun Chen
Vincent Boulaye
Arnaud Mergey
Steve Riesenberg
Eleftheria Stein
Hans Hosea Schaefer
Craig Andrews
Asian Malaysian Vietnamese
Hassene Laaribi
Benjamin Faal
tristanessquare
Ovidiu Popa
Phillip Webb