5cbc1a47da
Use original query string to verify signature
...
Closes gh-11235
2022-05-23 15:30:07 -06:00
b51c71c3b3
Use original query string to verify signature
...
Closes gh-11235
2022-05-23 13:56:28 -06:00
7f5c31995e
Add relyingPartyRegistrationId to AbstractSaml2AuthenticationRequest
...
Closes gh-11195
2022-05-17 16:41:44 -06:00
9b874bcde2
Add relyingPartyRegistrationId to AbstractSaml2AuthenticationRequest
...
Closes gh-11195
2022-05-17 16:21:54 -06:00
995b2918bb
Remove SAML Deprecations
...
Closes gh-11077
2022-05-06 10:15:42 -03:00
c93c6b928e
Polish Relay State Resolver
...
Issue gh-11065
2022-05-05 17:42:02 -06:00
f7a43e4989
Allow custom relay state
...
Closes gh-11065
2022-05-05 17:42:01 -06:00
13795cdec1
Polish Relay State Resolver
...
Issue gh-11065
2022-05-05 17:28:30 -06:00
4dfc349914
Allow custom relay state
...
Closes gh-11065
2022-05-05 17:26:39 -06:00
3cbb60750d
Add Jackson Support for Saml2AuthenticationException
...
Closes gh-11169
2022-05-02 17:41:52 -05:00
c6038b1ea3
Add Jackson Support for Saml2AuthenticationException
...
Closes gh-11169
2022-05-02 16:24:43 -05:00
cfb1745906
Deprecate Saml2AuthenticationRequestFactory
...
Closes gh-11080
2022-04-08 09:33:41 -03:00
bb0c336ae8
Deprecate Saml2AuthenticationRequestFactory
...
Closes gh-11080
2022-04-08 09:32:03 -03:00
8aa7029d07
Fix checkstyle errors
...
Issue gh-10989
2022-03-18 22:53:29 -05:00
cf29bf996c
Polish InResponseTo support
...
- Moved methods so methods are listed before the methods they call
- Adjusted exception handling so no exceptions are eaten
- Adjusted so that malformed_request_data is returned with request data is malformed
- Refactored methods to have only immutable method parameters
- Removed usage of Stream API
- Moved AuthnRequestUnmarshaller into static block so that only looked
up once
Issue gh-9174
2022-03-15 14:06:58 -06:00
3c878549b5
Add support for validation of InResponseTo
...
Whenever an InResponseTo is present in the SAML2 response and / or any of its assertions, it will be validated against the stored SAML2 request. If the request is missing or the ID of the request does not match the InResponseTo, validation fails. If there is no InResponseTo, no validation of it is done (as opposed to checking whether there is a saved request or not and then failing based on that).
Closes gh-9174
2022-03-15 14:06:57 -06:00
836f203d44
Refactored OpenSaml4AuthenticationProviderTests
...
Factored out repeatedly used code for signing a request.
2022-03-15 14:06:57 -06:00
070514b9dd
Polish InResponseTo support
...
- Moved methods so methods are listed before the methods they call
- Adjusted exception handling so no exceptions are eaten
- Adjusted so that malformed_request_data is returned with request data is malformed
- Refactored methods to have only immutable method parameters
- Removed usage of Stream API
- Moved AuthnRequestUnmarshaller into static block so that only looked
up once
Issue gh-9174
2022-03-15 13:06:32 -06:00
4aa9420047
Add support for validation of InResponseTo
...
Whenever an InResponseTo is present in the SAML2 response and / or any of its assertions, it will be validated against the stored SAML2 request. If the request is missing or the ID of the request does not match the InResponseTo, validation fails. If there is no InResponseTo, no validation of it is done (as opposed to checking whether there is a saved request or not and then failing based on that).
Closes gh-9174
2022-03-15 13:06:32 -06:00
a17cf9e814
Refactored OpenSaml4AuthenticationProviderTests
...
Factored out repeatedly used code for signing a request.
2022-03-15 13:06:31 -06:00
1cbe7a75d3
Add SAML 2.0 Login XML Support
...
Closes gh-9012
2022-03-09 10:40:26 -03:00
73f839312d
Add SAML 2.0 Login XML Support
...
Closes gh-9012
2022-03-09 09:18:01 -03:00
ff87cfce3a
Polish EntityDescriptor Customizer
...
Issue gh-10839
2022-03-04 10:42:04 -07:00
d225205bf2
Add method to customize EntityDescriptor
...
Closes gh-10839
2022-03-04 10:42:04 -07:00
87828df9d5
Polish EntityDescriptor Customizer
...
Issue gh-10839
2022-03-04 10:40:30 -07:00
3602eff1ac
Add method to customize EntityDescriptor
...
Closes gh-10839
2022-03-04 10:40:30 -07:00
304e89041c
Polish Formatting
...
Issue gh-10799
2022-03-02 16:40:13 -07:00
f1a76efc2d
Preserve order of RelyingPartRegistration credentials
...
Issue gh-10799
2022-03-02 16:40:13 -07:00
963251314b
Replace Apache Commons Base64 Decoding
...
Issue gh-10923
2022-03-02 16:40:11 -07:00
ee061f3659
Use RFC2045 Encoding for SAML 2.0 Logout
...
Closes gh-10923
2022-03-02 16:39:31 -07:00
923c61e9d2
Polish Formatting
...
Issue gh-10799
2022-03-02 16:37:58 -07:00
14d0663ae2
Preserve order of RelyingPartRegistration credentials
...
Issue gh-10799
2022-03-02 16:37:58 -07:00
346038d66c
Polish Formatting
...
Issue gh-10799
2022-03-02 16:36:23 -07:00
c734b4b39e
Preserve order of RelyingPartRegistration credentials
...
Issue gh-10799
2022-03-02 16:36:23 -07:00
5b9a45de01
Replace Apache Commons Base64 Decoding
...
Issue gh-10923
2022-03-02 16:30:21 -07:00
0b59e7797d
Use RFC2045 Encoding for SAML 2.0 Logout
...
Closes gh-10923
2022-03-02 16:30:21 -07:00
7a02bd14c1
Replace Apache Commons Base64 Decoding
...
Issue gh-10923
2022-03-02 16:19:03 -07:00
238616da80
Use RFC2045 Encoding for SAML 2.0 Logout
...
Closes gh-10923
2022-03-02 16:18:34 -07:00
4ede1feae5
Polish Saml2 Jackson Support
...
Issue gh-10905
2022-03-01 14:17:17 -07:00
2334610fa9
Add Jackson Support for Saml2 Module
...
Closes gh-10905
2022-03-01 14:17:17 -07:00
6c3d183a94
Polish Saml2 Jackson Support
...
Issue gh-10905
2022-03-01 13:56:02 -07:00
df84826c95
Add Jackson Support for Saml2 Module
...
Closes gh-10905
2022-03-01 12:07:55 -07:00
47871562ca
Change HashSet to LinkedHashSet
...
For various RelyingPartyRegistration.credentials to preserve order of insertion.
Issue gh-10799
2022-02-28 15:02:03 -07:00
6e5bb71466
Change HashSet to LinkedHashSet
...
For various RelyingPartyRegistration.credentials to preserve order of insertion.
Issue gh-10799
2022-02-28 15:01:58 -07:00
70b52a001b
Change HashSet to LinkedHashSet
...
For various RelyingPartyRegistration.credentials to preserve order of insertion.
Issue gh-10799
2022-02-28 14:57:04 -07:00
6dbd88a5a4
Remove WantAssertionsSigned
...
WantAssertionsSigned requires that asserting parties sign the
assertions. This does not reflect how Spring Security actually
behaves, creating behavior mismatches.
Closes gh-10844
2022-02-22 08:14:05 -07:00
3d878549f4
Remove WantAssertionsSigned
...
WantAssertionsSigned requires that asserting parties sign the
assertions. This does not reflect how Spring Security actually
behaves, creating behavior mismatches.
Closes gh-10844
2022-02-18 11:43:25 -07:00
b451ede189
Add Skipping Decryption Error Message
...
Closes gh-10220
2022-02-16 16:43:31 -07:00
c6e5781679
Correct Test
...
Issue gh-10220
2022-02-16 16:43:31 -07:00
5cda362c47
Collect All Validation Errors
...
- OpenSaml4AuthenticationProvider now collects all validation errors
instead of treating some as their own exception
Issue gh-10220
2022-02-16 16:43:31 -07:00
97c18478e5
Add Skipping Decryption Error Message
...
Closes gh-10220
2022-02-16 16:10:36 -07:00
399562b2a8
Correct Test
...
Issue gh-10220
2022-02-16 16:10:36 -07:00
836335dc89
Collect All Validation Errors
...
- OpenSaml4AuthenticationProvider now collects all validation errors
instead of treating some as their own exception
Issue gh-10220
2022-02-16 16:10:19 -07:00
b4dbcd6b2d
Add OpenSamlAssertingPartyDetails
...
Closes gh-10781
2022-02-07 14:43:06 -07:00
541a1e48b3
Add OpenSamlAssertingPartyDetails
...
Closes gh-10781
2022-02-07 14:42:17 -07:00
28747ca89c
Fix Checkstyle Error
...
Issue gh-9696
2022-02-04 20:07:41 -07:00
5c4178beb7
Fix Checkstyle Error
...
Issue gh-9696
2022-02-04 20:07:17 -07:00
e8be907edf
Polish Testing for Custom Attributes Values
...
- Moved construction and management of custom objects
into TestCustomOpenSamlObjects
Issue gh-9696
2022-02-04 20:04:03 -07:00
f626d11c6e
Add OpenSaml custom types to Saml2AuthenticatedPrincipal
...
OpenSaml custom types are added to Saml2AutehnticatedPrincipal as
attributes.
Closes gh-9696
2022-02-04 20:04:03 -07:00
70bb588a25
Polish Testing for Custom Attributes Values
...
- Moved construction and management of custom objects
into TestCustomOpenSamlObjects
Issue gh-9696
2022-02-04 19:57:54 -07:00
3cc7f384e6
Add OpenSaml custom types to Saml2AuthenticatedPrincipal
...
OpenSaml custom types are added to Saml2AutehnticatedPrincipal as
attributes.
Closes gh-9696
2022-02-04 13:41:41 -07:00
965e689461
Add EntitiesDescriptor Support
...
Closes gh-10782
2022-01-31 13:32:12 -07:00
4095d89bb3
Add EntitiesDescriptor Support
...
Closes gh-10782
2022-01-31 13:13:21 -07:00
60eead9ceb
Add Session Index Support
...
Closes gh-10613
2022-01-28 12:21:44 -07:00
b1a905befe
Add Session Index Support
...
Closes gh-10613
2022-01-28 12:14:06 -07:00
df3593f2dd
Deprecate Saml2 AuthnRequest Classes
...
Issue gh-10355
2022-01-24 16:18:33 -07:00
5a2556879a
Add Saml2AuthenticationRequestResolver
...
Closes gh-10355
2022-01-24 16:18:33 -07:00
620081ea9a
Deprecate Saml2 AuthnRequest Classes
...
Issue gh-10355
2022-01-24 15:16:15 -07:00
d538423f98
Add Saml2AuthenticationRequestResolver
...
Closes gh-10355
2022-01-24 15:09:45 -07:00
861368bda5
Make Saml2AuthenticationRequests serializable
...
Closes gh-10550
2022-01-24 09:24:33 -03:00
cca35bdd93
Make Saml2AuthenticationRequests serializable
...
Closes gh-10550
2022-01-24 08:55:26 -03:00
c67ee6f2a8
javax.servlet:javax.servlet-api -> jakarta.servlet:jakarta.servlet-api
...
Issue gh-10501
2022-01-19 15:32:12 -06:00
8f64bb6c8c
javax.servlet:javax.servlet-api -> jakarta.servlet:jakarta.servlet-api
...
Issue gh-10501
2022-01-19 14:33:53 -06:00
20c252982e
Remove SAML 2.0 Logout Default
...
Closes gh-10607
2022-01-14 15:29:50 -07:00
d493598e17
Polish LogoutRequest#EncryptedID Support
...
Issue gh-10663
2022-01-14 14:47:45 -07:00
c1bea329ba
Enabled SAML LogoutRequests with EncryptedID
...
The OpenSamlLogoutRequestValidator validates the subject to be logged out.
Formerly this was done only using the NameID from the OpenSamlLogoutRequest.
Now the EncryptedID is also supported, Since the SAML2 Standard also allows
the EncryptedID as subject identifiers,
- added EncryptedID as valid subject in OpenSamlLogoutRequestValidator
- added test
Closes gh-10663
2022-01-14 14:47:36 -07:00
3c45d46bd7
Polish LogoutRequest#EncryptedID Support
...
Issue gh-10663
2022-01-14 14:44:24 -07:00
700cae8d3b
Enabled SAML LogoutRequests with EncryptedID
...
The OpenSamlLogoutRequestValidator validates the subject to be logged out.
Formerly this was done only using the NameID from the OpenSamlLogoutRequest.
Now the EncryptedID is also supported, Since the SAML2 Standard also allows
the EncryptedID as subject identifiers,
- added EncryptedID as valid subject in OpenSamlLogoutRequestValidator
- added test
Closes gh-10663
2022-01-14 14:44:11 -07:00
c664fbc1a3
Support No SingleLogoutServiceLocation
...
Closes gh-10674
2022-01-03 13:38:47 -07:00
45b7fed884
Remove SAML 2.0 Logout Default
...
Closes gh-10607
2022-01-03 13:14:12 -07:00
cb008fa062
Support No SingleLogoutServiceLocation
...
Closes gh-10674
2022-01-03 13:14:06 -07:00
6b54afe9a3
Remove SAML 2.0 Logout Default
...
Closes gh-10607
2022-01-03 12:54:22 -07:00
b9453da343
Support No SingleLogoutServiceLocation
...
Closes gh-10674
2022-01-03 12:54:18 -07:00
cbf0e1da68
Remove commons-logging from saml2
...
Issue gh-10499
2021-12-16 10:15:58 -07:00
dbe4d704f8
Add SP NameIDFormat Support
...
closes gh-9115
2021-12-01 13:23:30 -07:00
a17dfb8456
Add SP NameIDFormat Support
...
closes gh-9115
2021-12-01 13:02:20 -07:00
db60df2f9c
Update to Spring Framework 6.0
...
Issue gh-10360
2021-11-01 09:02:42 -03:00
010f719344
Upgrade to JDK 17
...
Closes gh-10343
2021-11-01 09:02:42 -03:00
7330ec41e4
Adding keyInfo section to LogoutRequest from RP side
...
Issue gh-10438
2021-10-29 11:00:19 -06:00
04b47c5928
Fixed various broken links in Javadocs
2021-10-21 11:47:04 +02:00
f836897190
Checkstyle Fixes
...
- Javadoc tag ordering
- Private constructors before inner classes
Issue gh-10394
2021-10-18 21:03:35 -05:00
00084cf986
Add saml2.ValidIssuers parameter
...
Adds the saml2.ValidIssuers parameter into SAML 2.0 Assertion Validators
Closes gh-10335
2021-10-14 09:21:43 -06:00
02b2fcc6f0
Restore ManagementConfigurationPlugin
...
Issue gh-9615
2021-10-05 11:23:29 -03:00
d2e5f2ae0d
Update Gradle to 7.2
...
Closes gh-9615
2021-10-04 15:19:40 -03:00
7112ee3eaa
Allow SAML 2.0 loginProcessingURL without registrationId
...
Closes gh-10176
2021-10-04 09:54:40 -03:00
e36e2b2a97
Move Saml2AuthnRequestRepository to web package
...
Moving to solve package tangles
Issue gh-9185
2021-09-29 14:10:39 -03:00
2fb8e66bc8
Saml2WebSsoAuthenticationFilter adds authentication details
...
Closes gh-7722
2021-09-27 11:44:30 -03:00
194993ad1a
Add Saml2ParameterNames
...
Closes gh-10270
2021-09-14 17:40:12 -06:00
c63d618b26
Add Single Logout Support
...
Closes gh-8731
2021-09-13 16:39:48 -06:00
6488295cad
Add RelyingPartyRegistrationResolver
...
Closes gh-9486
2021-09-13 16:39:48 -06:00
f5a525e740
Add Registration to Saml2Authentication
...
Closes gh-9487
2021-09-13 16:39:48 -06:00
822e59af45
useJUnitPlatform for SAML 2.0 Tests
...
Issue gh-9467
2021-09-13 16:39:48 -06:00
1806cebd64
Fix Assertion
...
Closes gh-10055
2021-08-09 10:09:06 -03:00
d5c953b106
Polish Saml2AuthenticationRequestRepository
...
- Moved docs into AuthnRequest section, changed links to be more
semantically valuable to search engines
- Moved tests to be nearer to similar tests
Issue gh-9185
2021-07-27 14:56:23 -06:00
16e17d242e
Add Saml2AuthenticationRequestRepository
...
Closes gh-9185
2021-07-27 14:55:53 -06:00
f73f213f50
Remove DependencySetPlugin
...
Closes gh-10070
2021-07-12 15:31:38 -05:00
3e93b024d6
openrewrite Junit Migration
2021-07-09 14:32:52 -05:00
298068503b
Fix Saml2WebSsoAuthenticationRequestFilter javadoc
2021-06-30 13:41:52 +02:00
03ded987af
Allow Defining Custom SAML Response Validator
...
Add a setter method into OpenSaml4AuthenticationProvider that allows defining a custom ResponseValidator
Closes gh-9721
2021-06-30 08:26:42 -03:00
6474a9e76e
Allow Creating RelyingPartyRegistration from Metadata InputStream
...
Update SAML2 Login reference documentation to reflect the changes
Closes gh-9558
2021-06-30 08:02:24 -03:00
8e0a91d12f
Rebase OpenSamlSigningUtils and Tests
...
Issue gh-9865
2021-06-07 12:38:56 -06:00
adad2da964
Provide KeyInfo in Signature for AuthnRequests
...
Closes gh-9856
2021-06-07 12:38:55 -06:00
1491f2e0b6
Fix saml javadoc
2021-05-17 22:39:34 -05:00
eda38b8f88
opensaml fixes
2021-05-17 15:51:55 -05:00
ef0d933a65
Update SAML JavaDoc to reference specification
...
Closes gh-9510
2021-05-13 10:45:23 -06:00
457c2a2d06
Add Response Status Check
...
Closes gh-9718
2021-05-04 09:45:37 -06:00
8c92eddbe5
Revert "Add Registration to Saml2Authentication"
...
This reverts commit efe42b93ce
2021-04-12 14:44:36 -06:00
55047fd996
Revert "Add RelyingPartyRegistrationResolver"
...
This reverts commit 2f734a0975
2021-04-12 14:44:19 -06:00
37b40476e7
Revert "Add Single Logout Support"
...
This reverts commit e807fae869
2021-04-12 14:44:04 -06:00
7da6077727
Update to commons-codec:1.15
...
Closes gh-9575
2021-04-10 10:11:32 -06:00
e807fae869
Add Single Logout Support
...
Closes gh-8731
2021-04-10 00:25:34 -06:00
2f734a0975
Add RelyingPartyRegistrationResolver
...
Closes gh-9486
2021-04-10 00:12:38 -06:00
efe42b93ce
Add Registration to Saml2Authentication
...
Closes gh-9487
2021-04-10 00:12:38 -06:00
88c1475a3b
Polish OpenSAML 4 support
...
Issue gh-9095
2021-04-10 00:12:15 -06:00
a8a7ab4ffa
Restore spring-security-web Dependency
...
Issue gh-9095
2021-04-09 12:42:04 -06:00
6f79921750
Default to OpenSAML 3
...
- To make upgrade passive
Issue gh-9095
2021-04-06 17:11:33 -06:00
951202e797
Polish SAML 2.0 Artifacts
...
- Produce sources jar
- Produce Javadoc jar
Issue gh-9095
2021-04-06 17:10:53 -06:00
60d3db5798
add management platform(project(":spring-security-dependencies"))
...
Closes gh-9540
2021-04-05 10:36:36 -05:00
de1b3e9d30
Remove DepencencyManagementPlugin
...
Issue gh-9540
2021-04-05 10:36:36 -05:00
0f0e8eded4
Add spring-security-dependencies
...
Issue gh-9540
2021-04-05 10:36:36 -05:00
1a76ee7442
Update Gradle configuration names
...
Closes gh-9540
2021-04-05 10:36:36 -05:00
4b351b1472
Remove SpringSecurityAuthnRequestBuilder
...
- We don't want to have public top-level classes extending or
implementing OpenSAML classes
Issue gh-9095
2021-03-30 11:40:57 -06:00
404e9e153a
Fix Javadoc Errors
...
Closes gh-9530
2021-03-30 11:37:42 -06:00
d0d0a8d958
Add OpenSAML 4 Support
...
Closes gh-9095
2021-03-23 19:07:23 -06:00
a015b8b000
Add Saml2MessageBinding#from
...
Closes gh-9515
2021-03-23 19:07:23 -06:00
4a492846f1
Revert "Lock dependencies for 2.5.0-M3"
...
This reverts commit f05cc6269c
2021-03-15 23:18:45 +01:00
f05cc6269c
Lock dependencies for 2.5.0-M3
2021-03-15 11:00:19 +01:00
c860076ef5
Fix Saml2MetadataFilter Test
...
Issue gh-9281
2021-03-02 16:32:17 -07:00
f3fa8e8800
Polish
...
Issue gh-9310
2021-03-02 12:04:22 -07:00
6e41246a2b
Throw Saml2AuthenticationException
...
Closes gh-9310
2021-03-02 12:04:22 -07:00
3e8ad4bc2b
Polish Test
...
Issue gh-9281
2021-03-02 08:24:34 -07:00
c0fa3f906d
Encode the Content-Disposition header following RFC 8187
...
Closes gh-9281
2021-03-02 08:24:34 -07:00
fb391c5dcd
Add setMetadataFilename method to Saml2MetadataFilter
...
Closes gh-9317
2021-03-02 08:24:34 -07:00
c4be1c6a56
Revert "Lock Dependencies"
...
This reverts commit a85caa4098
2021-02-11 15:49:59 -07:00
a85caa4098
Lock Dependencies
2021-02-11 15:00:38 -07:00
76229cfab7
Migrate SAML 2.0 Tests and Docs to PCFOne
...
Issue gh-9362
2021-01-22 15:14:03 -07:00
7dde7cffda
Add Status Check
...
Closes gh-8955
2021-01-05 17:32:47 -07:00
b95e1aa209
Revert "Lock dependencies for 5.5.0-M1"
...
This reverts commit 25a7482c8c
2020-11-03 19:53:28 -05:00
aba0e904f0
Read SigningMethod Elements
...
Closes gh-9177
2020-11-02 11:27:23 -07:00
e1826a0bd8
Polish Signature Algorithm Support
...
- Changed name to signatureAlgorithms since method and algorithm are
synonymous
- Re-ordered methods to follow typical IDPSSODescriptor order
- Adjusted JavaDoc to refer to IDPSSODescriptor terminology
Issue gh-8952
2020-11-02 11:27:23 -07:00
9900658c92
support configurable signature algorithm
...
Closes gh-8952
2020-11-02 11:27:23 -07:00
25a7482c8c
Lock dependencies for 5.5.0-M1
2020-10-30 17:52:03 -05:00
5699670a43
Polish OpenSamlAuthenticationProvider
...
Remove deprecated usage
Issue gh-8769
2020-10-14 16:49:37 -06:00
c8cbf06d8d
Add EncryptedAttribute support
...
Closes gh-9131
2020-10-14 14:58:42 -06:00
d0581c9a26
Polish Configurable SAML Decryption Support
...
- Renamed to setResponseElementsDecrypter and
setAssertionElementsDecrypter to align with ResponseToken and
AssertionToken
- Changed contract of setAssertionElementsDecrypter to use
AssertionToken
- Changed assertions in unit test to use isEqualTo
Issue gh-9044
2020-10-14 14:58:42 -06:00
535ae3e27d
Add Configurable SAML Response Decryption
...
Closes gh-9044
2020-10-14 10:38:05 -06:00
e6ff57c116
Polish RelyingPartyRegistrations
...
Issue gh-9028
2020-10-12 13:55:16 -06:00
9a11cc84ad
Add File-based Metadata Resolution
...
Closes gh-9028
2020-10-12 13:55:16 -06:00
bdfd6f9f92
Remove Unused Code
...
Issue gh-8887
2020-09-28 13:07:48 -06:00
bcfbd2dee5
Remove Unused Code
...
Issue gh-8877
2020-09-26 09:06:28 -06:00
a36baffb3a
Polish OpenSamlAuthenticationRequestFactory
...
- Refactored to use SAMLMetadataSignatureSigningParametersResolver
Issue gh-7758
2020-09-26 09:06:24 -06:00
2ee455b7bf
Add EntitiesDescriptor Support
...
Closes gh-9051
2020-09-25 16:23:18 -06:00
20baa7d409
Replace ExpectedException @Rules with AssertJ
...
Replace JUnit ExpectedException @Rules with AssertJ calls.
2020-09-22 16:13:51 -06:00
910b81928f
Replace try/catch with AssertJ
...
Replace manual try/catch/fail blocks with AssertJ calls.
2020-09-22 16:13:51 -06:00
7b1f574769
Revert "Lock Dependency Versions for 5.4.0"
...
This reverts commit 3d0e459182
2020-09-09 18:14:12 -04:00
3d0e459182
Lock Dependency Versions for 5.4.0
2020-09-09 13:45:03 -04:00
2abf59b695
Merge Formatting Changes
...
Issue gh-8945
2020-08-24 17:33:23 -05:00
319d3364aa
Migrate to assertThatExceptionOfType
...
Consistently use `assertThatExceptionOfType(...).isThrownBy(...)`
rather than `assertThatCode` or `assertThatThrownBy`. This aligns with
Spring Boot and Spring Cloud. It also allows the convenience
`assertThatIllegalArgument` and `assertThatIllegalState` methods to
be used.
Issue gh-8945
2020-08-24 17:33:09 -05:00
a5aa6b3d7f
Remove blank lines from all tests
...
Remove all blank lines from test code so that test methods are
visually grouped together. This generally helps to make the test
classes easer to scan, however, the "given" / "when" / "then"
blocks used by some tests are now not as easy to discern.
Issue gh-8945
2020-08-24 17:33:09 -05:00
1f03608b73
Polish spring-security-saml2 main code
...
Manually polish `spring-security-saml2` following the formatting
and checkstyle fixes.
Issue gh-8945
2020-08-24 17:33:09 -05:00
834dcf5bcf
Use consistent ternary expression style
...
Update all ternary expressions so that the condition is always in
parentheses and "not equals" is used in the test. This helps to bring
consistency across the codebase which makes ternary expression easier
to scan.
For example: `a = (a != null) ? a : b`
Issue gh-8945
2020-08-24 17:33:08 -05:00
8d3f039f76
Reduce method visibility when possible
...
Reduce method visibility for package private classes when possible.
In the case of abstract classes that will eventually be made public,
the class has been made public and a package-private constructor has
been added.
Issue gh-8945
2020-08-24 17:33:08 -05:00
52f20b5281
Use parenthesis with single-arg lambdas
...
Use regular expression search/replace to ensure all single-arg
lambdas have parenthesis. This aligns with the style used in Spring
Boot and ensure that single-arg and multi-arg lambdas are consistent.
Issue gh-8945
2020-08-24 17:33:08 -05:00
01d90c9881
Hide utility class constructors
...
Update all utility classes so that they have a private constructor. This
prevents users from accidentally creating an instance, when they should
just use the static methods directly.
Issue gh-8945
2020-08-24 17:33:08 -05:00
ff94944313
Add whitespace after copyright header
...
Add an additional lines after the copyright header and before the
`package` declaration. This aligns with the style used by Spring
Framework.
Issue gh-8945
2020-08-24 17:33:08 -05:00
8d80166aaf
Update exception variable names
...
Consistently use `ex` for caught exception and `cause` for Exception
constructor arguments.
Issue gh-8945
2020-08-24 17:33:08 -05:00
e9130489a6
Remove restricted static imports
...
Replace static imports with class referenced methods. With the exception
of a few well known static imports, checkstyle restricts the static
imports that a class can use. For example, `asList(...)` would be
replaced with `Arrays.asList(...)`.
Issue gh-8945
2020-08-24 17:33:08 -05:00
db55ef4b3b
Migrate to BDD Mockito
...
Migrate Mockito imports to use the BDD variant. This aligns better with
the "given" / "when" / "then" style used in most tests since the "given"
block now uses Mockito `given(...)` calls.
The commit also updates a few tests that were accidentally using
Power Mockito when regular Mockito could be used.
Issue gh-8945
2020-08-24 17:33:08 -05:00
81fe9fc640
Make all exception classes immutable
...
Update all exception classes so that they are fully immutable and cannot
be changed once they have been thrown.
Issue gh-8945
2020-08-24 17:33:07 -05:00
a0b9442265
Use consistent modifier order
...
Update code to use a consistent modifier order that aligns with that
used in the "Java Language specification".
Issue gh-8945
2020-08-24 17:33:07 -05:00
a2f2e9ac8d
Move inner-types so that they are always last
...
Move all inner-types so that they are consistently the last item
defined. This aligns with the style used by Spring Framework and
the consistency generally makes it easier to scan the source.
Issue gh-8945
2020-08-24 17:33:07 -05:00
9e08b51ed3
Apply code cleanup rules to projects
...
Apply automated cleanup rules to add `@Override` and `@Deprecated`
annotations and to fix class references used with static methods.
Issue gh-8945
2020-08-24 17:33:07 -05:00
8866fa6fb0
Always use 'this.' when accessing fields
...
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.
Issue gh-8945
2020-08-24 17:33:07 -05:00
6894ff5d12
Make classes final where possible
...
Update classes that have private constructors so that they are also
declared final. In a few cases, inner-classes used private constructors
but were subclassed. These have now been changed to have package-private
constructors.
Issue gh-8945
2020-08-24 17:33:07 -05:00
37fa94fafc
Organize imports
...
Use "organize imports" from Eclipse to cleanup import statements so
that they appear in a consistent and well defined order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
5f64f53c3f
Use consistent "@" tag order in Javadoc
...
Ensure that Javadoc "@" tags appear in a consistent and well defined
order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
b7fc18262d
Reformat code using spring-javaformat
...
Run `./gradlew format` to reformat all java files.
Issue gh-8945
2020-08-24 17:32:56 -05:00
21e9a410ee
Remove Package Tangle
...
Issue gh-8876
2020-08-19 15:52:20 -06:00
af5c55c380
Polish AuthnRequest Customization Support
...
Having the application generate the AuthnRequest fresh allows Spring
Security to back away more gracefully. Using a Consumer implies that
the application will need to undo any values that Spring Security set
that the application doesn't want.
Also, if this does become a configuration burden, it can be simplified
in a separate ticket by exposing the default Converter.
Issue gh-8776
2020-08-19 14:27:31 -06:00
3694485056
Polish SAML 2.0 Default Assertion Validator
...
In several cases, taking a pre-set ValidationContext is not sufficient.
For example, the recipient is calculated via the
RelyingPartyRegistration that's currently in the context of the
request.
Instead, then, createDefaultAssertionValidator was broken up into two
different methods: One that takes no parameters and assumes the class's
default ValidationContext, and another that takes a converter to derive
the ValidationContext from the incoming authentication token.
Issue gh-8970
2020-08-19 13:58:42 -06:00
da7477cd41
Add Response to Authentication Conversion Support
...
Closes gh-8010
2020-08-18 17:49:34 -06:00
0c696dd58b
Remove XSAnyMarshaller AttributeValue Support
...
In favor of customizing the authentication converter
Closes gh-8864
2020-08-18 17:42:04 -06:00
7b3dda161b
Generalize SAML 2.0 Assertion Validation Support
...
Closes gh-8970
2020-08-18 12:23:42 -06:00
27ac046d8a
Rename *Test.java -> *Tests.java
...
Rename a few test classes that accidentally ended in `Test` instead of
`Tests`.
Issue gh-8945
2020-08-10 16:24:44 -05:00
1d74d556c2
Revert "Lock Dependency Versions for 5.4.0-RC1"
...
This reverts commit f3a1e5d40c
2020-08-05 14:59:11 -04:00
f3a1e5d40c
Lock Dependency Versions for 5.4.0-RC1
2020-08-05 13:46:11 -04:00
a701555318
Polish Saml2AuthenticationTokenConverter
...
Issue gh-8768
2020-08-05 10:08:47 -06:00
f82190b414
Add RelyingPartyRegistrations
...
Closes gh-8484
2020-08-05 10:08:47 -06:00
506786f46e
Replaced Spaces with Tabs
...
Updated the .gradle file for SAML 2.0 Service Provider to use tabs
2020-08-05 10:08:47 -06:00
b999faa5a0
Complete SAML 2.0 SP Metadata Endpoint
...
Closes gh-8693
2020-08-05 10:08:47 -06:00
Josh Cummings
Ulrich Grave
Marcus Da Coregio
sebastiano
Steve Riesenberg
Elias Lousseief
Sander van Schouwenburg
Filip Hanik
pelesic
Rob Winch
Robert Stoiber
Arnaud Mergey
Vladimir Surcov
Emil Sierżęga
Daniel Garnier-Moiroux
Russell Allen
Eleftheria Stein
Han YanJing
Joe Grandja
ryan.cassar
Phillip Webb