Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reverts Ember.String.prototype.w monkey patching causing exception 

The git blame of the commit is unclear on the reasons leading to this, and how to reproduce a failure.
This commit is contained in:
Joffrey JAFFEUX 2019-01-09 20:58:14 +01:00
parent 0520d57862
commit 00789666d7
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
assets/javascripts/discourse/components/google-dfp-ad.js.es6
View File

@ -371,8 +371,6 @@ export default Ember.Component.extend({
return; return;
} }
const ember_w_function = String.prototype.w;
String.prototype.w = null;
var self = this; var self = this;
loadGoogle(this.siteSettings) loadGoogle(this.siteSettings)
.then(function() { .then(function() {
@ -395,9 +393,6 @@ export default Ember.Component.extend({
window.googletag.pubads().refresh([slot.ad]); window.googletag.pubads().refresh([slot.ad]);
} }
}); });
})
.finally(function() {
String.prototype.w = ember_w_function;
}); });
}.on("didInsertElement"), }.on("didInsertElement"),