Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

key working, value not working

This commit is contained in:
Sarah Ni 2015-08-26 15:35:30 +10:00
parent 67d3504296
commit 010d11f969
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
assets/javascripts/discourse/components/google-dfp-ad.js.es6
View File

@ -17,7 +17,16 @@ function splitHeightInt(value) {
return str.trim();
}
// This creates an array for the values of the custom targeting key
function valueParse(value) {
var final = value.replace(/ /g,'');
final = final.replace(/['"]+/g, '');
final = final.split(',');
return final;
}
//PageTracker.current().on('change', function(url) {
function loadGoogle(settings) {
if (_loaded) {
@ -47,8 +56,11 @@ function loadGoogle(settings) {
}
else {
googletag.defineSlot('/' + settings.dfp_publisher_id + '/' + settings.dfp_topic_list_top_code, [parseInt(splitWidthInt(settings.topic_list_top_ad_sizes)), parseInt(splitHeightInt(settings.topic_list_top_ad_sizes))], 'div-gpt-ad-topic-list-top')
.setTargeting(settings.dfp_target_topic_list_top_key_code, [settings.dfp_target_topic_list_top_value_code])
.setTargeting(settings.dfp_target_topic_list_top_key_code, valueParse(settings.dfp_target_topic_list_top_value_code))
// This hardcoded code works: .setTargeting('category', ["clothes", "handbags", "makeup"])
.addService(googletag.pubads());
console.log(typeof(valueParse(settings.dfp_target_topic_list_top_value_code)));
}
}
if (settings.dfp_topic_above_post_stream_code && !settings.dfp_show_topic_above_post_stream && settings.topic_above_post_stream_ad_sizes) {