Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added working custom targeting to topic list top for one key and one value

This commit is contained in:
Sarah Ni 2015-08-26 12:04:03 +10:00
parent 50ee40cdfe
commit 67d3504296
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
assets/javascripts/discourse/components/google-dfp-ad.js.es6
View File

@ -17,6 +17,7 @@ function splitHeightInt(value) {
return str.trim(); return str.trim();
} }
//PageTracker.current().on('change', function(url) { //PageTracker.current().on('change', function(url) {
function loadGoogle(settings) { function loadGoogle(settings) {
if (_loaded) { if (_loaded) {
@ -45,7 +46,9 @@ function loadGoogle(settings) {
googletag.defineSlot(settings.dfp_topic_list_top_code, [320,50], 'div-gpt-ad-topic-list-top').addService(googletag.pubads()); googletag.defineSlot(settings.dfp_topic_list_top_code, [320,50], 'div-gpt-ad-topic-list-top').addService(googletag.pubads());
} }
else { else {
googletag.defineSlot('/' + settings.dfp_publisher_id + '/' + settings.dfp_topic_list_top_code, [parseInt(splitWidthInt(settings.topic_list_top_ad_sizes)), parseInt(splitHeightInt(settings.topic_list_top_ad_sizes))], 'div-gpt-ad-topic-list-top').addService(googletag.pubads()); googletag.defineSlot('/' + settings.dfp_publisher_id + '/' + settings.dfp_topic_list_top_code, [parseInt(splitWidthInt(settings.topic_list_top_ad_sizes)), parseInt(splitHeightInt(settings.topic_list_top_ad_sizes))], 'div-gpt-ad-topic-list-top')
.setTargeting(settings.dfp_target_topic_list_top_key_code, [settings.dfp_target_topic_list_top_value_code])
.addService(googletag.pubads());
} }
} }
if (settings.dfp_topic_above_post_stream_code && !settings.dfp_show_topic_above_post_stream && settings.topic_above_post_stream_ad_sizes) { if (settings.dfp_topic_above_post_stream_code && !settings.dfp_show_topic_above_post_stream && settings.topic_above_post_stream_ad_sizes) {

3
config/locales/server.en.yml
View File

@ -4,7 +4,8 @@ en:
dfp_show_topic_list_top: "Disable topic_list_top ad" dfp_show_topic_list_top: "Disable topic_list_top ad"
dfp_topic_list_top_code: "Show leaderboard ad above topic lists." dfp_topic_list_top_code: "Show leaderboard ad above topic lists."
topic_list_top_ad_sizes: "Choose your ad size" topic_list_top_ad_sizes: "Choose your ad size"
dfp_topic_list_top_custom_targeting_code: "Add your custom targeting code - see instructions" dfp_target_topic_list_top_key_code: "Input key values - Inventory Level"
dfp_target_topic_list_top_value_code: "Input key values - Inventory Level"
dfp_show_topic_above_post_stream: "Disable topic_above_post_stream ad" dfp_show_topic_above_post_stream: "Disable topic_above_post_stream ad"
dfp_topic_above_post_stream_code: "Show leaderboard ad above post stream" dfp_topic_above_post_stream_code: "Show leaderboard ad above post stream"
topic_above_post_stream_ad_sizes: "Choose your ad size" topic_above_post_stream_ad_sizes: "Choose your ad size"

6
config/settings.yml
View File

@ -112,6 +112,12 @@ ad_plugin:
- 180*150 - small rectangle - 180*150 - small rectangle
- 200*200 - small square - 200*200 - small square
- 250*250 - square - 250*250 - square
dfp_target_topic_list_top_key_code:
client: true
default: ''
dfp_target_topic_list_top_value_code:
client: true
default: ''
dfp_show_topic_list_top: dfp_show_topic_list_top:
client: true client: true
default: false default: false