Neil Lalonde
333f6cef81
FEATURE: support multiple ad sizes in AdSense and Ad Manager
...
Each ad placement in the AdSense and Ad Manager settings takes a list
of ad sizes instead of only one size. If given multiple sizes, the sizes
will alternate in order for each ad that's rendered.
2019-07-08 15:10:25 -04:00
Neil Lalonde
ad939a851a
FEATURE: option to disable ads on personal messages
...
Use the new setting "no ads for personal messages".
2019-06-27 14:13:51 -04:00
Neil Lalonde
2ba276b0fb
FIX: DFP ad units being refreshed multiple times on the same render
...
Ember is firing events multiple times when the ad component is shown.
Only solution I can find is to add a delay between calls to refresh
the ad unit. I chose 3 seconds.
2019-06-26 11:15:04 -04:00
Brahn Partridge
89200f3b99
try io instead of app to maybe workaround CORs problem
2019-06-24 09:59:58 -04:00
Neil Lalonde
3054f2539a
FEATURE: use a different Ad Manager publisher ID for mobile
...
If you want to use one Ad Manager publisher on desktop and a different
one on mobile, use the new dfp_publisher_id_mobile setting.
By default, dfp_publisher_id will be used for both desktop and mobile.
2019-06-19 11:52:23 -04:00
Neil Lalonde
25090a55a1
prettier
2019-06-17 21:00:05 -04:00
Neil Lalonde
92609c7af4
FIX: no_ads_for_tags support for hidden tags
...
Hidden tags aren't sent to the client, so they couldn't be used to
disable ads on topic pages. Do this calculation on the server.
Topic list pages for tags can continue to check on the client because
non-staff get a 404 error when trying to view a hidden tag's topic list.
2019-06-17 17:20:38 -04:00
Arpit Jalan
d34b45627e
Fix the build.
2019-06-15 16:01:52 +05:30
Neil Lalonde
31efc7025d
FEATURE: new setting to disable ads based on tags
...
Enter a list of tags in the new setting no_ads_for_tags to prevent
ads from being rendered on topics with one or more of those tags,
and on topic list pages for those tags.
2019-06-14 14:44:09 -04:00
Penar Musaraj
574500ba08
Run Prettier
2019-06-14 13:24:55 -04:00
Penar Musaraj
203e14b639
Fix eslint warnings
2019-06-14 12:10:11 -04:00
Neil Lalonde
3a04f95916
REFACTOR: some changes to be closer to example implementation
...
https://support.google.com/admanager/answer/4578089?hl=en
* unique div ID for every ad slot
* setTargeting before calling addService
* don't destroySlots async (no examples of correct way to use this...)
2019-06-10 15:43:48 -04:00
Neil Lalonde
04525d0cf1
FIX: dfp category targeting params
...
DFP category targeting param wasn't always being updated on topic
list pages.
Also remove dependency on a category param being passed in to the
component from a template so that we can now place dfp ads
in places that don't have access to the current category and
targeting will still work.
2019-06-05 17:00:47 -04:00
Neil Lalonde
7af8f1d46b
FEATURE: new setting to disable ads based on category of current page
...
Use the "no ads for categories" setting to define which category pages
(topic list and topics) should not render any ads.
2019-06-05 16:00:24 -04:00
Neil Lalonde
896e5a9838
Prettier
2019-05-08 11:22:21 -04:00
Neil Lalonde
365f441924
FIX: groups with mixed case names not working
2019-05-08 11:01:01 -04:00
Neil Lalonde
4bd2035866
FEATURE: house ads can be configured to alternate with other ads
...
Use the new "house ads frequency" site setting to configure how often
house ads should show, as a percentage. This only applies in ad
placements where other ad networks are configured to appear.
2019-05-07 19:52:51 -04:00
Neil Lalonde
cdc14398ba
FIX: linking to house ads URLs shows not found error page
2019-05-07 14:32:32 -04:00
Neil Lalonde
d9d7f4c8f4
FIX: house ads randomized instead of showing evenly
2019-05-03 16:04:04 -04:00
Neil Lalonde
26d42e9ed7
Fix compatibility with other js tests
2019-05-03 13:26:16 -04:00
Neil Lalonde
1bd80e1afe
FEATURE: House Ads
...
Allows creating ads within Discourse admin at Plugins > House Ads.
Write the ads in html and style them with CSS in themes.
2019-05-03 11:39:34 -04:00
Neil Lalonde
5272995e74
FEATURE: use groups to control who sees ads
2019-05-03 11:39:34 -04:00
Neil Lalonde
369d5dfc9e
oops revert again "FEATURE: use groups to control who sees ads" and all later"
2019-04-17 16:02:19 -04:00
Neil Lalonde
e6bcd96d8e
FEATURE: use groups to control who sees ads" and all later
2019-04-17 15:40:50 -04:00
Neil Lalonde
50d258dc37
Revert "FEATURE: use groups to control who sees ads" and all later
...
Revert "Updates to codefund-ad"
Revert "Updates to carbonads-ad"
Revert "Updates to amazon-product-links"
2019-04-17 15:37:09 -04:00
Neil Lalonde
63e604d81b
Updates to codefund-ad
2019-04-17 11:36:50 -04:00
Neil Lalonde
8ef02aa351
Updates to carbonads-ad
2019-04-17 11:36:50 -04:00
Neil Lalonde
881a8e5d4c
Updates to amazon-product-links
2019-04-17 11:36:50 -04:00
Neil Lalonde
4fd7caffd6
FEATURE: use groups to control who sees ads
...
A new setting has been added in Admin > Settings > Ad Plugin called
"no ads for groups". Add group names to this list. If a user belongs
to any of the groups, they will not see any ads. This is an alternative
to using trust level settings like "adsense through trust level".
2019-04-17 11:36:50 -04:00
Neil Lalonde
6097e6f097
Clean-up codefund-ad component
2019-04-17 11:36:50 -04:00
Neil Lalonde
943acbfeb1
Add some js tests, and update adsense js
2019-04-17 11:36:47 -04:00
Diego Barreiro
147b1350ea
FIX: Switch Property to Computed
2019-04-15 11:54:18 -04:00
Diego Barreiro
23ece34f53
FIX: Switch Var to Const
2019-04-15 11:54:18 -04:00
Diego Barreiro
c5272db7f3
UX: Init Carbon Ads
2019-04-15 11:54:18 -04:00
Neil Lalonde
ec10ef4483
FIX: wrong size setting being used for post-bottom desktop
2019-03-20 11:22:47 -04:00
Neil Lalonde
9b7a8830b8
FIX: resizing of ad units when they're rendered
2019-02-25 09:53:28 -05:00
Neil Lalonde
9a695cc67d
refactor google-dfp-ad component to reduce repetition
2019-02-22 11:15:40 -05:00
Nathan Hopkins
de0a47c1a7
Update CodeFund Ads to use new CodeFund API ( #1 )
...
Update CodeFund plugin to work with CodeFund's new API
2019-01-30 13:51:22 -05:00
Joffrey JAFFEUX
00789666d7
Reverts Ember.String.prototype.w monkey patching causing exception
...
The git blame of the commit is unclear on the reasons leading to this, and how to reproduce a failure.
2019-01-09 20:58:14 +01:00
David Taylor
2e36e2c656
DEV: Apply prettier
2018-10-22 19:49:32 +01:00
Eric Berry
014ee3187b
Ensure CodeFund request is only made if the Property ID is provided
...
Also updated README with CodeFund instructions and link
2018-06-22 14:41:59 -06:00
Eric Berry
9e84a89f76
Refactors per review
2018-06-20 09:15:15 -06:00
Eric Berry
1b7f642da6
Cleanup
2018-06-12 15:21:23 -06:00
Eric Berry
11a621fd50
Only display ad if content exists
2018-06-07 17:49:15 -06:00
Eric Berry
75439b5af3
Cleaned up debugs
2018-06-07 17:28:20 -06:00
Eric Berry
1cd33da722
Add CodeFund
2018-06-07 17:17:19 -06:00
Neil Lalonde
a23386cd17
FIX: DFP ad units not refreshed when navigating between topic lists
2018-06-04 16:52:43 -04:00
Jeff Wong
136cceb1e3
FIX: resolve collision on ember's builtin w string function
2018-05-16 13:37:50 -07:00
Neil Lalonde
1abeea6ff2
FIX: Amazon amazon_mobile_topic_above_suggested_src_code setting did not work
2018-02-15 14:32:10 -05:00
Neil Lalonde
cf77b9fdc5
The ADVERTISEMENT label can be translated and customized from admin
2018-01-08 13:54:21 -05:00