Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
511 Commits 7 Branches 0 Tags 2.3 MiB
Commit Graph

211 Commits

Author SHA1 Message Date
Isaac Janzen 743478d593
DEV: Use angle bracket syntax (#172) 2023-05-26 09:20:47 -05:00
Kris 58205cc9ac
UX: introduce min-height for responsive ads (#170) 2023-04-25 16:19:48 -04:00
Osama Sayegh c2057a5056
FEATURE: Add per-ad visibility settings for anons and logged-in users (#168) 
This commit adds 2 new settings to house ads to control whether an ad is shown to anonymous users and logged in users. Existing ads that were created before this feature will default to true for both settings; i.e., they will remain to be visible to both anonymous and logged-in users, but it will be possible to change the settings. Turning off both settings will effectively disable the ad completely.
 2023-04-07 17:56:22 +03:00
David Taylor c519b4bc92
DEV: Update eslint-config-discourse, use prettier for hbs (#163) 2023-01-04 13:34:08 +01:00
Penar Musaraj fa2ec23ebc
DEV: Use `popupAjaxError` instead of bootbox (#153) 2022-10-18 13:58:55 -04:00
Roman Rizzi 4940d0ea19
FIX: Ensure we won't render the connector if there are no ads (#148) 2022-07-14 15:58:29 -03:00
Roman Rizzi d9b739f803
FIX: Don't render the connector when we shouldn't display an ad in the topic list item. (#146) 
We expose the ad-slot logic to determine which ads are potentially available for each slot and don't render the connector when there are none. Leaking the component logic is not ideal, but I don't see a better solution given the
current design.
 2022-07-12 16:13:18 -03:00
Arpit Jalan 5901a52dbc
FEATURE: support placing ads between topic list for house ads (#143) 
* init

* more

* Pass td and colspan to component

* various fixes for house ads between n topics and add a test

* Make adComponents condition easier to read

Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
Co-authored-by: romanrizzi <rizziromanalejandro@gmail.com>
 2022-07-07 08:53:29 -03:00
Isaac Janzen fb73dda584
DEV: Remove 'htmlSafe' string prototype extensions (#140) 
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
 2022-06-01 11:37:01 -05:00
Jarek Radosz 7e2a490b67
DEV: Fix imports (#132) 2022-03-06 19:52:19 +01:00
Jarek Radosz c788b7bf1f
DEV: Lose the es6 suffix (#131) 2022-03-05 17:23:41 +01:00
Andrei Prigorshnev 62a4eff705
DEV: migrate routes to the new @action pattern (#126) 2022-01-06 15:16:37 +04:00
Martin Brennan 55045bba3c
DEV: Update code for eslint object-shorthand-rule. See 4f7aba06c0 (#119) 2021-11-10 11:58:31 +11:00
tshenry f2171a51c3
FIX: use imports instead of Discourse global (#118) 
Replaces `Discourse.Site` with the imported equivalent and `Discourse.SiteSettings` with `this.siteSettings`
 2021-09-21 11:27:10 -07:00
Penar Musaraj 190aa503ce
DEV: SCSS cleanup 2021-06-23 21:59:53 -04:00
Penar Musaraj c25c041f98
DEV: Remove SCSS color vars fallbacks (#112) 2021-05-12 16:16:40 -04:00
Jarek Radosz a16ed5f0bf UX: Add title to iframe elements 
Fixes template linting errors
 2021-02-09 20:03:39 +01:00
Joffrey JAFFEUX 6438000ed4
DEV: prettier 2.2.1 (#101) 2021-01-27 10:36:36 +01:00
jjaffeux 9adaef17cc Revert "DEV: enforces no-var (#94)" 
This reverts commit 9ad0133624.
 2020-10-13 15:42:21 +02:00
Joffrey JAFFEUX 9ad0133624
DEV: enforces no-var (#94) 2020-10-13 11:40:33 +02:00
Joffrey JAFFEUX 15b2c1a05e
REFACTOR: loadGoogle doesn't take any argument (#92) 2020-09-23 15:05:23 +02:00
Joffrey JAFFEUX 30dad0281d
DEV: apply coding standards (#91) 2020-09-04 13:24:14 +02:00
jjaffeux 5afca0aaa1 linting 2020-08-21 16:48:41 +02:00
Lawrence Thorpe 8439608f17
FIX: isFluid parameter for in-feed adsense units (#90) 
Fixes issue in #89
 2020-08-21 10:24:12 -04:00
Lawrence Thorpe 50788a876e
Add support for adsense fluid format for in-feed (#89) 2020-08-21 09:53:34 -04:00
Joffrey JAFFEUX 914735767a
FIX: re-revert db4f5f99 with updated tests (#88) 
The tests were using an incorrect value for the site setting (the name of the group instead of the id).

`no_ads_for_groups` shows groups names in the UI byt actually stores IDs.
 2020-08-04 08:03:22 +02:00
Penar Musaraj db4f5f990d
Revert "FIX: removes part of the 2.4 legacy code forgotten (#87)" 
This reverts commit c27d5f8e85.
 2020-08-03 21:44:10 -04:00
Joffrey JAFFEUX c27d5f8e85
FIX: removes part of the 2.4 legacy code forgotten (#87) 
no_ads_for_groups returns a list of ids
 2020-08-03 21:01:51 +02:00
Penar Musaraj 1d073e2a96
DEV: Use CSS custom properties for colors in SCSS 
Prepares the plugin for an upcoming change in core while maintaining
backwards compatiblity.
 2020-08-03 13:11:20 -04:00
jjaffeux 0a23be6008 DEV: uses html-safe instead of triple curly brackets 2020-08-01 17:48:23 +02:00
Bianca Nenciu 3fc872520e
FIX: CodeFund is shutting down (#85) 2020-07-10 18:09:32 +03:00
Robin Ward 3d0ee3f28a FIX: Prettier 2020-06-25 15:50:21 -04:00
Robin Ward 05967a8d52 FIX: Plugin was broken in stable 2020-06-25 14:51:14 -04:00
Rafael dos Santos Silva 4ded0bdba9
DEV: Fix usage of deprecated global 2020-06-04 17:30:26 -03:00
Robin Ward 5b99fd5bbd DEV: Discourse.Route has been deprecated 2020-05-12 13:58:12 -04:00
Joffrey JAFFEUX 270799166b
REFACTOR: applies discourse core coding practices (#82) 2020-03-23 09:40:29 +01:00
Neil Lalonde cd82a905ae
Load Google Ad Manager code from doubleclick.net 
https://support.google.com/admanager/answer/1638622?hl=en
 2020-03-13 14:24:54 -04:00
jjaffeux af346fc1c2 FIX: makes houses hads work with sk2 2020-02-07 10:34:58 +01:00
Gerhard Schlager 275921ac70
Make prettier happy 2020-01-16 00:12:27 +01:00
Neil Lalonde 116f9dd238 FEATURE: add support for fluid ad size in Google Ad Manager 
No width or height will be set on containers when ad size is fluid.
 2020-01-15 16:52:02 -05:00
David Taylor cf27a7be64 DEV: Stop loading external scripts while running tests (#81) 
* DEV: Stop loading external scripts while running tests

* Revert "Turn of CSP for tests"

This reverts commit db1bf99277. It had no effect, since CSP is set by the server, and this was only affecting the client
 2020-01-06 10:01:40 -07:00
Penar Musaraj 155d9f904c Import Promise from RSVP 2019-11-22 11:04:36 -05:00
Penar Musaraj b59f841944 DEV: Respect radix rule in eslint-config-discourse 1.0.6 2019-11-18 10:07:55 -05:00
Neil Lalonde 8d4df6df91 Rename house ad routes so ad blockers don't detect them 
adplugin, house_ads, house_ad_settings become
pluginad, house_creatives, and house_settings.
 2019-10-08 17:41:13 -04:00
Neil Lalonde edc549b269 UX: remove left padding of ads between posts on narrow width browsers 2019-09-17 11:27:01 -04:00
Sam Saffron 02f9145751 lint file 
AdButler is not a whitelisted constant, access it via window.
 2019-09-17 13:46:32 +10:00
Neil Lalonde 51c1b89a62 Prettier 2019-09-16 14:35:58 -04:00
discoursehosting 19f0457e8c AdButler support (#80) 2019-09-16 14:26:17 -04:00
Neil Lalonde 62888e734f FIX: handle no ad size given for AdSense and DFP ad units 
For AdSense, assume responsive size.
For DFP, don't attempt to render the ad unit.
 2019-09-10 17:07:47 -04:00
Neil Lalonde 2ad24e4a60 FEATURE: add option to disable ads in restricted categories 
Use the new setting "no ads for restricted categories".
 2019-07-22 11:43:39 -04:00