7 Commits

Author SHA1 Message Date
David Taylor
c88bb59d81
FIX: Fully re-render ads when navigating between pages ()
In the past, the ad plugin relied on two side-effects to achieve this behaviour:

1. Components being fully destroyed/rendered when navigating between pages. This stopped working when Discourse core moved to the more efficient 'loading slider' UI

2. The `listLoading` argument. This was an implementation detail of the old discovery routing infrastructure. Core recently overhauled this and removed the `listLoading` argument, because loading is now handled properly by the Ember router.

Instead of these two properties, we can use the `currentRoute` property of Ember's router service to trigger changes when navigating between pages. A common `{{#each` trick is used to fully destroy/re-render components even if the ad network is unchanged.
2023-11-07 21:12:30 +00:00
David Taylor
86ef7da2eb DEV: Apply eslint --fix 2023-11-07 18:14:12 +00:00
Roman Rizzi
4940d0ea19
FIX: Ensure we won't render the connector if there are no ads () 2022-07-14 15:58:29 -03:00
Roman Rizzi
d9b739f803
FIX: Don't render the connector when we shouldn't display an ad in the topic list item. ()
We expose the ad-slot logic to determine which ads are potentially available for each slot and don't render the connector when there are none. Leaking the component logic is not ideal, but I don't see a better solution given the
current design.
2022-07-12 16:13:18 -03:00
Arpit Jalan
5901a52dbc
FEATURE: support placing ads between topic list for house ads ()
* init

* more

* Pass td and colspan to component

* various fixes for house ads between n topics and add a test

* Make adComponents condition easier to read

Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
Co-authored-by: romanrizzi <rizziromanalejandro@gmail.com>
2022-07-07 08:53:29 -03:00
Jarek Radosz
7e2a490b67
DEV: Fix imports () 2022-03-06 19:52:19 +01:00
Jarek Radosz
c788b7bf1f
DEV: Lose the es6 suffix () 2022-03-05 17:23:41 +01:00