Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
414 Commits 6 Branches 0 Tags 2 MiB
Commit Graph

189 Commits

Author SHA1 Message Date
jjaffeux 5afca0aaa1 linting 2020-08-21 16:48:41 +02:00
Lawrence Thorpe 8439608f17
FIX: isFluid parameter for in-feed adsense units (#90) 
Fixes issue in #89
 2020-08-21 10:24:12 -04:00
Lawrence Thorpe 50788a876e
Add support for adsense fluid format for in-feed (#89) 2020-08-21 09:53:34 -04:00
Joffrey JAFFEUX 914735767a
FIX: re-revert db4f5f99 with updated tests (#88) 
The tests were using an incorrect value for the site setting (the name of the group instead of the id).

`no_ads_for_groups` shows groups names in the UI byt actually stores IDs.
 2020-08-04 08:03:22 +02:00
Penar Musaraj db4f5f990d
Revert "FIX: removes part of the 2.4 legacy code forgotten (#87)" 
This reverts commit c27d5f8e85.
 2020-08-03 21:44:10 -04:00
Joffrey JAFFEUX c27d5f8e85
FIX: removes part of the 2.4 legacy code forgotten (#87) 
no_ads_for_groups returns a list of ids
 2020-08-03 21:01:51 +02:00
Penar Musaraj 1d073e2a96
DEV: Use CSS custom properties for colors in SCSS 
Prepares the plugin for an upcoming change in core while maintaining
backwards compatiblity.
 2020-08-03 13:11:20 -04:00
jjaffeux 0a23be6008 DEV: uses html-safe instead of triple curly brackets 2020-08-01 17:48:23 +02:00
Bianca Nenciu 3fc872520e
FIX: CodeFund is shutting down (#85) 2020-07-10 18:09:32 +03:00
Robin Ward 3d0ee3f28a FIX: Prettier 2020-06-25 15:50:21 -04:00
Robin Ward 05967a8d52 FIX: Plugin was broken in stable 2020-06-25 14:51:14 -04:00
Rafael dos Santos Silva 4ded0bdba9
DEV: Fix usage of deprecated global 2020-06-04 17:30:26 -03:00
Robin Ward 5b99fd5bbd DEV: Discourse.Route has been deprecated 2020-05-12 13:58:12 -04:00
Joffrey JAFFEUX 270799166b
REFACTOR: applies discourse core coding practices (#82) 2020-03-23 09:40:29 +01:00
Neil Lalonde cd82a905ae
Load Google Ad Manager code from doubleclick.net 
https://support.google.com/admanager/answer/1638622?hl=en
 2020-03-13 14:24:54 -04:00
jjaffeux af346fc1c2 FIX: makes houses hads work with sk2 2020-02-07 10:34:58 +01:00
Gerhard Schlager 275921ac70
Make prettier happy 2020-01-16 00:12:27 +01:00
Neil Lalonde 116f9dd238 FEATURE: add support for fluid ad size in Google Ad Manager 
No width or height will be set on containers when ad size is fluid.
 2020-01-15 16:52:02 -05:00
David Taylor cf27a7be64 DEV: Stop loading external scripts while running tests (#81) 
* DEV: Stop loading external scripts while running tests

* Revert "Turn of CSP for tests"

This reverts commit db1bf99277. It had no effect, since CSP is set by the server, and this was only affecting the client
 2020-01-06 10:01:40 -07:00
Penar Musaraj 155d9f904c Import Promise from RSVP 2019-11-22 11:04:36 -05:00
Penar Musaraj b59f841944 DEV: Respect radix rule in eslint-config-discourse 1.0.6 2019-11-18 10:07:55 -05:00
Neil Lalonde 8d4df6df91 Rename house ad routes so ad blockers don't detect them 
adplugin, house_ads, house_ad_settings become
pluginad, house_creatives, and house_settings.
 2019-10-08 17:41:13 -04:00
Neil Lalonde edc549b269 UX: remove left padding of ads between posts on narrow width browsers 2019-09-17 11:27:01 -04:00
Sam Saffron 02f9145751 lint file 
AdButler is not a whitelisted constant, access it via window.
 2019-09-17 13:46:32 +10:00
Neil Lalonde 51c1b89a62 Prettier 2019-09-16 14:35:58 -04:00
discoursehosting 19f0457e8c AdButler support (#80) 2019-09-16 14:26:17 -04:00
Neil Lalonde 62888e734f FIX: handle no ad size given for AdSense and DFP ad units 
For AdSense, assume responsive size.
For DFP, don't attempt to render the ad unit.
 2019-09-10 17:07:47 -04:00
Neil Lalonde 2ad24e4a60 FEATURE: add option to disable ads in restricted categories 
Use the new setting "no ads for restricted categories".
 2019-07-22 11:43:39 -04:00
Roman Rizzi 2ceb99e151
DEV: migrate no_ads_for_groups to use IDs instead of group names (#77) [Undo revert] (#79) 
This reverts commit dee02ac3ba.
 2019-07-19 10:29:52 -03:00
Neil Lalonde 4991941d03 FIX: CodeFund ads in between posts on narrow widths 2019-07-18 12:16:02 -04:00
Neil Lalonde 71c51ebd8b FIX: ads always showing in all placements for CodeFund and Carbon Ads 
Checkboxes used to choose which placements to have ads were not handled
correctly.
 2019-07-17 14:05:58 -04:00
Roman Rizzi dee02ac3ba
Revert "DEV: migrate no_ads_for_groups to use IDs instead of group names (#77)" (#78) 
This reverts commit 09a92f3438.
 2019-07-16 11:57:20 -03:00
Neil Lalonde 93af4587fa FIX: Amazon ads never showing 2019-07-16 10:55:39 -04:00
Roman Rizzi 09a92f3438
DEV: migrate no_ads_for_groups to use IDs instead of group names (#77) 2019-07-16 11:35:16 -03:00
Neil Lalonde 3aa9cb8a0c FIX: wrong size DFP ads when using multiple sizes 
getWidthAndHeight was being called twice for each ad placement:
once when setting the size of the div, and once when calling the 
defineSlot API. getWidthAndHeight always advances to the next size
in the list, so the wrong size ad would be inserted into the div.
 2019-07-15 15:34:46 -04:00
Neil Lalonde 1929ac405c lint errors 2019-07-08 15:18:34 -04:00
Neil Lalonde 333f6cef81 FEATURE: support multiple ad sizes in AdSense and Ad Manager 
Each ad placement in the AdSense and Ad Manager settings takes a list
of ad sizes instead of only one size. If given multiple sizes, the sizes
will alternate in order for each ad that's rendered.
 2019-07-08 15:10:25 -04:00
Neil Lalonde ad939a851a FEATURE: option to disable ads on personal messages 
Use the new setting "no ads for personal messages".
 2019-06-27 14:13:51 -04:00
Neil Lalonde 2ba276b0fb FIX: DFP ad units being refreshed multiple times on the same render 
Ember is firing events multiple times when the ad component is shown.

Only solution I can find is to add a delay between calls to refresh
the ad unit. I chose 3 seconds.
 2019-06-26 11:15:04 -04:00
Brahn Partridge 89200f3b99 try io instead of app to maybe workaround CORs problem 2019-06-24 09:59:58 -04:00
Neil Lalonde 3054f2539a FEATURE: use a different Ad Manager publisher ID for mobile 
If you want to use one Ad Manager publisher on desktop and a different
one on mobile, use the new dfp_publisher_id_mobile setting.
By default, dfp_publisher_id will be used for both desktop and mobile.
 2019-06-19 11:52:23 -04:00
Neil Lalonde 25090a55a1 prettier 2019-06-17 21:00:05 -04:00
Neil Lalonde 92609c7af4 FIX: no_ads_for_tags support for hidden tags 
Hidden tags aren't sent to the client, so they couldn't be used to
disable ads on topic pages. Do this calculation on the server.
Topic list pages for tags can continue to check on the client because
non-staff get a 404 error when trying to view a hidden tag's topic list.
 2019-06-17 17:20:38 -04:00
Arpit Jalan d34b45627e Fix the build. 2019-06-15 16:01:52 +05:30
Neil Lalonde 31efc7025d FEATURE: new setting to disable ads based on tags 
Enter a list of tags in the new setting no_ads_for_tags to prevent
ads from being rendered on topics with one or more of those tags,
and on topic list pages for those tags.
 2019-06-14 14:44:09 -04:00
Penar Musaraj 574500ba08 Run Prettier 2019-06-14 13:24:55 -04:00
Penar Musaraj 203e14b639 Fix eslint warnings 2019-06-14 12:10:11 -04:00
Neil Lalonde 3a04f95916 REFACTOR: some changes to be closer to example implementation 
https://support.google.com/admanager/answer/4578089?hl=en

* unique div ID for every ad slot
* setTargeting before calling addService
* don't destroySlots async (no examples of correct way to use this...)
 2019-06-10 15:43:48 -04:00
Neil Lalonde 04525d0cf1 FIX: dfp category targeting params 
DFP category targeting param wasn't always being updated on topic
list pages.

Also remove dependency on a category param being passed in to the
component from a template so that we can now place dfp ads
in places that don't have access to the current category and
targeting will still work.
 2019-06-05 17:00:47 -04:00
Neil Lalonde 7af8f1d46b FEATURE: new setting to disable ads based on category of current page 
Use the "no ads for categories" setting to define which category pages
(topic list and topics) should not render any ads.
 2019-06-05 16:00:24 -04:00