Discource-C/discourse-adplugin
1
0
Fork 0
mirror of https://github.com/discourse/discourse-adplugin.git synced 2025-02-10 13:34:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
453 Commits 7 Branches 0 Tags
Commit Graph

197 Commits

Author SHA1 Message Date
Penar Musaraj
190aa503ce
DEV: SCSS cleanup 2021-06-23 21:59:53 -04:00
Penar Musaraj
c25c041f98
DEV: Remove SCSS color vars fallbacks (#112) 2021-05-12 16:16:40 -04:00
Jarek Radosz
a16ed5f0bf UX: Add title to iframe elements 
Fixes template linting errors
 2021-02-09 20:03:39 +01:00
Joffrey JAFFEUX
6438000ed4
DEV: prettier 2.2.1 (#101) 2021-01-27 10:36:36 +01:00
jjaffeux
9adaef17cc Revert "DEV: enforces no-var (#94)" 
This reverts commit 9ad01336244bf7f61a830ddef12b53af2bb3e996.
 2020-10-13 15:42:21 +02:00
Joffrey JAFFEUX
9ad0133624
DEV: enforces no-var (#94) 2020-10-13 11:40:33 +02:00
Joffrey JAFFEUX
15b2c1a05e
REFACTOR: loadGoogle doesn't take any argument (#92) 2020-09-23 15:05:23 +02:00
Joffrey JAFFEUX
30dad0281d
DEV: apply coding standards (#91) 2020-09-04 13:24:14 +02:00
jjaffeux
5afca0aaa1 linting 2020-08-21 16:48:41 +02:00
Lawrence Thorpe
8439608f17
FIX: isFluid parameter for in-feed adsense units (#90) 
Fixes issue in #89
 2020-08-21 10:24:12 -04:00
Lawrence Thorpe
50788a876e
Add support for adsense fluid format for in-feed (#89) 2020-08-21 09:53:34 -04:00
Joffrey JAFFEUX
914735767a
FIX: re-revert db4f5f99 with updated tests (#88) 
The tests were using an incorrect value for the site setting (the name of the group instead of the id).

`no_ads_for_groups` shows groups names in the UI byt actually stores IDs.
 2020-08-04 08:03:22 +02:00
Penar Musaraj
db4f5f990d
Revert "FIX: removes part of the 2.4 legacy code forgotten (#87)" 
This reverts commit c27d5f8e859cb80fda997db3ce2be2f0d0ce345f.
 2020-08-03 21:44:10 -04:00
Joffrey JAFFEUX
c27d5f8e85
FIX: removes part of the 2.4 legacy code forgotten (#87) 
no_ads_for_groups returns a list of ids
 2020-08-03 21:01:51 +02:00
Penar Musaraj
1d073e2a96
DEV: Use CSS custom properties for colors in SCSS 
Prepares the plugin for an upcoming change in core while maintaining
backwards compatiblity.
 2020-08-03 13:11:20 -04:00
jjaffeux
0a23be6008 DEV: uses html-safe instead of triple curly brackets 2020-08-01 17:48:23 +02:00
Bianca Nenciu
3fc872520e
FIX: CodeFund is shutting down (#85) 2020-07-10 18:09:32 +03:00
Robin Ward
3d0ee3f28a FIX: Prettier 2020-06-25 15:50:21 -04:00
Robin Ward
05967a8d52 FIX: Plugin was broken in stable 2020-06-25 14:51:14 -04:00
Rafael dos Santos Silva
4ded0bdba9
DEV: Fix usage of deprecated global 2020-06-04 17:30:26 -03:00
Robin Ward
5b99fd5bbd DEV: Discourse.Route has been deprecated 2020-05-12 13:58:12 -04:00
Joffrey JAFFEUX
270799166b
REFACTOR: applies discourse core coding practices (#82) 2020-03-23 09:40:29 +01:00
Neil Lalonde
cd82a905ae
Load Google Ad Manager code from doubleclick.net 
https://support.google.com/admanager/answer/1638622?hl=en
 2020-03-13 14:24:54 -04:00
jjaffeux
af346fc1c2 FIX: makes houses hads work with sk2 2020-02-07 10:34:58 +01:00
Gerhard Schlager
275921ac70
Make prettier happy 2020-01-16 00:12:27 +01:00
Neil Lalonde
116f9dd238 FEATURE: add support for fluid ad size in Google Ad Manager 
No width or height will be set on containers when ad size is fluid.
 2020-01-15 16:52:02 -05:00
David Taylor
cf27a7be64 DEV: Stop loading external scripts while running tests (#81) 
* DEV: Stop loading external scripts while running tests

* Revert "Turn of CSP for tests"

This reverts commit db1bf99277b18fae53201bd18bbaabe9f3680dfa. It had no effect, since CSP is set by the server, and this was only affecting the client
 2020-01-06 10:01:40 -07:00
Penar Musaraj
155d9f904c Import Promise from RSVP 2019-11-22 11:04:36 -05:00
Penar Musaraj
b59f841944 DEV: Respect radix rule in eslint-config-discourse 1.0.6 2019-11-18 10:07:55 -05:00
Neil Lalonde
8d4df6df91 Rename house ad routes so ad blockers don't detect them 
adplugin, house_ads, house_ad_settings become
pluginad, house_creatives, and house_settings.
 2019-10-08 17:41:13 -04:00
Neil Lalonde
edc549b269 UX: remove left padding of ads between posts on narrow width browsers 2019-09-17 11:27:01 -04:00
Sam Saffron
02f9145751 lint file 
AdButler is not a whitelisted constant, access it via window.
 2019-09-17 13:46:32 +10:00
Neil Lalonde
51c1b89a62 Prettier 2019-09-16 14:35:58 -04:00
discoursehosting
19f0457e8c AdButler support (#80) 2019-09-16 14:26:17 -04:00
Neil Lalonde
62888e734f FIX: handle no ad size given for AdSense and DFP ad units 
For AdSense, assume responsive size.
For DFP, don't attempt to render the ad unit.
 2019-09-10 17:07:47 -04:00
Neil Lalonde
2ad24e4a60 FEATURE: add option to disable ads in restricted categories 
Use the new setting "no ads for restricted categories".
 2019-07-22 11:43:39 -04:00
Roman Rizzi
2ceb99e151
DEV: migrate no_ads_for_groups to use IDs instead of group names (#77) [Undo revert] (#79) 
This reverts commit dee02ac3ba3a080d59084fd26011b945c615ca55.
 2019-07-19 10:29:52 -03:00
Neil Lalonde
4991941d03 FIX: CodeFund ads in between posts on narrow widths 2019-07-18 12:16:02 -04:00
Neil Lalonde
71c51ebd8b FIX: ads always showing in all placements for CodeFund and Carbon Ads 
Checkboxes used to choose which placements to have ads were not handled
correctly.
 2019-07-17 14:05:58 -04:00
Roman Rizzi
dee02ac3ba
Revert "DEV: migrate no_ads_for_groups to use IDs instead of group names (#77)" (#78) 
This reverts commit 09a92f34388042b9e3fe8f74c96cfe2718bad8c2.
 2019-07-16 11:57:20 -03:00
Neil Lalonde
93af4587fa FIX: Amazon ads never showing 2019-07-16 10:55:39 -04:00
Roman Rizzi
09a92f3438
DEV: migrate no_ads_for_groups to use IDs instead of group names (#77) 2019-07-16 11:35:16 -03:00
Neil Lalonde
3aa9cb8a0c FIX: wrong size DFP ads when using multiple sizes 
getWidthAndHeight was being called twice for each ad placement:
once when setting the size of the div, and once when calling the 
defineSlot API. getWidthAndHeight always advances to the next size
in the list, so the wrong size ad would be inserted into the div.
 2019-07-15 15:34:46 -04:00
Neil Lalonde
1929ac405c lint errors 2019-07-08 15:18:34 -04:00
Neil Lalonde
333f6cef81 FEATURE: support multiple ad sizes in AdSense and Ad Manager 
Each ad placement in the AdSense and Ad Manager settings takes a list
of ad sizes instead of only one size. If given multiple sizes, the sizes
will alternate in order for each ad that's rendered.
 2019-07-08 15:10:25 -04:00
Neil Lalonde
ad939a851a FEATURE: option to disable ads on personal messages 
Use the new setting "no ads for personal messages".
 2019-06-27 14:13:51 -04:00
Neil Lalonde
2ba276b0fb FIX: DFP ad units being refreshed multiple times on the same render 
Ember is firing events multiple times when the ad component is shown.

Only solution I can find is to add a delay between calls to refresh
the ad unit. I chose 3 seconds.
 2019-06-26 11:15:04 -04:00
Brahn Partridge
89200f3b99 try io instead of app to maybe workaround CORs problem 2019-06-24 09:59:58 -04:00
Neil Lalonde
3054f2539a FEATURE: use a different Ad Manager publisher ID for mobile 
If you want to use one Ad Manager publisher on desktop and a different
one on mobile, use the new dfp_publisher_id_mobile setting.
By default, dfp_publisher_id will be used for both desktop and mobile.
 2019-06-19 11:52:23 -04:00
Neil Lalonde
25090a55a1 prettier 2019-06-17 21:00:05 -04:00