Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
547 Commits 6 Branches 0 Tags 2.3 MiB
Commit Graph

547 Commits

Author SHA1 Message Date
Robin Ward 3d0ee3f28a FIX: Prettier 2020-06-25 15:50:21 -04:00
Robin Ward 05967a8d52 FIX: Plugin was broken in stable 2020-06-25 14:51:14 -04:00
Neil Lalonde cff1459dbc
Update translations 2020-06-24 11:39:24 -04:00
Kane York 5273d52f28
FIX: Do not require login to see ads.txt (#84) 2020-06-24 16:26:04 +10:00
Rafael dos Santos Silva 4ded0bdba9
DEV: Fix usage of deprecated global 2020-06-04 17:30:26 -03:00
Robin Ward 5b99fd5bbd DEV: Discourse.Route has been deprecated 2020-05-12 13:58:12 -04:00
jjaffeux ef316ab4ac DEV: Move to rubocop-discourse. 2020-05-06 17:43:43 +02:00
Neil Lalonde f11382e224
Update translations 2020-05-04 10:47:54 -04:00
Rishabh f7582f0df8
Update README.md 
plugin installation info is now at https://meta.discourse.org/t/install-plugins-in-discourse/19157
 2020-04-17 16:21:28 +05:30
Joffrey JAFFEUX 270799166b
REFACTOR: applies discourse core coding practices (#82) 2020-03-23 09:40:29 +01:00
Neil Lalonde cd82a905ae
Load Google Ad Manager code from doubleclick.net 
https://support.google.com/admanager/answer/1638622?hl=en
 2020-03-13 14:24:54 -04:00
Neil Lalonde bec86bd59a Update translations 2020-02-25 10:30:45 -05:00
Neil Lalonde f2ccce4beb Update translations 2020-02-13 15:03:14 -05:00
jjaffeux af346fc1c2 FIX: makes houses hads work with sk2 2020-02-07 10:34:58 +01:00
Neil Lalonde 63ae1672ad Add note about CSP to DFP, AdSense, and AdButler settings 
Ad networks that serve javascript files won't work unless CSP is
disabled (a bad idea), or the content security policy script src
site setting is updated to include all sources of permitted
javascript. We will keep instructions up-to-date in the first post
of this topic: https://meta.discourse.org/t/33734
 2020-02-03 17:18:42 -05:00
Neil Lalonde 3fdd0f35f3 Update translations 2020-01-20 11:19:03 -05:00
Gerhard Schlager 275921ac70
Make prettier happy 2020-01-16 00:12:27 +01:00
Neil Lalonde 116f9dd238 FEATURE: add support for fluid ad size in Google Ad Manager 
No width or height will be set on containers when ad size is fluid.
 2020-01-15 16:52:02 -05:00
David Taylor cf27a7be64 DEV: Stop loading external scripts while running tests (#81) 
* DEV: Stop loading external scripts while running tests

* Revert "Turn of CSP for tests"

This reverts commit db1bf99277. It had no effect, since CSP is set by the server, and this was only affecting the client
 2020-01-06 10:01:40 -07:00
Blake Erickson db1bf99277 Turn of CSP for tests 2020-01-03 16:30:34 -07:00
Neil Lalonde 73aa618aef Update translations 2019-12-19 12:48:16 -05:00
Penar Musaraj 155d9f904c Import Promise from RSVP 2019-11-22 11:04:36 -05:00
Penar Musaraj b59f841944 DEV: Respect radix rule in eslint-config-discourse 1.0.6 2019-11-18 10:07:55 -05:00
Neil Lalonde a3e3dbf24b Update translations 2019-11-06 10:44:38 -05:00
Neil Lalonde 0d534ce52a Update translations 2019-10-10 11:24:07 -04:00
Neil Lalonde 8d4df6df91 Rename house ad routes so ad blockers don't detect them 
adplugin, house_ads, house_ad_settings become
pluginad, house_creatives, and house_settings.
 2019-10-08 17:41:13 -04:00
Neil Lalonde edc549b269 UX: remove left padding of ads between posts on narrow width browsers 2019-09-17 11:27:01 -04:00
Sam Saffron 02f9145751 lint file 
AdButler is not a whitelisted constant, access it via window.
 2019-09-17 13:46:32 +10:00
Neil Lalonde cc09403757 Bump to version 1.2.5 2019-09-16 15:03:47 -04:00
Neil Lalonde 9a02cae641 Update README with info about new settings 
Also remove outdated list of supported sizes. It's not a useful table.
 2019-09-16 15:03:14 -04:00
Neil Lalonde 6704238c94 Update README with more info about AdButler support 2019-09-16 14:50:15 -04:00
Neil Lalonde 51c1b89a62 Prettier 2019-09-16 14:35:58 -04:00
discoursehosting 19f0457e8c AdButler support (#80) 2019-09-16 14:26:17 -04:00
Neil Lalonde b500ea171f DEV: Add tests for no_ads_for_categories 2019-09-11 12:18:42 -04:00
Neil Lalonde 0612054da8 Bump to version 1.2.4 2019-09-10 17:09:21 -04:00
Neil Lalonde 62888e734f FIX: handle no ad size given for AdSense and DFP ad units 
For AdSense, assume responsive size.
For DFP, don't attempt to render the ad unit.
 2019-09-10 17:07:47 -04:00
Neil Lalonde 2ad24e4a60 FEATURE: add option to disable ads in restricted categories 
Use the new setting "no ads for restricted categories".
 2019-07-22 11:43:39 -04:00
Roman Rizzi 2ceb99e151
DEV: migrate no_ads_for_groups to use IDs instead of group names (#77) [Undo revert] (#79) 
This reverts commit dee02ac3ba.
 2019-07-19 10:29:52 -03:00
Neil Lalonde 4991941d03 FIX: CodeFund ads in between posts on narrow widths 2019-07-18 12:16:02 -04:00
Neil Lalonde 71c51ebd8b FIX: ads always showing in all placements for CodeFund and Carbon Ads 
Checkboxes used to choose which placements to have ads were not handled
correctly.
 2019-07-17 14:05:58 -04:00
Roman Rizzi dee02ac3ba
Revert "DEV: migrate no_ads_for_groups to use IDs instead of group names (#77)" (#78) 
This reverts commit 09a92f3438.
 2019-07-16 11:57:20 -03:00
Neil Lalonde 93af4587fa FIX: Amazon ads never showing 2019-07-16 10:55:39 -04:00
Roman Rizzi 09a92f3438
DEV: migrate no_ads_for_groups to use IDs instead of group names (#77) 2019-07-16 11:35:16 -03:00
Neil Lalonde 3aa9cb8a0c FIX: wrong size DFP ads when using multiple sizes 
getWidthAndHeight was being called twice for each ad placement:
once when setting the size of the div, and once when calling the 
defineSlot API. getWidthAndHeight always advances to the next size
in the list, so the wrong size ad would be inserted into the div.
 2019-07-15 15:34:46 -04:00
Neil Lalonde e8295c600c Update translations 2019-07-15 13:59:41 -04:00
Neil Lalonde 1929ac405c lint errors 2019-07-08 15:18:34 -04:00
Neil Lalonde 333f6cef81 FEATURE: support multiple ad sizes in AdSense and Ad Manager 
Each ad placement in the AdSense and Ad Manager settings takes a list
of ad sizes instead of only one size. If given multiple sizes, the sizes
will alternate in order for each ad that's rendered.
 2019-07-08 15:10:25 -04:00
Neil Lalonde 6f786b2f4d Bump to version 1.2.3 2019-06-27 14:16:19 -04:00
Neil Lalonde ad939a851a FEATURE: option to disable ads on personal messages 
Use the new setting "no ads for personal messages".
 2019-06-27 14:13:51 -04:00
Neil Lalonde 2ba276b0fb FIX: DFP ad units being refreshed multiple times on the same render 
Ember is firing events multiple times when the ad component is shown.

Only solution I can find is to add a delay between calls to refresh
the ad unit. I chose 3 seconds.
 2019-06-26 11:15:04 -04:00